radex
/
jspaint
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update TODO and @TODOs and comments

main
Isaiah Odhner 2014-10-26 21:16:43 -04:00
parent 97400989c5
commit 5f5b6e9504
2 changed files with 45 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
TODO.md
View File

@ -23,13 +23,15 @@
* Tips and Tricks from [this tutorial](http://www.albinoblacksheep.com/tutorial/mspaint)
* The Grid (Ctrl+G & zoom6x+)
* Scroll Wheel Bug (um...)
* The Grid (Ctrl+G & zoom6x+) (prerequisite: zooming)
* Scroll Wheel Bug (um... it's not really a feature)
* Issues
* Colors > Edit Colors... doesn't work when the $colorbox is hidden
* Component windows are gone forever once closed (can't be shown from View menu)
* Components
* Colors > Edit Colors... doesn't work when the $colorbox is hidden
* Component windows are gone forever once closed (can't be shown from the View menu)
* Components in windows hidden from the View menu don't hide their windows
* Status text gets cut off
* Also, it should gracefully push the dimension displays off the edge
instead of covering up the text with usually blank space
@ -62,6 +64,23 @@
* Mouse navigation ✓
* Keyboard Navigation
* Descriptions of menu items in the status bar
* Enable items (Repeat, Clear Selection, Copy To...) when they are applicable
* Disable Image > Clear Image when there is a selection like MS Paint does?
* Menu Items
* View
* Show/Hide FontBox
* Zoom should have an actual submenu (prerequisite: zooming)
* Image
* Stretch / Skew (functionality)
* Sliding animation / transition effects
* Use keyboard shortcuts defined in the menu data structure to declaratively setup hotkeys
* ```
On key press, loop through the menus
@ -69,17 +88,6 @@
Perform menu item's action
Break loop
```
* Enable items (Repeat, Clear Selection, Copy To...) when they are applicable
* Disable Image > Clear Image when there is a selection like MS Paint does?
* Sliding animation / transition effects
* Menu Items
* View
* Show/Hide FontBox
* Zoom should have an actual submenu (but it's pointless without zoom functionality)
* Image
* Stretch / Skew (functionality)
### Components / Windows
@ -120,6 +128,7 @@
* Multiplayer
* See [multiplayer.js](multiplayer.js)
* Deal with undo/redo for sessions
### Mobile support
@ -259,13 +268,14 @@ Load palettes with [palette.js](https://github.com/1j01/palette.js/)
* Transparency with selected background color
* Proportionally resize selection while holding Shift
* Don't cut until you drag or do something else (In MS Paint, you can make a selection, change the background color and drag it, leaving the new background color behind.)
* Classic transparency where the selected background color is considered transparent
* TextBox
* See Text tool
* Selection and TextBox should inherit from a base class for on-canvas objects
* Selection and TextBox should inherit from a base class
### BSOD

22
src/multiplayer.js
View File

@ -77,6 +77,7 @@
fb.on(event_type, callback);
};
// Get Firebase references
session.fb = Session.fb_root.child(session.id);
session.fb_data = session.fb.child("data");
session.fb_users = session.fb.child("users");
@ -86,9 +87,13 @@
session.fb_user = session.fb_users.push();
user_id = session.fb_user.name();
}
// Remove the user from the session when they disconnect
session.fb_user.onDisconnect().remove();
// Make the user present in the session
session.fb_user.set(user);
// For each existing and new user
_fb_on(session.fb_users, "child_added", function(snap){
// Is this you?
@ -100,7 +105,7 @@
// Get the Firebase reference for this user
var fb_other_user = snap.ref();
// The user of the cursor we'll be drawing
// Get the user object stored on the server
var other_user = snap.val();
// Draw the cursor
@ -115,9 +120,11 @@
cursor_ctx.globalCompositeOperation = "destination-atop";
cursor_ctx.drawImage(img, 0, 0);
};
// @TODO @FIXME: stop requesting this image for each and every user
img.src = "images/cursors/default.png";
// @TODO: display other cursor types?
// @TODO: display mouse button state?
// @TODO: display selections
// Make the $cursor element
var $cursor = $(cursor_canvas).addClass("user-cursor").appendTo($app);
@ -163,18 +170,23 @@
}
};
// Any time we recieve the image data or the data changes...
// Any time we change or recieve the image data
_fb_on(session.fb_data, "value", function(snap){
debug("data update");
var uri = snap.val();
// Is there a value at this session's data location?
if(uri == null){
// This is a new session
// Sync the current data to it
sync();
}else{
previous_uri = uri;
// Cancel any in-progress mouse operations
$G.triggerHandler("mouseup", "cancel");
// Write the image data to the canvas
var img = new Image();
img.onload = function(){
canvas.width = img.naturalWidth;
@ -197,6 +209,7 @@
$canvas.on("user-resized.session-hook", sync);
$(".jspaint-canvas-area").on("mousedown.session-hook", "*", function(){
// @TODO: update immediately on mousedown with fill tool
$G.one("mouseup.session-hook", sync);
});
@ -219,6 +232,7 @@
session.fb_user.child("cursor").update({
away: true,
});
// @CHANGEME: avoid fb.update()
});
// @FIXME: the cursor can come back from "away" via a mouse event
@ -289,5 +303,7 @@
}).triggerHandler("hashchange");
// @TODO: Session GUI
// @TODO: /#session:new to create a new session
// @TODO: URL to create a new session: /#session: and/or /#session:new
// @TODO: Show user when the session id is invalid
// @TODO: Show user when the session changes
})();