hswaw
/
labelmaker
6
0
Fork 5
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

labelmaker 2.0 #2

Merged
radex merged 9 commits from etorameth/labelmaker:master into master 2024-02-07 17:10:06 +00:00
Conversation 0 Commits 9 Files Changed 12
etorameth commented 2024-02-07 12:34:49 +00:00

updated labelmaker to python 3 and created a Dockerfile

updated labelmaker to python 3 and created a Dockerfile
etorameth added 6 commits 2024-02-07 12:34:50 +00:00
radex requested changes 2024-02-07 13:08:48 +00:00
Dockerfile Outdated
@ -0,0 +16,4 @@
POETRY_HOME='/code/poetry' \
POETRY_VERSION=1.7.1 \
# PrintServant:
PRINTSERVANT_HOST='http://host.docker.internal:3199'
radex commented 2024-02-07 13:04:14 +00:00
Owner

this shouldn't be in the Dockerfile

this shouldn't be in the Dockerfile
etorameth marked this conversation as resolved
Dockerfile
@ -0,0 +44,4 @@
&& useradd -d '/code' -g web -l -r -u "1000" web \
&& chown web:web -R '/code'
RUN git clone https://code.hackerspace.pl/etorameth/labelmaker
radex commented 2024-02-07 13:04:39 +00:00
Owner

this shouldn't be here, you should COPY files from local catalog to the image

this shouldn't be here, you should `COPY` files from local catalog to the image
etorameth marked this conversation as resolved
labelmaker/main.py Outdated
@ -0,0 +90,4 @@
last = app.last
print(last, time.time() - last)
if time.time() - last < DELAY:
return 'Please wait {} more seconds before next print.'.format(int(DELAY - (time.time() - last)))
radex commented 2024-02-07 13:05:50 +00:00
Owner

I think we can get rid of this delay logic? These should get queued now, no?

I think we can get rid of this delay logic? These should get queued now, no?
etorameth marked this conversation as resolved
labelmaker/templates/index.html
@ -0,0 +47,4 @@
</div>
</div>
</div>
<div class="container">
radex commented 2024-02-07 13:08:03 +00:00
Owner

out of scope for this PR, so feel free to ignore it, but I suggest getting rid of the bootstrap import from a CDN, and moving a copy of it into the repo -- we like to be self-reliant and not call outside services if possible

out of scope for this PR, so feel free to ignore it, but I suggest getting rid of the bootstrap import from a CDN, and moving a copy of it into the repo -- we like to be self-reliant and not call outside services if possible
etorameth marked this conversation as resolved
labelmaker/templates/index.html Outdated
@ -0,0 +93,4 @@
on <a href="https://code.hackerspace.pl/hswaw/labelmaker">code.hackerspace.pl/hswaw/labelmaker</a></p>
</div>
</footer>
<script src="https://code.jquery.com/jquery-2.1.4.min.js"></script>
radex commented 2024-02-07 13:08:43 +00:00
Owner

same thing as with bootstrap - would prefer if these scripts were part of the repo, instead of calling external servers.

same thing as with bootstrap - would prefer if these scripts were part of the repo, instead of calling external servers.
etorameth marked this conversation as resolved
etorameth force-pushed master from 1a9b745fd3 to 46c487a9b0 2024-02-07 13:18:27 +00:00 Compare
etorameth added 1 commit 2024-02-07 13:23:42 +00:00
etorameth added 1 commit 2024-02-07 13:33:49 +00:00
radex merged commit 6b667b1cba into master 2024-02-07 17:10:06 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
radex
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hswaw/labelmaker#2
There is no content yet.
Delete Branch "etorameth/labelmaker:master"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?