e7d2860b69
Makes use of skip_spaces() defined in lib/string.c for removing leading spaces from strings all over the tree. It decreases lib.a code size by 47 bytes and reuses the function tree-wide: text data bss dec hex filename 64688 584 592 65864 10148 (TOTALS-BEFORE) 64641 584 592 65817 10119 (TOTALS-AFTER) Also, while at it, if we see (*str && isspace(*str)), we can be sure to remove the first condition (*str) as the second one (isspace(*str)) also evaluates to 0 whenever *str == 0, making it redundant. In other words, "a char equals zero is never a space". Julia Lawall tried the semantic patch (http://coccinelle.lip6.fr) below, and found occurrences of this pattern on 3 more files: drivers/leds/led-class.c drivers/leds/ledtrig-timer.c drivers/video/output.c @@ expression str; @@ ( // ignore skip_spaces cases while (*str && isspace(*str)) { \(str++;\|++str;\) } | - *str && isspace(*str) ) Signed-off-by: André Goddard Rosa <andre.goddard@gmail.com> Cc: Julia Lawall <julia@diku.dk> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> Cc: Jeff Dike <jdike@addtoit.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: "H. Peter Anvin" <hpa@zytor.com> Cc: Richard Purdie <rpurdie@rpsys.net> Cc: Neil Brown <neilb@suse.de> Cc: Kyle McMartin <kyle@mcmartin.ca> Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br> Cc: David Howells <dhowells@redhat.com> Cc: <linux-ext4@vger.kernel.org> Cc: Samuel Ortiz <samuel@sortiz.org> Cc: Patrick McHardy <kaber@trash.net> Cc: Takashi Iwai <tiwai@suse.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
132 lines
3.4 KiB
C
132 lines
3.4 KiB
C
/*
|
|
* output.c - Display Output Switch driver
|
|
*
|
|
* Copyright (C) 2006 Luming Yu <luming.yu@intel.com>
|
|
*
|
|
* ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or (at
|
|
* your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA.
|
|
*
|
|
* ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
*/
|
|
#include <linux/module.h>
|
|
#include <linux/video_output.h>
|
|
#include <linux/err.h>
|
|
#include <linux/ctype.h>
|
|
|
|
|
|
MODULE_DESCRIPTION("Display Output Switcher Lowlevel Control Abstraction");
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_AUTHOR("Luming Yu <luming.yu@intel.com>");
|
|
|
|
static ssize_t video_output_show_state(struct device *dev,
|
|
struct device_attribute *attr, char *buf)
|
|
{
|
|
ssize_t ret_size = 0;
|
|
struct output_device *od = to_output_device(dev);
|
|
if (od->props)
|
|
ret_size = sprintf(buf,"%.8x\n",od->props->get_status(od));
|
|
return ret_size;
|
|
}
|
|
|
|
static ssize_t video_output_store_state(struct device *dev,
|
|
struct device_attribute *attr,
|
|
const char *buf,size_t count)
|
|
{
|
|
char *endp;
|
|
struct output_device *od = to_output_device(dev);
|
|
int request_state = simple_strtoul(buf,&endp,0);
|
|
size_t size = endp - buf;
|
|
|
|
if (isspace(*endp))
|
|
size++;
|
|
if (size != count)
|
|
return -EINVAL;
|
|
|
|
if (od->props) {
|
|
od->request_state = request_state;
|
|
od->props->set_state(od);
|
|
}
|
|
return count;
|
|
}
|
|
|
|
static void video_output_release(struct device *dev)
|
|
{
|
|
struct output_device *od = to_output_device(dev);
|
|
kfree(od);
|
|
}
|
|
|
|
static struct device_attribute video_output_attributes[] = {
|
|
__ATTR(state, 0644, video_output_show_state, video_output_store_state),
|
|
__ATTR_NULL,
|
|
};
|
|
|
|
|
|
static struct class video_output_class = {
|
|
.name = "video_output",
|
|
.dev_release = video_output_release,
|
|
.dev_attrs = video_output_attributes,
|
|
};
|
|
|
|
struct output_device *video_output_register(const char *name,
|
|
struct device *dev,
|
|
void *devdata,
|
|
struct output_properties *op)
|
|
{
|
|
struct output_device *new_dev;
|
|
int ret_code = 0;
|
|
|
|
new_dev = kzalloc(sizeof(struct output_device),GFP_KERNEL);
|
|
if (!new_dev) {
|
|
ret_code = -ENOMEM;
|
|
goto error_return;
|
|
}
|
|
new_dev->props = op;
|
|
new_dev->dev.class = &video_output_class;
|
|
new_dev->dev.parent = dev;
|
|
dev_set_name(&new_dev->dev, name);
|
|
dev_set_drvdata(&new_dev->dev, devdata);
|
|
ret_code = device_register(&new_dev->dev);
|
|
if (ret_code) {
|
|
kfree(new_dev);
|
|
goto error_return;
|
|
}
|
|
return new_dev;
|
|
|
|
error_return:
|
|
return ERR_PTR(ret_code);
|
|
}
|
|
EXPORT_SYMBOL(video_output_register);
|
|
|
|
void video_output_unregister(struct output_device *dev)
|
|
{
|
|
if (!dev)
|
|
return;
|
|
device_unregister(&dev->dev);
|
|
}
|
|
EXPORT_SYMBOL(video_output_unregister);
|
|
|
|
static void __exit video_output_class_exit(void)
|
|
{
|
|
class_unregister(&video_output_class);
|
|
}
|
|
|
|
static int __init video_output_class_init(void)
|
|
{
|
|
return class_register(&video_output_class);
|
|
}
|
|
|
|
postcore_initcall(video_output_class_init);
|
|
module_exit(video_output_class_exit);
|