linux/drivers/media/dvb/firewire
Stefan Richter 686a9488cd [media] firedtv: change some -EFAULT returns to more fitting error codes
Mauro Carvalho Chehab wrote:
> I'm validating if all drivers are behaving equally with respect to the
> error codes returned to userspace, and double-checking with the API.
>
> On almost all places, -EFAULT code is used only to indicate when
> copy_from_user/copy_to_user fails. However, firedtv uses a lot of
> -EFAULT, where it seems to me that other error codes should be used
> instead (like -EIO for bus transfer errors and -EINVAL/-ERANGE for
> invalid/out of range parameters).

This concerns only the CI (CAM) related code of firedtv of which I know
little.  Let's just pass through the error returns of lower level I/O
code where applicable, and -EACCES (permission denied) when a seemingly
valid but negative FCP response or an unknown-to-firedtv CA message is
received.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Henrik Kurelid <henrik@kurelid.se>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2011-07-27 17:53:38 -03:00
..
firedtv-avc.c [media] firedtv: change some -EFAULT returns to more fitting error codes 2011-07-27 17:53:38 -03:00
firedtv-ci.c [media] firedtv: change some -EFAULT returns to more fitting error codes 2011-07-27 17:53:38 -03:00
firedtv-dvb.c [media] firedtv: drop obsolete backend abstraction 2011-03-21 20:32:21 -03:00
firedtv-fe.c [media] firedtv: drop obsolete backend abstraction 2011-03-21 20:32:21 -03:00
firedtv-fw.c firewire: optimize iso queueing by setting wake only after the last packet 2011-05-10 22:53:45 +02:00
firedtv-rc.c [media] firedtv: fix remote control with newer Xorg evdev 2011-01-19 11:45:59 -02:00
firedtv.h [media] firedtv: drop obsolete backend abstraction 2011-03-21 20:32:21 -03:00
Kconfig [media] firedtv: remove obsolete ieee1394 backend code 2011-03-21 20:32:12 -03:00
Makefile [media] firedtv: remove obsolete ieee1394 backend code 2011-03-21 20:32:12 -03:00