q3k/linux
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
linux/drivers/staging/vt6656
History
Julia Lawall 17fb76165f drivers/staging/vt6656/main_usb.c: Delete unnecessary call to usb_kill_urb 
Since in each case nothing has been done with the recently allocated urb,
it is not necessary to kill it before freeing it.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
expression urb;
statement S;
position p1,p2;
@@

urb = usb_alloc_urb@p1(...);
... when != urb
if (urb == NULL) S
... when != urb
usb_kill_urb@p2(urb);

@other exists@
position r.p1,r.p2;
@@

... when != usb_alloc_urb@p1(...)
usb_kill_urb@p2(...);

@depends on !other exists@
expression urb;
position r.p1,r.p2;
@@

urb = usb_alloc_urb@p1(...);
...
(
-usb_kill_urb@p2(urb);
+usb_free_urb(urb);
... when != urb
|
-usb_kill_urb@p2(urb);
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-05-17 11:37:57 -07:00
..
80211hdr.h
80211mgr.c Staging: vt665*: fix typos concerning "management" 2010-06-18 10:42:07 -07:00
80211mgr.h staging: vt6656: removed not useful comments 2010-08-31 11:14:39 -07:00
aes_ccmp.c Staging: vt6656: fix up built-in compilation together with rt2870 2010-06-18 10:37:48 -07:00
aes_ccmp.h
baseband.c drivers/staging: Remove unnecessary semicolons 2010-11-16 12:06:47 -08:00
baseband.h Staging: vt6656: code cleanup, resolved checkpatch findings in headers 2010-06-18 10:35:33 -07:00
bssdb.c staging: Remove unnecessary semicolons when if (foo) {...}; 2011-04-25 16:58:34 -07:00
bssdb.h Staging: vt6656: Remove PUINT from ttype.h 2010-08-02 18:16:27 -07:00
card.c staging: vt6656: resolved checkpatch finding 2010-11-09 15:55:53 -08:00
card.h
channel.c staging: vt6656: removed dummy errors like extra spaces 2010-09-16 12:37:35 -07:00
channel.h Staging: vt6656: code cleanup, resolved checkpatch findings in headers 2010-06-18 10:35:33 -07:00
control.c staging: vt6656: removed NTSTATUS definition 2010-08-02 18:19:04 -07:00
control.h Staging: vt6656: code cleanup, resolved checkpatch findings in headers 2010-06-18 10:35:33 -07:00
country.h
datarate.c staging: vt6656: removed '#if 1'/'#if 0' definitions 2010-07-22 11:42:00 -07:00
datarate.h
desc.h Staging: vt6656: code cleanup, resolved checkpatch findings in headers 2010-06-18 10:35:33 -07:00
device.h vt6656: Use request_firmware() to load firmware 2011-01-21 12:19:11 -08:00
device_cfg.h Staging: vt6656: code cleanup, resolved checkpatch findings in headers 2010-06-18 10:35:33 -07:00
dpc.c staging: Remove unnecessary semicolons when if (foo) {...}; 2011-04-25 16:58:34 -07:00
dpc.h
firmware.c staging: vt6656: Remove NULL check before kfree 2011-03-14 11:57:37 -07:00
firmware.h
hostap.c staging: vt6656: Remove NULL check before kfree 2011-03-14 11:57:37 -07:00
hostap.h
int.c staging: vt6656: removed NTSTATUS definition 2010-08-02 18:19:04 -07:00
int.h staging: vt6656: removed NTSTATUS definition 2010-08-02 18:19:04 -07:00
iocmd.h Staging: vt665x: remove unused DEF definition 2010-09-16 13:02:36 -07:00
ioctl.c staging: Remove unnecessary semicolons when for (foo) {...}; 2011-04-25 16:58:35 -07:00
ioctl.h
iowpa.h Staging: vt6656: code cleanup, resolved checkpatch findings in headers 2010-06-18 10:35:33 -07:00
iwctl.c drivers/staging: Remove unnecessary semicolons 2010-11-16 12:06:47 -08:00
iwctl.h staging: vt6656: removed not useful comments 2010-08-31 11:14:39 -07:00
Kconfig Staging: vt665?: prevent modules from being built into the kernel. 2011-04-04 21:33:26 -07:00
key.c staging: vt6656: resolved checkpatch finding 2010-08-31 11:35:06 -07:00
key.h
mac.c staging: vt6656: Fixed indentation with spaces 2010-09-16 12:37:35 -07:00
mac.h Staging: vt6656: code cleanup, resolved checkpatch findings in headers 2010-06-18 10:35:33 -07:00
main_usb.c drivers/staging/vt6656/main_usb.c: Delete unnecessary call to usb_kill_urb 2011-05-17 11:37:57 -07:00
Makefile Staging: vt6656: Makefile: cleaned up Makefile cflag lines 2010-10-05 11:56:38 -07:00
mib.c staging: vt6656: removed NTSTATUS definition 2010-08-02 18:19:04 -07:00
mib.h staging: vt6656: removed NTSTATUS definition 2010-08-02 18:19:04 -07:00
michael.c
michael.h Staging: vt6656: code cleanup, resolved checkpatch findings in headers 2010-06-18 10:35:33 -07:00
power.c Staging: vt6656: Clean up switching to power saving mode. 2011-03-02 15:52:30 -05:00
power.h Staging: vt665*: fix typos concerning "management" 2010-06-18 10:42:07 -07:00
rc4.c
rc4.h
rf.c
rf.h Staging: vt6656: code cleanup, resolved checkpatch findings in headers 2010-06-18 10:35:33 -07:00
rndis.h Staging: vt6656: code cleanup, resolved checkpatch findings in headers 2010-06-18 10:35:33 -07:00
rxtx.c staging: Remove unnecessary semicolons when if (foo) {...}; 2011-04-25 16:58:34 -07:00
rxtx.h staging: vt6656: removed NTSTATUS definition 2010-08-02 18:19:04 -07:00
srom.h
tcrc.c
tcrc.h
tether.c
tether.h staging: vt6656: removed custom definitions of Ethernet packet types 2010-08-31 11:31:25 -07:00
tkip.c staging: vt6656 resolved parenthesis not spaces 2010-11-09 15:55:54 -08:00
tkip.h
tmacro.h
TODO
ttype.h Staging: vt6656: Remove PUINT from ttype.h 2010-08-02 18:16:27 -07:00
upc.h
usbpipe.c staging: vt6656: removed macro to test bits 2010-08-31 11:31:26 -07:00
usbpipe.h staging: vt6656: removed NTSTATUS definition 2010-08-02 18:19:04 -07:00
vntconfiguration.dat
wcmd.c staging: Remove unnecessary semicolons when if (foo) {...}; 2011-04-25 16:58:34 -07:00
wcmd.h staging: vt6656: removed TxInSleep definition 2010-07-08 13:01:05 -07:00
wctl.c staging: vt6656: replace IS_ETH_ADDRESS_EQUAL with compare_ether_addr 2010-06-24 14:15:07 -07:00
wctl.h
wmgr.c staging: Remove unnecessary semicolons when for (foo) {...}; 2011-04-25 16:58:35 -07:00
wmgr.h Fix common misspellings 2011-03-31 11:26:23 -03:00
wpa.c staging: vt6656: removed extra spaces 2010-08-31 11:35:05 -07:00
wpa.h
wpa2.c drivers/staging: Remove unnecessary semicolons 2010-11-16 12:06:47 -08:00
wpa2.h Staging: vt6656: code cleanup, resolved checkpatch findings in headers 2010-06-18 10:35:33 -07:00
wpactl.c staging: Remove unnecessary semicolons when switch (foo) {...}; 2011-04-25 16:58:35 -07:00
wpactl.h