linux/fs/ext2
Josh Hunt e8a80c6f76 ext2: Fix link count corruption under heavy link+rename load
vfs_rename_other() does not lock renamed inode with i_mutex. Thus changing
i_nlink in a non-atomic manner (which happens in ext2_rename()) can corrupt
it as reported and analyzed by Josh.

In fact, there is no good reason to mess with i_nlink of the moved file.
We did it presumably to simulate linking into the new directory and unlinking
from an old one. But the practical effect of this is disputable because fsck
can possibly treat file as being properly linked into both directories without
writing any error which is confusing. So we just stop increment-decrement
games with i_nlink which also fixes the corruption.

CC: stable@kernel.org
CC: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Josh Hunt <johunt@akamai.com>
Signed-off-by: Jan Kara <jack@suse.cz>
2011-03-02 11:03:52 +01:00
..
acl.c ext2,3,4: provide simple rcu-walk ACL implementation 2011-01-07 17:50:30 +11:00
acl.h fs: provide rcu-walk aware permission i_ops 2011-01-07 17:50:29 +11:00
balloc.c ext2: fix comment on ext2_try_to_allocate() 2010-10-28 01:30:01 +02:00
dir.c ext2: speed up file creates by optimizing rec_len functions 2011-01-10 19:04:06 +01:00
ext2.h fs: add sync_inode_metadata 2010-10-25 21:18:19 -04:00
file.c ext2: convert to use the new truncate convention. 2010-05-27 22:15:57 -04:00
ialloc.c merge ext2 delete_inode and clear_inode, switch to ->evict_inode() 2010-08-09 16:47:57 -04:00
inode.c ext2: fixed typo. 2010-10-28 01:30:05 +02:00
ioctl.c headers: smp_lock.h redux 2009-07-12 12:22:34 -07:00
Kconfig
Makefile switch ext2 to simple_fsync() 2009-06-11 21:36:12 -04:00
namei.c ext2: Fix link count corruption under heavy link+rename load 2011-03-02 11:03:52 +01:00
super.c Merge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs-2.6 2011-01-11 14:36:55 -08:00
symlink.c ext2: symlink must be handled via filesystem specific operation 2010-04-12 21:11:25 +02:00
xattr.c ext2: remove dead code in ext2_xattr_get 2011-01-10 12:10:37 -05:00
xattr.h ext2: constify xattr_handler 2010-05-21 18:31:18 -04:00
xattr_security.c ext2: constify xattr_handler 2010-05-21 18:31:18 -04:00
xattr_trusted.c ext2: constify xattr_handler 2010-05-21 18:31:18 -04:00
xattr_user.c ext2: constify xattr_handler 2010-05-21 18:31:18 -04:00
xip.c ext2: Unify log messages in ext2 2009-12-10 15:02:52 +01:00
xip.h