q3k
/
linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
linux/fs/notify/inotify
History
Eric Paris d0de4dc584 inotify: fix double free/corruption of stuct user 
On an error path in inotify_init1 a normal user can trigger a double
free of struct user.  This is a regression introduced by a2ae4cc9a1
("inotify: stop kernel memory leak on file creation failure").

We fix this by making sure that if a group exists the user reference is
dropped when the group is cleaned up.  We should not explictly drop the
reference on error and also drop the reference when the group is cleaned
up.

The new lifetime rules are that an inotify group lives from
inotify_new_group to the last fsnotify_put_group.  Since the struct user
and inotify_devs are directly tied to this lifetime they are only
changed/updated in those two locations.  We get rid of all special
casing of struct user or user->inotify_devs.

Signed-off-by: Eric Paris <eparis@redhat.com>
Cc: stable@kernel.org (2.6.37 and up)
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
 		2011-04-05 15:27:14 -07:00
..
Kconfig inotify: remove inotify in kernel interface 2010-07-28 09:58:31 -04:00
Makefile inotify: remove inotify in kernel interface 2010-07-28 09:58:31 -04:00
inotify.h inotify: rename mark_entry to just mark 2010-07-28 09:58:54 -04:00
inotify_fsnotify.c inotify: fix double free/corruption of stuct user 2011-04-05 15:27:14 -07:00
inotify_user.c inotify: fix double free/corruption of stuct user 2011-04-05 15:27:14 -07:00