linux/drivers/net/e1000e
Ingo Molnar e8ebe3b893 e1000e: fix e1000_netpoll(), remove extraneous e1000_clean_tx_irq() call
Evgeniy Polyakov noticed that drivers/net/e1000e/netdev.c:e1000_netpoll()
was calling e1000_clean_tx_irq() without taking the TX lock.

David Miller suggested to remove the call altogether: since in this
callpah there's periodic calls to ->poll() anyway which will do
e1000_clean_tx_irq() and will garbage-collect any finished TX ring
descriptors.

This fix solved the e1000e+netconsole crashes i've been seeing:

=============================================================================
BUG skbuff_head_cache: Poison overwritten
-----------------------------------------------------------------------------

INFO: 0xf658ae9c-0xf658ae9c. First byte 0x6a instead of 0x6b
INFO: Allocated in __alloc_skb+0x2c/0x110 age=0 cpu=0 pid=5098
INFO: Freed in __kfree_skb+0x31/0x80 age=0 cpu=1 pid=4440
INFO: Slab 0xc16cc140 objects=16 used=1 fp=0xf658ae00 flags=0x400000c3
INFO: Object 0xf658ae00 @offset=3584 fp=0xf658af00

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-07-23 15:30:52 -07:00
..
82571.c e1000e: cleanup several stats issues 2008-04-25 02:07:11 -04:00
defines.h e1000e: Add support for BM PHYs on ICH9 2008-05-06 12:04:14 -04:00
e1000.h e1000e: make ioport free 2008-06-28 10:23:31 -04:00
es2lan.c e1000e: Fix HW Error on es2lan, ARP capture issue by BMC 2008-04-25 02:07:12 -04:00
ethtool.c e1000e: don't return half-read eeprom on error 2008-05-06 12:38:02 -04:00
hw.h e1000e: Add support for BM PHYs on ICH9 2008-05-06 12:04:14 -04:00
ich8lan.c e1000e: Add support for BM PHYs on ICH9 2008-05-06 12:04:14 -04:00
lib.c e1000e: rename a few functions 2008-04-16 20:41:37 -04:00
Makefile e1000e: reformat comment blocks, cosmetic changes only 2008-03-28 22:14:56 -04:00
netdev.c e1000e: fix e1000_netpoll(), remove extraneous e1000_clean_tx_irq() call 2008-07-23 15:30:52 -07:00
param.c e1000e: reformat comment blocks, cosmetic changes only 2008-03-28 22:14:56 -04:00
phy.c e1000e: Add support for BM PHYs on ICH9 2008-05-06 12:04:14 -04:00