linux/sound/pci/pcxhr
Julia Lawall d6f35e3f0d ALSA: sound/pci/pcxhr/pcxhr.c: introduce missing kfree and pci_disable_device
Error handling code following a kzalloc should free the allocated data.
The error handling code is adjusted to call pci_disable_device(pci); as
well, as done later in the function

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,l;
position p1,p2;
expression *ptr != NULL;
@@

(
if ((x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...)) == NULL) S
|
x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
)
<... when != x
     when != if (...) { <+...x...+> }
x->f = E
...>
(
 return \(0\|<+...x...+>\|ptr\);
|
 return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
2008-11-15 19:07:29 +01:00
..
Makefile
pcxhr.c ALSA: sound/pci/pcxhr/pcxhr.c: introduce missing kfree and pci_disable_device 2008-11-15 19:07:29 +01:00
pcxhr.h
pcxhr_core.c ALSA: Kill snd_assert() in sound/pci/* 2008-08-13 11:46:38 +02:00
pcxhr_core.h IRQ: Maintain regs pointer globally rather than passing to IRQ handlers 2006-10-05 15:10:12 +01:00
pcxhr_hwdep.c ALSA: Kill snd_assert() in sound/pci/* 2008-08-13 11:46:38 +02:00
pcxhr_hwdep.h
pcxhr_mixer.c [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
pcxhr_mixer.h