q3k
/
linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
linux/drivers/staging/brcm80211/brcmsmac
History
Clemens Noss aacd531df9 staging: brcm80211: use correct pointer types in bcm_pktq_flush 
to clarify the intention:

On Sun, May 15, 2011 at 09:54:26PM +0200, Arend van Spriel wrote:
> On 05/15/2011 08:10 PM, Hauke Mehrtens wrote:
[...]
>> Why don't you use the correct pointer type here instead of casting then
>> around and the parameter names are meaningless too.
>>
>> static bool cb_del_ampdu_pkt(struct sk_buff *mpdu, struct
>> cb_del_ampdu_pars *ampdu_pars)
[...]
> Actually this is a generic callback mechanism in which an additional
> parameter can be passed, which can be of *any* type hence a void pointer
> seems justified here and a meaningless name is used. I do agree that the
> txi parameter will always be a struct sk_buff and should be indicated as
> such.

Reported-by: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: Clemens Noss <cnoss@gmx.de>
Acked-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
 		2011-05-17 13:31:30 -07:00
..
phy staging: brcm80211: remove definition of BCMFASTPATH macro 2011-05-11 13:58:21 -07:00
Makefile staging: brcm80211: fix makefiles for building drivers in kernel 2011-05-17 12:03:52 -07:00
aiutils.c staging: brcm80211: cleanup functions in nvram.c 2011-05-17 12:03:52 -07:00
aiutils.h staging: brcm80211: remove socitype member for struct si_pub definition 2011-05-03 12:42:43 -07:00
bcmotp.c staging: brcm80211: move files only used by brcmsmac into appropriate dir 2011-05-10 11:07:13 -07:00
bcmsrom.c staging: brcm80211: move utility functions into new module 2011-05-11 13:58:20 -07:00
bcmsrom_tbl.h staging: brcm80211: move files only used by brcmsmac into appropriate dir 2011-05-10 11:07:13 -07:00
d11.h staging: brcm80211: remove dependency between aiutils and siutils sources 2011-05-03 12:42:41 -07:00
hnddma.c staging: brcm80211: got rid of #ifdef __mips__ by new dma_spin_for_len() 2011-05-17 12:03:50 -07:00
nicpci.c staging: brcm80211: move functions only used by brcmsmac out of utils 2011-05-10 11:07:18 -07:00
nvram.c staging: brcm80211: cleanup functions in nvram.c 2011-05-17 12:03:52 -07:00
wl_dbg.h staging: brcm80211: got rid of WL_FFPLD message log macro 2011-05-03 12:42:48 -07:00
wl_export.h staging: brcm80211: implement flush driver callback for mac80211 2011-05-03 12:42:38 -07:00
wl_mac80211.c staging: brcm80211: removed counter related struct wl_cnt 2011-05-17 12:12:30 -07:00
wl_mac80211.h staging: brcm80211: removed unused struct net_device_stats related code 2011-05-17 12:12:27 -07:00
wl_ucode.h
…
wl_ucode_loader.c
…
wlc_alloc.c staging: brcm80211: removed counter related struct wl_cnt 2011-05-17 12:12:30 -07:00
wlc_alloc.h staging: brcm80211: removed function wlc_calloc() 2011-05-03 12:42:48 -07:00
wlc_ampdu.c staging: brcm80211: use correct pointer types in bcm_pktq_flush 2011-05-17 13:31:30 -07:00
wlc_ampdu.h staging: brcm80211: cleanup unnecessary functions from wlc_ampdu.c 2011-05-11 13:58:21 -07:00
wlc_antsel.c staging: brcm80211: remove definition of BCMFASTPATH macro 2011-05-11 13:58:21 -07:00
wlc_antsel.h
…
wlc_bmac.c staging: brcm80211: removed counter related struct wl_cnt 2011-05-17 12:12:30 -07:00
wlc_bmac.h staging: brcm80211: remove unused functions and prototypes 2011-05-17 12:03:50 -07:00
wlc_bsscfg.h staging: brcm80211: local used function made static 2011-05-10 11:12:21 -07:00
wlc_cfg.h
…
wlc_channel.c staging: brcm80211: fix checkpatch issue in wlc_channel.c 2011-05-17 12:12:40 -07:00
wlc_channel.h
…
wlc_key.h staging: brcm80211: replace error codes part 2 2011-05-03 12:42:34 -07:00
wlc_main.c staging: brcm80211: fix cast to pointer from integer 2011-05-17 13:31:30 -07:00
wlc_main.h staging: brcm80211: remove unnecessary functions from wlc_main.c 2011-05-17 12:03:50 -07:00
wlc_phy_shim.c staging: brcm80211: remove dependency between aiutils and siutils sources 2011-05-03 12:42:41 -07:00
wlc_phy_shim.h
…
wlc_pmu.c staging: brcm80211: move functions only used by brcmsmac out of utils 2011-05-10 11:07:18 -07:00
wlc_pmu.h staging: brcm80211: remove dependency between aiutils and siutils sources 2011-05-03 12:42:41 -07:00
wlc_pub.h staging: brcm80211: remove unused functions and prototypes 2011-05-17 12:03:50 -07:00
wlc_rate.c staging: brcm80211: remove definition of BCMFASTPATH macro 2011-05-11 13:58:21 -07:00
wlc_rate.h staging: brcm80211: honour basic rate configuration from mac80211 2011-05-03 12:42:32 -07:00
wlc_scb.h staging: brcm80211: wlc_aggregatable function prototype moved 2011-05-10 11:12:22 -07:00
wlc_stf.c staging: brcm80211: move functions only used by brcmsmac out of utils 2011-05-10 11:07:18 -07:00
wlc_stf.h
…
wlc_types.h
…