3ee7451a02
map_destroy dereferences its argument. The call is furthermore only reachable when this argument is NULL. Thus the call is dropped. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression *x; @@ *if (x == NULL) { ... * map_destroy(x); ... return ...; } // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
121 lines
2.8 KiB
C
121 lines
2.8 KiB
C
/*
|
|
* ts5500_flash.c -- MTD map driver for Technology Systems TS-5500 board
|
|
*
|
|
* Copyright (C) 2004 Sean Young <sean@mess.org>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
|
|
*
|
|
* Note:
|
|
* - In order for detection to work, jumper 3 must be set.
|
|
* - Drive A and B use the resident flash disk (RFD) flash translation layer.
|
|
* - If you have created your own jffs file system and the bios overwrites
|
|
* it during boot, try disabling Drive A: and B: in the boot order.
|
|
*/
|
|
|
|
#include <linux/init.h>
|
|
#include <linux/module.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/mtd/map.h>
|
|
#include <linux/mtd/mtd.h>
|
|
#include <linux/mtd/partitions.h>
|
|
#include <linux/types.h>
|
|
|
|
|
|
#define WINDOW_ADDR 0x09400000
|
|
#define WINDOW_SIZE 0x00200000
|
|
|
|
static struct map_info ts5500_map = {
|
|
.name = "TS-5500 Flash",
|
|
.size = WINDOW_SIZE,
|
|
.bankwidth = 1,
|
|
.phys = WINDOW_ADDR
|
|
};
|
|
|
|
static struct mtd_partition ts5500_partitions[] = {
|
|
{
|
|
.name = "Drive A",
|
|
.offset = 0,
|
|
.size = 0x0e0000
|
|
},
|
|
{
|
|
.name = "BIOS",
|
|
.offset = 0x0e0000,
|
|
.size = 0x020000,
|
|
},
|
|
{
|
|
.name = "Drive B",
|
|
.offset = 0x100000,
|
|
.size = 0x100000
|
|
}
|
|
};
|
|
|
|
#define NUM_PARTITIONS ARRAY_SIZE(ts5500_partitions)
|
|
|
|
static struct mtd_info *mymtd;
|
|
|
|
static int __init init_ts5500_map(void)
|
|
{
|
|
int rc = 0;
|
|
|
|
ts5500_map.virt = ioremap_nocache(ts5500_map.phys, ts5500_map.size);
|
|
|
|
if (!ts5500_map.virt) {
|
|
printk(KERN_ERR "Failed to ioremap_nocache\n");
|
|
rc = -EIO;
|
|
goto err2;
|
|
}
|
|
|
|
simple_map_init(&ts5500_map);
|
|
|
|
mymtd = do_map_probe("jedec_probe", &ts5500_map);
|
|
if (!mymtd)
|
|
mymtd = do_map_probe("map_rom", &ts5500_map);
|
|
|
|
if (!mymtd) {
|
|
rc = -ENXIO;
|
|
goto err1;
|
|
}
|
|
|
|
mymtd->owner = THIS_MODULE;
|
|
add_mtd_partitions(mymtd, ts5500_partitions, NUM_PARTITIONS);
|
|
|
|
return 0;
|
|
|
|
err1:
|
|
iounmap(ts5500_map.virt);
|
|
err2:
|
|
return rc;
|
|
}
|
|
|
|
static void __exit cleanup_ts5500_map(void)
|
|
{
|
|
if (mymtd) {
|
|
del_mtd_partitions(mymtd);
|
|
map_destroy(mymtd);
|
|
}
|
|
|
|
if (ts5500_map.virt) {
|
|
iounmap(ts5500_map.virt);
|
|
ts5500_map.virt = NULL;
|
|
}
|
|
}
|
|
|
|
module_init(init_ts5500_map);
|
|
module_exit(cleanup_ts5500_map);
|
|
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_AUTHOR("Sean Young <sean@mess.org>");
|
|
MODULE_DESCRIPTION("MTD map driver for Techology Systems TS-5500 board");
|
|
|