q3k/linux
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
linux/drivers/scsi
History
FUJITA Tomonori ecb554a846 block: fix sg SG_DXFER_TO_FROM_DEV regression 
I overlooked SG_DXFER_TO_FROM_DEV support when I converted sg to use
the block layer mapping API (2.6.28).

Douglas Gilbert explained SG_DXFER_TO_FROM_DEV:

http://www.spinics.net/lists/linux-scsi/msg37135.html

=
The semantics of SG_DXFER_TO_FROM_DEV were:
   - copy user space buffer to kernel (LLD) buffer
   - do SCSI command which is assumed to be of the DATA_IN
     (data from device) variety. This would overwrite
     some or all of the kernel buffer
   - copy kernel (LLD) buffer back to the user space.

The idea was to detect short reads by filling the original
user space buffer with some marker bytes ("0xec" it would
seem in this report). The "resid" value is a better way
of detecting short reads but that was only added this century
and requires co-operation from the LLD.
=

This patch changes the block layer mapping API to support this
semantics. This simply adds another field to struct rq_map_data and
enables __bio_copy_iov() to copy data from user space even with READ
requests.

It's better to add the flags field and kills null_mapped and the new
from_user fields in struct rq_map_data but that approach makes it
difficult to send this patch to stable trees because st and osst
drivers use struct rq_map_data (they were converted to use the block
layer in 2.6.29 and 2.6.30). Well, I should clean up the block layer
mapping API.

zhou sf reported this regiression and tested this patch:

http://www.spinics.net/lists/linux-scsi/msg37128.html
http://www.spinics.net/lists/linux-scsi/msg37168.html

Reported-by: zhou sf <sxzzsf@gmail.com>
Tested-by: zhou sf <sxzzsf@gmail.com>
Cc: stable@kernel.org
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
2009-07-10 20:31:53 +02:00
..
aacraid
aic7xxx [SCSI] aic79xx: make driver respect nvram for IU and QAS settings 2009-06-15 10:09:35 -05:00
aic7xxx_old
aic94xx
arcmsr
arm
bnx2i cnic: add NETDEV_1000 and NETDEVICES to Kconfig select 2009-06-21 11:02:59 -05:00
cxgb3i Merge git://git.kernel.org/pub/scm/linux/kernel/git/sam/kbuild-fixes 2009-07-04 09:46:01 -07:00
device_handler [SCSI] scsi_dh_rdac: Retry for NOT_READY(02/04/01) in rdac device handler 2009-05-20 17:21:14 -05:00
dpt trivial: fix typo milisecond/millisecond for documentation and source comments. 2009-06-12 18:01:46 +02:00
fcoe libfcoe: Add runtime debugging with module param debug_logging 2009-06-21 11:07:06 -05:00
fnic [SCSI] fnic: use DMA_BIT_MASK(nn) instead of deprecated DMA_nnBIT_MASK 2009-06-25 11:08:53 -05:00
ibmvscsi [SCSI] ibmvscsi: Fix module load hang 2009-06-25 11:06:41 -05:00
libfc libfc: Add runtime debugging with debug_logging module parameter 2009-06-21 11:07:08 -05:00
libsas block: set rq->resid_len to blk_rq_bytes() on issue 2009-05-19 11:36:08 +02:00
lpfc Merge git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6 2009-06-17 09:50:44 -07:00
megaraid trivial: typo (en|dis|avail|remove)bale -> (en|dis|avail|remove)able 2009-06-12 18:01:45 +02:00
mpt2sas [SCSI] Merge branch 'linus' 2009-06-12 10:02:03 -05:00
mvsas [SCSI] mvsas: remove all the casts from void * or to void * 2009-05-23 15:44:13 -05:00
osd [SCSI] Merge branch 'linus' 2009-06-12 10:02:03 -05:00
pcmcia [SCSI] nsp_cs: time_out reaches -1 2009-06-15 10:09:31 -05:00
qla2xxx qla2xxx: Update version number to 8.03.01-k4. 2009-06-21 10:52:44 -05:00
qla4xxx
sym53c8xx_2 sym53c8xx: ratelimit parity errors 2009-06-21 11:12:17 -05:00
.gitignore
3w-9xxx.c [SCSI] 3w-9xxx: scsi_dma_unmap fix 2009-05-15 12:23:32 -04:00
3w-9xxx.h
3w-xxxx.c [SCSI] 3w-xxxx: scsi_dma_unmap fix 2009-05-15 12:24:59 -04:00
3w-xxxx.h [SCSI] 3w-xxxx: scsi_dma_unmap fix 2009-05-15 12:24:59 -04:00
53c700.c
53c700.h
53c700.scr
53c700_d.h_shipped
a100u2w.c
a100u2w.h
a2091.c
a2091.h
a3000.c
a3000.h
a4000t.c scsi: a4000 - Correct driver unregistration in case of failure 2009-04-22 20:39:06 +02:00
advansys.c
aha152x.c
aha152x.h
aha1542.c
aha1542.h
aha1740.c scsi: remove driver_data direct access of struct device 2009-06-15 21:30:27 -07:00
aha1740.h
aic7xxx_old.c
atari_NCR5380.c Remove multiple KERN_ prefixes from printk formats 2009-07-08 10:30:03 -07:00
atari_scsi.c
atari_scsi.h
atp870u.c
atp870u.h
BusLogic.c
BusLogic.h
bvme6000_scsi.c
ch.c
constants.c
dc395x.c
dc395x.h
dmx3191d.c
dpt_i2o.c
dpti.h
dtc.c
dtc.h
eata.c block: convert to pos and nr_sectors accessors 2009-05-11 09:50:54 +02:00
eata_generic.h
eata_pio.c
eata_pio.h
esp_scsi.c
esp_scsi.h
fd_mcs.c
fdomain.c
fdomain.h
FlashPoint.c
g_NCR5380.c
g_NCR5380.h
g_NCR5380_mmio.c
gdth.c
gdth.h
gdth_ioctl.h
gdth_proc.c [SCSI] gdth: fix overlapping snprintf users 2009-06-09 10:31:46 -05:00
gdth_proc.h
gvp11.c
gvp11.h
hosts.c fix race that can give duplicate host number 2009-06-21 10:52:42 -05:00
hptiop.c
hptiop.h
ibmmca.c
imm.c
imm.h
in2000.c
in2000.h
initio.c
initio.h
ipr.c ipr: differentiate pci-x and pci-e based adapters 2009-06-21 10:52:47 -05:00
ipr.h ipr: differentiate pci-x and pci-e based adapters 2009-06-21 10:52:47 -05:00
ips.c
ips.h
iscsi_tcp.c iscsi_tcp: propogate EAGAIN from sendpage to libiscsi 2009-06-21 10:52:40 -05:00
iscsi_tcp.h
jazz_esp.c
Kconfig explain the hidden scsi_wait_scan Kconfig variable 2009-06-21 11:10:41 -05:00
lasi700.c
libiscsi.c libiscsi: add conn and scsi eh log debug flags 2009-06-21 10:52:41 -05:00
libiscsi_tcp.c libiscsi: don't run scsi eh if iscsi task is making progress 2009-06-21 10:52:39 -05:00
libsrp.c scsi: remove driver_data direct access of struct device 2009-06-15 21:30:27 -07:00
mac53c94.c Remove multiple KERN_ prefixes from printk formats 2009-07-08 10:30:03 -07:00
mac53c94.h
mac_esp.c
mac_scsi.c
mac_scsi.h
Makefile [SCSI] bnx2i: Add bnx2i iSCSI driver. 2009-06-09 10:22:45 -05:00
megaraid.c
megaraid.h trivial: typo (en|dis|avail|remove)bale -> (en|dis|avail|remove)able 2009-06-12 18:01:45 +02:00
mesh.c
mesh.h
mvme16x_scsi.c
mvme147.c
mvme147.h
ncr53c8xx.c [SCSI] ncr53c8xx: div reaches -1 2009-06-15 10:09:30 -05:00
ncr53c8xx.h
NCR53c406a.c
NCR5380.c
NCR5380.h
NCR_D700.c [SCSI] NCR_D700: fix IRQ handler return type 2009-05-23 15:44:09 -05:00
NCR_D700.h
NCR_Q720.c
NCR_Q720.h
nsp32.c
nsp32.h
nsp32_debug.c
nsp32_io.h
osst.c
osst.h
osst_detect.h
osst_options.h
pas16.c
pas16.h
ppa.c
ppa.h
ps3rom.c ps3rom: Use ps3_system_bus_[gs]et_drvdata() instead of direct access 2009-06-16 14:15:46 +10:00
qla1280.c [SCSI] qla1280: error recovery rewrite 2009-05-20 17:21:13 -05:00
qla1280.h [SCSI] qla1280: error recovery rewrite 2009-05-20 17:21:13 -05:00
qlogicfas.c
qlogicfas408.c
qlogicfas408.h
qlogicpti.c
qlogicpti.h
raid_class.c
script_asm.pl
scsi.c [SCSI] fix documentation for two functions 2009-06-08 12:23:35 -05:00
scsi.h
scsi_debug.c scsi_debug: Add support for physical block exponent and alignment 2009-06-21 11:03:54 -05:00
scsi_devinfo.c enhance device info matching for multiple tables 2009-06-21 10:52:45 -05:00
scsi_error.c [SCSI] fix up scsi_eh_lock_door() 2009-06-08 12:47:40 -05:00
scsi_ioctl.c
scsi_lib.c sd, sr: fix Driver 'sd' needs updating message 2009-06-21 12:01:27 -05:00
scsi_lib_dma.c
scsi_logging.h
scsi_module.c
scsi_netlink.c
scsi_priv.h sd, sr: fix Driver 'sd' needs updating message 2009-06-21 12:01:27 -05:00
scsi_proc.c
scsi_sas_internal.h
scsi_scan.c [SCSI] Increase default timeout for INQUIRY 2009-05-20 17:21:13 -05:00
scsi_sysctl.c
scsi_sysfs.c sd, sr: fix Driver 'sd' needs updating message 2009-06-21 12:01:27 -05:00
scsi_tgt_if.c
scsi_tgt_lib.c block: cleanup rq->data_len usages 2009-05-11 09:50:55 +02:00
scsi_tgt_priv.h
scsi_transport_api.h
scsi_transport_fc.c [SCSI] FC transport: Locking fix for common-code FC pass-through patch 2009-06-26 10:29:48 -05:00
scsi_transport_fc_internal.h
scsi_transport_iscsi.c scsi_transport_iscsi: return -EOVERFLOW for Too many iscsi targets 2009-06-21 11:58:11 -05:00
scsi_transport_sas.c scsi_transport_sas: needs to call blk_end_request_all for SMP requests 2009-06-21 10:52:41 -05:00
scsi_transport_spi.c scsi_transport_spi: Blacklist Ultrium-3 tape for IU transfers 2009-06-21 10:52:46 -05:00
scsi_transport_srp.c
scsi_transport_srp_internal.h
scsi_typedefs.h
scsi_wait_scan.c
scsicam.c
sd.c sd, sr: fix Driver 'sd' needs updating message 2009-06-21 12:01:27 -05:00
sd.h sd: Physical block size and alignment support 2009-06-21 10:52:37 -05:00
sd_dif.c block: convert to pos and nr_sectors accessors 2009-05-11 09:50:54 +02:00
ses.c
sg.c block: fix sg SG_DXFER_TO_FROM_DEV regression 2009-07-10 20:31:53 +02:00
sgiwd93.c
sim710.c
sni_53c710.c
sr.c sd, sr: fix Driver 'sd' needs updating message 2009-06-21 12:01:27 -05:00
sr.h
sr_ioctl.c [SCSI] sr: report more accurate drive status after closing the tray. 2009-04-27 09:32:30 -05:00
sr_vendor.c
st.c [SCSI] Merge branch 'linus' 2009-06-12 10:02:03 -05:00
st.h
st_options.h
stex.c
sun3_NCR5380.c Remove multiple KERN_ prefixes from printk formats 2009-07-08 10:30:03 -07:00
sun3_scsi.c
sun3_scsi.h
sun3_scsi_vme.c
sun3x_esp.c
sun_esp.c
sym53c416.c
sym53c416.h
t128.c
t128.h
tmscsim.c
tmscsim.h
u14-34f.c block: convert to pos and nr_sectors accessors 2009-05-11 09:50:54 +02:00
ultrastor.c
ultrastor.h
wd33c93.c
wd33c93.h
wd7000.c
zalon.c [SCSI] zalon: fix oops on attach failure 2009-06-25 11:37:23 -05:00
zorro7xx.c