Chris Wilson c501ae7f33 drm/i915: Only clear the GPU domains upon a successful finish ... By clearing the GPU read domains before waiting upon the buffer, we run the risk of the wait being interrupted and the domains prematurely cleared. The next time we attempt to wait upon the buffer (after userspace handles the signal), we believe that the buffer is idle and so skip the wait. There are a number of bugs across all generations which show signs of an overly haste reuse of active buffers. Such as: https://bugs.freedesktop.org/show_bug.cgi?id=29046 https://bugs.freedesktop.org/show_bug.cgi?id=35863 https://bugs.freedesktop.org/show_bug.cgi?id=38952 https://bugs.freedesktop.org/show_bug.cgi?id=40282 https://bugs.freedesktop.org/show_bug.cgi?id=41098 https://bugs.freedesktop.org/show_bug.cgi?id=41102 https://bugs.freedesktop.org/show_bug.cgi?id=41284 https://bugs.freedesktop.org/show_bug.cgi?id=42141 A couple of those pre-date i915_gem_object_finish_gpu(), so may be unrelated (such as a wild write from a userspace command buffer), but this does look like a convincing cause for most of those bugs. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: stable@kernel.org Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Reviewed-by: Eugeni Dodonov <eugeni.dodonov@intel.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>		2012-03-01 21:36:13 +01:00
..
dvo.h
dvo_ch7xxx.c	Drivers: i915: Fix all space related issues.	2011-09-19 18:01:47 -07:00
dvo_ch7017.c	Drivers: i915: Fix all space related issues.	2011-09-19 18:01:47 -07:00
dvo_ivch.c	Drivers: i915: Fix all space related issues.	2011-09-19 18:01:47 -07:00
dvo_sil164.c	Drivers: i915: Fix all space related issues.	2011-09-19 18:01:47 -07:00
dvo_tfp410.c	Drivers: i915: Fix all space related issues.	2011-09-19 18:01:47 -07:00
i915_debugfs.c	drm/i915: Record the position of the request upon error	2012-02-15 14:27:18 +01:00
i915_dma.c	Merge remote-tracking branch 'airlied/drm-next' into for-airlied	2012-02-23 14:56:11 +01:00
i915_drv.c	drm/i915: check gtfifodbg after possibly failed writes	2012-02-12 00:21:41 +01:00
i915_drv.h	drm/i915: i2c: unconditionally set up gpio fallback	2012-02-29 20:53:36 +01:00
i915_gem.c	drm/i915: Only clear the GPU domains upon a successful finish	2012-03-01 21:36:13 +01:00
i915_gem_debug.c	drm/i915: drop KM_USER0 argument to k(un)map_atomic	2011-10-20 15:26:37 -07:00
i915_gem_evict.c	drm/i915: No need to search again after retiring requests	2012-02-27 17:37:13 +01:00
i915_gem_execbuffer.c	Merge tag 'drm-intel-next-2012-02-07' of git://people.freedesktop.org/~danvet/drm-intel into drm-core-next	2012-02-14 14:16:00 +00:00
i915_gem_gtt.c	drm/i915: ppgtt binding/unbinding support	2012-02-09 21:25:23 +01:00
i915_gem_tiling.c	drm/i915: swizzling support for snb/ivb	2012-02-08 23:16:24 +01:00
i915_ioc32.c
i915_irq.c	drm/i915: Record the position of the request upon error	2012-02-15 14:27:18 +01:00
i915_reg.h	drm/i915: add missing SDVO bits for interlaced modes on ILK	2012-02-14 20:32:29 +01:00
i915_suspend.c	drm/i915: Re-enable gen7 RC6 and GPU turbo after resume.	2012-01-24 13:25:10 -08:00
i915_trace.h	Drivers: i915: Fix all space related issues.	2011-09-19 18:01:47 -07:00
i915_trace_points.c
intel_acpi.c	drm/i915: Silence _DSM errors	2012-01-16 21:08:19 +01:00
intel_bios.c	drm/i915/bios: Downgrade the "signature missing" DRM_ERROR to debug	2012-02-27 11:32:10 +01:00
intel_bios.h	drm/i915: VBT Parser cleanup for eDP block	2012-01-13 08:37:44 -08:00
intel_crt.c	drm/i915: don't allow interlaced pipeconf on gen2	2012-02-10 17:28:45 +01:00
intel_display.c	drm/i915: Fixes distorted external screen image on HP 2730p	2012-02-27 11:12:33 +01:00
intel_dp.c	drm/i915: use the new hdmi_force_audio enum more	2012-02-27 17:45:36 +01:00
intel_drv.h	drm/i915: Separate fence pin counting from normal bind pin counting	2012-01-29 18:23:37 +01:00
intel_dvo.c	drm/i915: fixup interlaced vertical timings confusion, part 1	2012-02-10 17:24:06 +01:00
intel_fb.c	drm: do not set fb_info->pixmap fields	2012-02-09 10:34:43 +00:00
intel_hdmi.c	drm/i915: add a "force-dvi" HDMI audio mode	2012-02-14 10:03:18 +01:00
intel_i2c.c	drm/i915: reenable gmbus on gen3+ again	2012-02-29 20:54:14 +01:00
intel_lvds.c	drm/i915: Ignore LVDS on hp t5745 and hp st5747 thin client	2012-02-27 11:12:38 +01:00
intel_modes.c	Merge remote-tracking branch 'airlied/drm-next' into for-airlied	2012-02-23 14:56:11 +01:00
intel_opregion.c	Drivers: i915: Fix all space related issues.	2011-09-19 18:01:47 -07:00
intel_overlay.c	Revert "drivers/gpu/drm/i915/intel_overlay.c needs seq_file.h"	2012-02-16 10:31:23 +01:00
intel_panel.c	drm/i915: fixup interlaced vertical timings confusion, part 1	2012-02-10 17:24:06 +01:00
intel_ringbuffer.c	drm/i915: Record the tail at each request and use it to estimate the head	2012-02-15 14:26:03 +01:00
intel_ringbuffer.h	drm/i915: Record the tail at each request and use it to estimate the head	2012-02-15 14:26:03 +01:00
intel_sdvo.c	drm/i915: use the new hdmi_force_audio enum more	2012-02-27 17:45:36 +01:00
intel_sdvo_regs.h	misc latin1 to utf8 conversions	2012-01-02 13:04:55 +01:00
intel_sprite.c	Merge tag 'drm-intel-next-2012-02-07' of git://people.freedesktop.org/~danvet/drm-intel into drm-core-next	2012-02-14 14:16:00 +00:00
intel_tv.c	drm/i915: fixup interlaced vertical timings confusion, part 1	2012-02-10 17:24:06 +01:00
Makefile	drm/i915: kill i915_mem.c	2012-01-17 20:01:01 +01:00