linux/drivers/platform/x86
Roland Dreier dbee8a0aff x86: remove 32-bit versions of readq()/writeq()
The presense of a writeq() implementation on 32-bit x86 that splits the
64-bit write into two 32-bit writes turns out to break the mpt2sas driver
(and in general is risky for drivers as was discussed in
<http://lkml.kernel.org/r/adaab6c1h7c.fsf@cisco.com>).  To fix this,
revert 2c5643b1c5 ("x86: provide readq()/writeq() on 32-bit too") and
follow-on cleanups.

This unfortunately leads to pushing non-atomic definitions of readq() and
write() to various x86-only drivers that in the meantime started using the
definitions in the x86 version of <asm/io.h>.  However as discussed
exhaustively, this is actually the right thing to do, because the right
way to split a 64-bit transaction is hardware dependent and therefore
belongs in the hardware driver (eg mpt2sas needs a spinlock to make sure
no other accesses occur in between the two halves of the access).

Build tested on 32- and 64-bit x86 allmodconfig.

Link: http://lkml.kernel.org/r/x86-32-writeq-is-broken@mdm.bga.com
Acked-by: Hitoshi Mitake <h.mitake@gmail.com>
Cc: Kashyap Desai <Kashyap.Desai@lsi.com>
Cc: Len Brown <lenb@kernel.org>
Cc: Ravi Anand <ravi.anand@qlogic.com>
Cc: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Jason Uhlenkott <juhlenko@akamai.com>
Acked-by: James Bottomley <James.Bottomley@parallels.com>
Acked-by: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2011-05-25 08:39:44 -07:00
..
acer-wmi.c
acerhdf.c
asus-laptop.c
asus-nb-wmi.c
asus-wmi.c
asus-wmi.h
asus_acpi.c
classmate-laptop.c
compal-laptop.c
dell-laptop.c
dell-wmi-aio.c
dell-wmi.c
eeepc-laptop.c
eeepc-wmi.c
fujitsu-laptop.c
hdaps.c
hp-wmi.c
hp_accel.c
ibm_rtl.c x86: remove 32-bit versions of readq()/writeq() 2011-05-25 08:39:44 -07:00
ideapad-laptop.c
intel_ips.c x86: remove 32-bit versions of readq()/writeq() 2011-05-25 08:39:44 -07:00
intel_ips.h
intel_menlow.c
intel_mid_powerbtn.c
intel_mid_thermal.c
intel_pmic_gpio.c
intel_rar_register.c
intel_scu_ipc.c
intel_scu_ipcutil.c
Kconfig Merge branch 'drm-core-next' of git://git.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6 2011-05-24 12:06:40 -07:00
Makefile
msi-laptop.c
msi-wmi.c
mxm-wmi.c
panasonic-laptop.c
samsung-laptop.c
sony-laptop.c
tc1100-wmi.c
thinkpad_acpi.c
topstar-laptop.c
toshiba_acpi.c
toshiba_bluetooth.c
wmi.c
xo1-rfkill.c
xo15-ebook.c