linux/drivers/media/dvb
Trent Piepho d9e54324d0 V4L/DVB (5374): Or51132: refactor i2c code, improve error resilience
The code the i2c transactions was leftover from the old V4L-based ATSC
driver.  It did too little with too much code.  It is re-written to
remove unnecessary parameters and be more efficient.  A demod register
can now be read with one function call, instead of repeating a dozen line
block of code each time.

There were msleep()'s, which appear to be unnecessary, spread around all
the I2C transactions.  These have been removed.  Reading SNR used to take
about 130 ms, now it's down to 1.8 ms.

Reads from the demodulator's registers do not return correct results
sometimes.  Adding or removing the delays in the I2C transactions did not
appear to effect the probability of failure.  If anything, the
transactions without delays were less likely to fail, but since far more
transactions could be made per second the number of failures per hour was
greater.

To increase reliability, the SNR and get_params functions will now retry
once if they get bad data back.  This appears to have reduced the
probability of failure to effectively zero.
Some error messages are cleaned up or given KERN_* levels when they were
missing.  

or51132_setmode() wasn't returning correct error codes, which is fixed as
well.

CC: Rusty Scott <rustys@ieee.org>
Signed-off-by: Trent Piepho <xyzzy@speakeasy.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
2007-04-27 15:44:09 -03:00
..
b2c2 V4L/DVB (5363): Dvb: Remove lgh06xf driver 2007-04-27 15:44:05 -03:00
bt8xx V4L/DVB (5363): Dvb: Remove lgh06xf driver 2007-04-27 15:44:05 -03:00
cinergyT2 V4L/DVB (5121): Proper vendor/device ID for the CinergyT2 input device 2007-02-21 13:34:48 -02:00
dvb-core [SK_BUFF]: Introduce skb_copy_from_linear_data{_offset} 2007-04-25 22:28:23 -07:00
dvb-usb V4L/DVB (5373): [PATCH] Hauppauge Nova-T endianess problem on powerpc 2007-04-27 15:44:09 -03:00
frontends V4L/DVB (5374): Or51132: refactor i2c code, improve error resilience 2007-04-27 15:44:09 -03:00
pluto2 V4L/DVB (5361): Dvb-pll: Fix Kconfig files and allow dvb-pll to be optional 2007-04-27 15:44:01 -03:00
ttpci V4L/DVB (5361): Dvb-pll: Fix Kconfig files and allow dvb-pll to be optional 2007-04-27 15:44:01 -03:00
ttusb-budget V4L/DVB (5361): Dvb-pll: Fix Kconfig files and allow dvb-pll to be optional 2007-04-27 15:44:01 -03:00
ttusb-dec V4L/DVB (5164): Compat: Handle input_register_device() change and some others 2007-02-21 13:35:10 -02:00
Kconfig V4L/DVB (4037): Make the bridge devices that depend on I2C dependant on I2C 2006-05-23 15:56:38 -03:00
Makefile [PATCH] dvb: add Pluto2 driver 2005-07-07 18:23:55 -07:00