linux/sound
Alexey Dobriyan 99b7623380 proc 2/2: remove struct proc_dir_entry::owner
Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy
as correctly noted at bug #12454. Someone can lookup entry with NULL
->owner, thus not pinning enything, and release it later resulting
in module refcount underflow.

We can keep ->owner and supply it at registration time like ->proc_fops
and ->data.

But this leaves ->owner as easy-manipulative field (just one C assignment)
and somebody will forget to unpin previous/pin current module when
switching ->owner. ->proc_fops is declared as "const" which should give
some thoughts.

->read_proc/->write_proc were just fixed to not require ->owner for
protection.

rmmod'ed directories will be empty and return "." and ".." -- no harm.
And directories with tricky enough readdir and lookup shouldn't be modular.
We definitely don't want such modular code.

Removing ->owner will also make PDE smaller.

So, let's nuke it.

Kudos to Jeff Layton for reminding about this, let's say, oversight.

http://bugzilla.kernel.org/show_bug.cgi?id=12454

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
2009-03-31 01:14:44 +04:00
..
aoa Merge branch 'topic/aoa' into for-linus 2009-03-24 00:35:51 +01:00
arm Merge branch 'origin' into devel 2009-03-28 20:29:51 +00:00
atmel
core proc 2/2: remove struct proc_dir_entry::owner 2009-03-31 01:14:44 +04:00
drivers Merge branch 'core/percpu' into percpu-cpumask-x86-for-linus-2 2009-03-27 17:28:43 +01:00
i2c V4L/DVB (10771): tea575x-tuner: convert it to V4L2 API 2009-03-30 12:43:02 -03:00
isa Merge branch 'topic/sscape-fix' into for-linus 2009-03-24 00:36:21 +01:00
mips Merge branch 'topic/misc' into for-linus 2009-03-24 00:35:50 +01:00
oss Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/geert/linux-m68k 2009-03-26 16:15:31 -07:00
parisc
pci V4L/DVB (10771): tea575x-tuner: convert it to V4L2 API 2009-03-30 12:43:02 -03:00
pcmcia Merge branch 'topic/misc' into for-linus 2009-03-24 00:35:50 +01:00
ppc Merge branch 'topic/powermac' into for-linus 2009-03-24 00:36:20 +01:00
sh Merge git://git.kernel.org/pub/scm/linux/kernel/git/lethal/sh-2.6 2009-03-26 11:11:23 -07:00
soc Merge branch 'origin' into devel 2009-03-28 20:29:51 +00:00
sparc Merge branch 'topic/misc' into for-linus 2009-03-24 00:35:50 +01:00
spi
synth Merge branch 'topic/misc' into for-linus 2009-03-24 00:35:50 +01:00
usb Merge branch 'topic/usb-caiaq' into for-linus 2009-03-24 00:36:23 +01:00
ac97_bus.c
Kconfig
last.c
Makefile
sound_core.c
sound_firmware.c