linux/drivers/media
Andres Salomon bca5c2c550 ov7670: clean up ov7670_read semantics
Cortland Setlow pointed out a bug in ov7670.c where the result from
ov7670_read() was just being checked for !0, rather than <0.  This made me
realize that ov7670_read's semantics were rather confusing; it both fills
in 'value' with the result, and returns it.  This is goes against general
kernel convention; so rather than fixing callers, let's fix the function.

This makes ov7670_read return <0 in the case of an error, and 0 upon
success. Thus, code like:

res = ov7670_read(...);
if (!res)
	goto error;

..will work properly.

Signed-off-by: Cortland Setlow <csetlow@tower-research.com>
Signed-off-by: Andres Salomon <dilinger@debian.org>
Acked-by: Jonathan Corbet <corbet@lwn.net>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-12 14:33:41 -07:00
..
common V4L/DVB (8097): xc5000: check device hardware state to determine if firmware download is needed 2008-06-26 15:58:58 -03:00
dvb V4L/DVB (8096): au8522: prevent false-positive lock status 2008-06-26 15:58:58 -03:00
radio V4L/DVB (7582): proc: switch /proc/driver/radio-typhoon to seq_file interface 2008-04-24 14:09:40 -03:00
video ov7670: clean up ov7670_read semantics 2008-07-12 14:33:41 -07:00
Kconfig V4L/DVB (7898): Fix VIDEO_MEDIA Kconfig logic 2008-05-14 02:56:47 -03:00
Makefile V4L/DVB (7908): always enter drivers/media/video/ 2008-06-05 06:35:42 -03:00