linux/net/rxrpc
David S. Miller 51c739d1f4 [NET]: Fix incorrect sg_mark_end() calls.
This fixes scatterlist corruptions added by

	commit 68e3f5dd4d
	[CRYPTO] users: Fix up scatterlist conversion errors

The issue is that the code calls sg_mark_end() which clobbers the
sg_page() pointer of the final scatterlist entry.

The first part fo the fix makes skb_to_sgvec() do __sg_mark_end().

After considering all skb_to_sgvec() call sites the most correct
solution is to call __sg_mark_end() in skb_to_sgvec() since that is
what all of the callers would end up doing anyways.

I suspect this might have fixed some problems in virtio_net which is
the sole non-crypto user of skb_to_sgvec().

Other similar sg_mark_end() cases were converted over to
__sg_mark_end() as well.

Arguably sg_mark_end() is a poorly named function because it doesn't
just "mark", it clears out the page pointer as a side effect, which is
what led to these bugs in the first place.

The one remaining plain sg_mark_end() call is in scsi_alloc_sgtable()
and arguably it could be converted to __sg_mark_end() if only so that
we can delete this confusing interface from linux/scatterlist.h

Signed-off-by: David S. Miller <davem@davemloft.net>
2007-10-30 21:29:29 -07:00
..
af_rxrpc.c KEYS: Make request_key() and co fundamentally asynchronous 2007-10-17 08:42:57 -07:00
ar-accept.c [AF_RXRPC]: Add an interface to the AF_RXRPC module for the AFS filesystem to use 2007-04-26 15:50:17 -07:00
ar-ack.c [AF_RXRPC]: Sort out MTU handling. 2007-05-04 12:41:11 -07:00
ar-call.c [AF_RXRPC]: Make call state names available if CONFIG_PROC_FS=n 2007-05-22 16:14:24 -07:00
ar-connection.c net/* misc endianness annotations 2007-07-26 11:11:56 -07:00
ar-connevent.c [AF_RXRPC]: Add an interface to the AF_RXRPC module for the AFS filesystem to use 2007-04-26 15:50:17 -07:00
ar-error.c [AF_RXRPC]: Sort out MTU handling. 2007-05-04 12:41:11 -07:00
ar-input.c [RXRPC]: Fix pointers passed to bitops. 2007-04-26 20:20:21 -07:00
ar-internal.h [RXRPC]: Remove bogus atomic_* overrides. 2007-04-26 20:18:17 -07:00
ar-key.c KEYS: Make request_key() and co fundamentally asynchronous 2007-10-17 08:42:57 -07:00
ar-local.c [AF_RXRPC]: Add an interface to the AF_RXRPC module for the AFS filesystem to use 2007-04-26 15:50:17 -07:00
ar-output.c [AF_RXRPC]: Return the number of bytes buffered in rxrpc_send_data() 2007-06-18 23:30:41 -07:00
ar-peer.c AF_RXRPC: reduce debugging noise 2007-05-10 09:26:52 -07:00
ar-proc.c [NET]: Make all initialized struct seq_operations const. 2007-07-10 23:07:31 -07:00
ar-recvmsg.c [AF_RXRPC]: Add an interface to the AF_RXRPC module for the AFS filesystem to use 2007-04-26 15:50:17 -07:00
ar-security.c [AF_RXRPC]: Provide secure RxRPC sockets for use by userspace and kernel both 2007-04-26 15:48:28 -07:00
ar-skbuff.c [AF_RXRPC]: Add an interface to the AF_RXRPC module for the AFS filesystem to use 2007-04-26 15:50:17 -07:00
ar-transport.c Cleanup non-arch xtime uses, use get_seconds() or current_kernel_time(). 2007-07-25 10:09:20 -07:00
Kconfig [AF_RXRPC]: AF_RXRPC depends on IPv4 2007-05-22 16:13:49 -07:00
Makefile [AF_RXRPC]: Delete the old RxRPC code. 2007-04-26 15:55:48 -07:00
rxkad.c [NET]: Fix incorrect sg_mark_end() calls. 2007-10-30 21:29:29 -07:00