linux/arch/ppc64
Hugh Dickins 2fd4ef85e0 [PATCH] error path in setup_arg_pages() misses vm_unacct_memory()
Pavel Emelianov and Kirill Korotaev observe that fs and arch users of
security_vm_enough_memory tend to forget to vm_unacct_memory when a
failure occurs further down (typically in setup_arg_pages variants).

These are all users of insert_vm_struct, and that reservation will only
be unaccounted on exit if the vma is marked VM_ACCOUNT: which in some
cases it is (hidden inside VM_STACK_FLAGS) and in some cases it isn't.

So x86_64 32-bit and ppc64 vDSO ELFs have been leaking memory into
Committed_AS each time they're run.  But don't add VM_ACCOUNT to them,
it's inappropriate to reserve against the very unlikely case that gdb
be used to COW a vDSO page - we ought to do something about that in
do_wp_page, but there are yet other inconsistencies to be resolved.

The safe and economical way to fix this is to let insert_vm_struct do
the security_vm_enough_memory check when it finds VM_ACCOUNT is set.

And the MIPS irix_brk has been calling security_vm_enough_memory before
calling do_brk which repeats it, doubly accounting and so also leaking.
Remove that, and all the fs and arch calls to security_vm_enough_memory:
give it a less misleading name later on.

Signed-off-by: Hugh Dickins <hugh@veritas.com>
Signed-Off-By: Kirill Korotaev <dev@sw.ru>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2005-09-14 11:18:13 -07:00
..
boot [PATCH] PPC64: large INITRD causes kernel not to boot 2005-09-09 22:11:37 +10:00
configs [PATCH] ppc64: Add CONFIG_HZ 2005-08-30 13:40:02 +10:00
kernel [PATCH] error path in setup_arg_pages() misses vm_unacct_memory() 2005-09-14 11:18:13 -07:00
lib [PATCH] spinlock consolidation 2005-09-10 10:06:21 -07:00
mm [PATCH] ppc64: Add ptrace data breakpoint support 2005-09-12 17:19:12 +10:00
oprofile [PATCH] ppc64: Move oprofile_model into cpu feature struct 2005-09-06 16:09:21 +10:00
xmon [PATCH] ppc64: Add ptrace data breakpoint support 2005-09-12 17:19:12 +10:00
defconfig [PATCH] ppc64: Add CONFIG_HZ 2005-08-30 13:40:02 +10:00
Kconfig [PATCH] Kconfig fix (BLK_DEV_FD dependencies) 2005-09-07 17:17:12 -07:00
Kconfig.debug [PATCH] ppc64: update xmon helptext 2005-09-05 00:06:01 -07:00
Makefile [PATCH] powerpc: Move include3 to arch/$(ARCH)/include 2005-09-10 10:15:12 -07:00