q3k/linux
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
linux/drivers/net/wan
History
Eugene Teo f2455eb176 wan: Missing capability checks in sbni_ioctl() 
There are missing capability checks in the following code:

1300 static int
1301 sbni_ioctl( struct net_device  *dev,  struct ifreq  *ifr,  int  cmd)
1302 {
[...]
1319     case  SIOCDEVRESINSTATS :
1320         if( current->euid != 0 )    /* root only */
1321             return  -EPERM;
[...]
1336     case  SIOCDEVSHWSTATE :
1337         if( current->euid != 0 )    /* root only */
1338             return  -EPERM;
[...]
1357     case  SIOCDEVENSLAVE :
1358         if( current->euid != 0 )    /* root only */
1359             return  -EPERM;
[...]
1372     case  SIOCDEVEMANSIPATE :
1373         if( current->euid != 0 )    /* root only */
1374             return  -EPERM;

Here's my proposed fix:

Missing capability checks.

Signed-off-by: Eugene Teo <eugeneteo@kernel.sg>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-08-27 04:50:30 -07:00
..
lmc WAN: Use u32 type instead of u_int32_t in LMC driver. 2008-07-23 23:05:56 +02:00
.gitignore
c101.c WAN: convert drivers to use built-in netdev_stats 2008-07-04 08:47:41 -04:00
cosa.c Merge branch 'for-jeff' of git://git.kernel.org/pub/scm/linux/kernel/git/chris/linux-2.6 into tmp 2008-08-07 04:05:46 -04:00
cosa.h
cycx_drv.c
cycx_main.c
cycx_x25.c
dlci.c [NET] NETNS: Omit net_device->nd_net without CONFIG_NET_NS. 2008-03-26 04:39:53 +09:00
dscc4.c WAN: Remove unneeded "#include <net/syncppp.h>" 2008-07-23 23:00:37 +02:00
farsync.c WAN: farsync driver no longer uses syncppp.c directly 2008-07-23 23:00:38 +02:00
farsync.h WAN: farsync driver no longer uses syncppp.c directly 2008-07-23 23:00:38 +02:00
hd6457x.c WAN: convert drivers to use built-in netdev_stats 2008-07-04 08:47:41 -04:00
hd64570.h
hd64572.h
hdlc.c WAN: cosmetic changes to generic HDLC 2008-07-23 23:00:25 +02:00
hdlc_cisco.c WAN: cosmetic changes to generic HDLC 2008-07-23 23:00:25 +02:00
hdlc_fr.c WAN: cosmetic changes to generic HDLC 2008-07-23 23:00:25 +02:00
hdlc_ppp.c WAN: cosmetic changes to generic HDLC 2008-07-23 23:00:25 +02:00
hdlc_raw.c WAN: cosmetic changes to generic HDLC 2008-07-23 23:00:25 +02:00
hdlc_raw_eth.c WAN: cosmetic changes to generic HDLC 2008-07-23 23:00:25 +02:00
hdlc_x25.c WAN: cosmetic changes to generic HDLC 2008-07-23 23:00:25 +02:00
hostess_sv11.c WAN: Convert Zilog-based drivers to generic HDLC 2008-07-23 23:05:55 +02:00
Kconfig Merge branch 'for-jeff' of git://git.kernel.org/pub/scm/linux/kernel/git/chris/linux-2.6 into tmp 2008-08-07 04:05:46 -04:00
lapbether.c lapbeth: Release ->ethdev when unregistering device. 2008-05-03 21:10:58 -07:00
Makefile WAN: Port LMC driver to generic HDLC 2008-07-23 23:05:56 +02:00
n2.c
pc300-falc-lh.h
pc300.h WAN: Convert PC300 driver to use normal u8/u16/u32 types 2008-07-23 23:00:38 +02:00
pc300_drv.c WAN: Convert PC300 driver to use normal u8/u16/u32 types 2008-07-23 23:00:38 +02:00
pc300_tty.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6 2008-07-20 17:43:29 -07:00
pc300too.c
pci200syn.c
sbni.c wan: Missing capability checks in sbni_ioctl() 2008-08-27 04:50:30 -07:00
sbni.h
sdla.c
sealevel.c WAN: Convert Zilog-based drivers to generic HDLC 2008-07-23 23:05:55 +02:00
syncppp.c Remove bogus variables from syncppp.[ch] 2008-07-23 23:00:31 +02:00
wanxl.c WAN: convert drivers to use built-in netdev_stats 2008-07-04 08:47:41 -04:00
wanxl.h
wanxlfw.inc_shipped
wanxlfw.S
x25_asy.c tty: Ldisc revamp 2008-07-20 17:12:34 -07:00
x25_asy.h
z85230.c WAN: Convert Zilog-based drivers to generic HDLC 2008-07-23 23:05:55 +02:00
z85230.h WAN: Convert Zilog-based drivers to generic HDLC 2008-07-23 23:05:55 +02:00