dacbe41f77
While in theory user_enable_single_step/user_disable_single_step/
user_enable_blockstep could also be provided as an inline or macro there's
no good reason to do so, and having the prototype in one places keeps code
size and confusion down.
Roland said:
The original thought there was that user_enable_single_step() et al
might well be only an instruction or three on a sane machine (as if we
have any of those!), and since there is only one call site inlining
would be beneficial. But I agree that there is no strong reason to care
about inlining it.
As to the arch changes, there is only one thought I'd add to the
record. It was always my thinking that for an arch where
PTRACE_SINGLESTEP does text-modifying breakpoint insertion,
user_enable_single_step() should not be provided. That is,
arch_has_single_step()=>true means that there is an arch facility with
"pure" semantics that does not have any unexpected side effects.
Inserting a breakpoint might do very unexpected strange things in
multi-threaded situations. Aside from that, it is a peculiar side
effect that user_{enable,disable}_single_step() should cause COW
de-sharing of text pages and so forth. For PTRACE_SINGLESTEP, all these
peculiarities are the status quo ante for that arch, so having
arch_ptrace() itself do those is one thing. But for building other
things in the future, it is nicer to have a uniform "pure" semantics
that arch-independent code can expect.
OTOH, all such arch issues are really up to the arch maintainer. As
of today, there is nothing but ptrace using user_enable_single_step() et
al so it's a distinction without a practical difference. If/when there
are other facilities that use user_enable_single_step() and might care,
the affected arch's can revisit the question when someone cares about
the quality of the arch support for said new facility.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Roland McGrath <roland@redhat.com>
Acked-by: David Howells <dhowells@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
64 lines
1.8 KiB
C
64 lines
1.8 KiB
C
#ifndef _PARISC_PTRACE_H
|
|
#define _PARISC_PTRACE_H
|
|
|
|
/* written by Philipp Rumpf, Copyright (C) 1999 SuSE GmbH Nuernberg
|
|
** Copyright (C) 2000 Grant Grundler, Hewlett-Packard
|
|
*/
|
|
|
|
#include <linux/types.h>
|
|
|
|
/* This struct defines the way the registers are stored on the
|
|
* stack during a system call.
|
|
*
|
|
* N.B. gdb/strace care about the size and offsets within this
|
|
* structure. If you change things, you may break object compatibility
|
|
* for those applications.
|
|
*/
|
|
|
|
struct pt_regs {
|
|
unsigned long gr[32]; /* PSW is in gr[0] */
|
|
__u64 fr[32];
|
|
unsigned long sr[ 8];
|
|
unsigned long iasq[2];
|
|
unsigned long iaoq[2];
|
|
unsigned long cr27;
|
|
unsigned long pad0; /* available for other uses */
|
|
unsigned long orig_r28;
|
|
unsigned long ksp;
|
|
unsigned long kpc;
|
|
unsigned long sar; /* CR11 */
|
|
unsigned long iir; /* CR19 */
|
|
unsigned long isr; /* CR20 */
|
|
unsigned long ior; /* CR21 */
|
|
unsigned long ipsw; /* CR22 */
|
|
};
|
|
|
|
/*
|
|
* The numbers chosen here are somewhat arbitrary but absolutely MUST
|
|
* not overlap with any of the number assigned in <linux/ptrace.h>.
|
|
*
|
|
* These ones are taken from IA-64 on the assumption that theirs are
|
|
* the most correct (and we also want to support PTRACE_SINGLEBLOCK
|
|
* since we have taken branch traps too)
|
|
*/
|
|
#define PTRACE_SINGLEBLOCK 12 /* resume execution until next branch */
|
|
|
|
#ifdef __KERNEL__
|
|
|
|
#define task_regs(task) ((struct pt_regs *) ((char *)(task) + TASK_REGS))
|
|
|
|
#define arch_has_single_step() 1
|
|
#define arch_has_block_step() 1
|
|
|
|
/* XXX should we use iaoq[1] or iaoq[0] ? */
|
|
#define user_mode(regs) (((regs)->iaoq[0] & 3) ? 1 : 0)
|
|
#define user_space(regs) (((regs)->iasq[1] != 0) ? 1 : 0)
|
|
#define instruction_pointer(regs) ((regs)->iaoq[0] & ~3)
|
|
#define user_stack_pointer(regs) ((regs)->gr[30])
|
|
unsigned long profile_pc(struct pt_regs *);
|
|
extern void show_regs(struct pt_regs *);
|
|
|
|
|
|
#endif /* __KERNEL__ */
|
|
|
|
#endif
|