linux/net/9p
Tejun Heo 95820a3651 9p: drop broken unused error path from p9_conn_create()
Post p9_fd_poll() error path which checks m->poll_waddr[i] for PTR_ERR
value has the following problems.

* It's completely unused.  Error value is set iff NULL @wait_address
  has been specified to p9_pollwait() which is guaranteed not to
  happen.

* It dereferences @m after deallocating it (introduced by 571ffeaf and
  spotted by Raja R Harinath.

* It returned the wrong value on error.  It should return
  poll_waddr[i] but it returnes poll_waddr (introduced by 571ffeaf).

* p9_mux_poll_stop() doesn't handle PTR_ERR value.  It will try to
  operate on the PTR_ERR value as if it's a normal pointer and cause
  oops.

As the error path is bogus in the first place, there's no reason to
hold onto it.  Kill it.

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>
Cc: Raja R Harinath <harinath@hurrynot.org>
2008-10-17 11:04:42 -05:00
..
client.c 9p: make rpc code common and rework flush code 2008-10-17 11:04:42 -05:00
conv.c 9p: fix put_data error handling 2008-09-24 16:22:22 -05:00
error.c 9p: make cryptic unknown error from server less scary 2008-05-14 19:23:26 -05:00
fcprint.c 9p: Documentation updates 2008-05-14 19:23:25 -05:00
Kconfig 9p: fix error path during early mount 2008-05-14 19:23:27 -05:00
Makefile 9p: fix error path during early mount 2008-05-14 19:23:27 -05:00
mod.c 9p: consolidate transport structure 2008-10-17 11:04:41 -05:00
trans_fd.c 9p: drop broken unused error path from p9_conn_create() 2008-10-17 11:04:42 -05:00
trans_virtio.c 9p: make rpc code common and rework flush code 2008-10-17 11:04:42 -05:00
util.c 9p: fix flags length in net 2008-05-14 19:23:26 -05:00