linux/drivers/scsi/qla4xxx
Roland Dreier dbee8a0aff x86: remove 32-bit versions of readq()/writeq()
The presense of a writeq() implementation on 32-bit x86 that splits the
64-bit write into two 32-bit writes turns out to break the mpt2sas driver
(and in general is risky for drivers as was discussed in
<http://lkml.kernel.org/r/adaab6c1h7c.fsf@cisco.com>).  To fix this,
revert 2c5643b1c5 ("x86: provide readq()/writeq() on 32-bit too") and
follow-on cleanups.

This unfortunately leads to pushing non-atomic definitions of readq() and
write() to various x86-only drivers that in the meantime started using the
definitions in the x86 version of <asm/io.h>.  However as discussed
exhaustively, this is actually the right thing to do, because the right
way to split a 64-bit transaction is hardware dependent and therefore
belongs in the hardware driver (eg mpt2sas needs a spinlock to make sure
no other accesses occur in between the two halves of the access).

Build tested on 32- and 64-bit x86 allmodconfig.

Link: http://lkml.kernel.org/r/x86-32-writeq-is-broken@mdm.bga.com
Acked-by: Hitoshi Mitake <h.mitake@gmail.com>
Cc: Kashyap Desai <Kashyap.Desai@lsi.com>
Cc: Len Brown <lenb@kernel.org>
Cc: Ravi Anand <ravi.anand@qlogic.com>
Cc: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Jason Uhlenkott <juhlenko@akamai.com>
Acked-by: James Bottomley <James.Bottomley@parallels.com>
Acked-by: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2011-05-25 08:39:44 -07:00
..
Kconfig [SCSI] qla4xxx: Added support for ISP82XX 2010-07-28 09:04:23 -05:00
Makefile [SCSI] qla4xxx: Added support for ISP82XX 2010-07-28 09:04:23 -05:00
ql4_dbg.c [SCSI] qla4xxx: Updated the Copyright header 2010-12-21 12:24:43 -06:00
ql4_dbg.h [SCSI] qla4xxx: Updated the Copyright header 2010-12-21 12:24:43 -06:00
ql4_def.h Fix common misspellings 2011-03-31 11:26:23 -03:00
ql4_fw.h [SCSI] qla4xxx: masking required bits of add_fw_options during initialization 2011-03-23 12:53:04 -05:00
ql4_glbl.h [SCSI] qla4xxx: cleanup DDB relogin logic during initialization 2011-03-23 12:52:59 -05:00
ql4_init.c Fix common misspellings 2011-03-31 11:26:23 -03:00
ql4_inline.h [SCSI] qla4xxx: Updated the Copyright header 2010-12-21 12:24:43 -06:00
ql4_iocb.c [SCSI] qla4xxx: Updated the Copyright header 2010-12-21 12:24:43 -06:00
ql4_isr.c [SCSI] qla4xxx: Prevent other port reinitialization during remove_adapter 2011-03-23 12:53:01 -05:00
ql4_mbx.c treewide: fix a few typos in comments 2011-05-10 10:16:21 +02:00
ql4_nvram.c [SCSI] qla4xxx: Updated the Copyright header 2010-12-21 12:24:43 -06:00
ql4_nvram.h Fix common misspellings 2011-03-31 11:26:23 -03:00
ql4_nx.c x86: remove 32-bit versions of readq()/writeq() 2011-05-25 08:39:44 -07:00
ql4_nx.h [SCSI] qla4xxx: Updated the Copyright header 2010-12-21 12:24:43 -06:00
ql4_os.c [SCSI] remove cmd->serial_number litter 2011-05-01 10:22:40 -05:00
ql4_version.h [SCSI] qla4xxx: Update driver version to 5.02.00-k6 2011-03-23 12:53:05 -05:00