linux/drivers/isdn/i4l
Jeff Garzik 04518bfe8e [PATCH] ISDN: fix drivers, by handling errors thrown by ->readstat()
This is a particularly ugly on-failure bug, possibly security, since the
lack of error handling here is covering up another class of bug: failure to
handle copy_to_user() return values.

The I4L API function ->readstat() returns an integer, and by looking at
several existing driver implementations, it is clear that a negative return
value was meant to indicate an error.

Given that several drivers already return a negative value indicating an
errno-style error, the current code would blindly accept that [negative]
value as a valid amount of bytes read.  Obvious damage ensues.

Correcting ->readstat() handling to properly notice errors fixes the
existing code to work correctly on error, and enables future patches to
more easily indicate errors during operation.

Signed-off-by: Jeff Garzik <jeff@garzik.org>
Cc: Karsten Keil <kkeil@suse.de>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-10-17 08:18:49 -07:00
..
isdn_audio.c [PATCH] drivers/isdn/i4l/: possible cleanups 2005-06-25 16:24:56 -07:00
isdn_audio.h [PATCH] drivers/isdn/i4l/: possible cleanups 2005-06-25 16:24:56 -07:00
isdn_bsdcomp.c [PATCH] vfree and kfree cleanup in drivers/ 2005-09-10 10:06:30 -07:00
isdn_common.c [PATCH] ISDN: fix drivers, by handling errors thrown by ->readstat() 2006-10-17 08:18:49 -07:00
isdn_common.h [PATCH] TTY layer buffering revamp 2006-01-10 08:01:59 -08:00
isdn_concap.c [PATCH] drivers/isdn/i4l/: possible cleanups 2005-06-25 16:24:56 -07:00
isdn_concap.h [PATCH] drivers/isdn/i4l/: possible cleanups 2005-06-25 16:24:56 -07:00
isdn_net.c [IPV4]: annotate struct in_ifaddr 2006-09-28 18:00:55 -07:00
isdn_net.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
isdn_ppp.c [PATCH] isdn: cleanup i_rdev udage 2006-07-10 13:24:27 -07:00
isdn_ppp.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
isdn_tty.c [PATCH] const struct tty_operations 2006-10-02 07:57:14 -07:00
isdn_tty.h Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
isdn_ttyfax.c [PATCH] drivers/isdn/i4l/: possible cleanups 2005-06-25 16:24:56 -07:00
isdn_ttyfax.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
isdn_v110.c [PATCH] isdn_v110 warning fix 2005-09-07 16:57:36 -07:00
isdn_v110.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
isdn_x25iface.c [PATCH] SKB leak in drivers/isdn/i4l/isdn_x25iface.c 2006-06-29 10:26:21 -07:00
isdn_x25iface.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
Kconfig [PATCH] Cleanup SLHC configuration 2006-07-19 13:50:39 -04:00
Makefile Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00