q3k
/
linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
linux/drivers/scsi
History
Mark Salyzyn a73914c35b [SCSI] libsas: fix panic when single phy is disabled on a wide port 
When a wide port is being utilized to a target, if one disables only one
of the
phys, we get an OS crash:

BUG: unable to handle kernel NULL pointer dereference at
0000000000000238
IP: [<ffffffff814ca9b1>] mutex_lock+0x21/0x50
PGD 4103f5067 PUD 41dba9067 PMD 0
Oops: 0002 [#1] SMP
last sysfs file: /sys/bus/pci/slots/5/address
CPU 0
Modules linked in: pm8001(U) ses enclosure fuse nfsd exportfs autofs4
ipmi_devintf ipmi_si ipmi_msghandler nfs lockd fscache nfs_acl
auth_rpcgss 8021q fcoe libfcoe garp libfc scsi_transport_fc stp scsi_tgt
llc sunrpc cpufreq_ondemand acpi_cpufreq freq_table ipv6 sr_mod cdrom
dm_mirror dm_region_hash dm_log uinput sg i2c_i801 i2c_core iTCO_wdt
iTCO_vendor_support e1000e mlx4_ib ib_mad ib_core mlx4_en mlx4_core ext3
jbd mbcache sd_mod crc_t10dif usb_storage ata_generic pata_acpi ata_piix
libsas(U) scsi_transport_sas dm_mod [last unloaded: pm8001]

Modules linked in: pm8001(U) ses enclosure fuse nfsd exportfs autofs4
ipmi_devintf ipmi_si ipmi_msghandler nfs lockd fscache nfs_acl
auth_rpcgss 8021q fcoe libfcoe garp libfc scsi_transport_fc stp scsi_tgt
llc sunrpc cpufreq_ondemand acpi_cpufreq freq_table ipv6 sr_mod cdrom
dm_mirror dm_region_hash dm_log uinput sg i2c_i801 i2c_core iTCO_wdt
iTCO_vendor_support e1000e mlx4_ib ib_mad ib_core mlx4_en mlx4_core ext3
jbd mbcache sd_mod crc_t10dif usb_storage ata_generic pata_acpi ata_piix
libsas(U) scsi_transport_sas dm_mod [last unloaded: pm8001]
Pid: 5146, comm: scsi_wq_5 Not tainted
2.6.32-71.29.1.el6.lustre.7.x86_64 #1 Storage Server
RIP: 0010:[<ffffffff814ca9b1>]  [<ffffffff814ca9b1>]
mutex_lock+0x21/0x50
RSP: 0018:ffff8803e4e33d30  EFLAGS: 00010246
RAX: 0000000000000000 RBX: 0000000000000238 RCX: 0000000000000000
RDX: 0000000000000000 RSI: ffff8803e664c800 RDI: 0000000000000238
RBP: ffff8803e4e33d40 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000001 R12: 0000000000000000
R13: 0000000000000238 R14: ffff88041acb7200 R15: ffff88041c51ada0
FS:  0000000000000000(0000) GS:ffff880028200000(0000)
knlGS:0000000000000000
CS:  0010 DS: 0018 ES: 0018 CR0: 000000008005003b
CR2: 0000000000000238 CR3: 0000000410143000 CR4: 00000000000006f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
Process scsi_wq_5 (pid: 5146, threadinfo ffff8803e4e32000, task
ffff8803e4e294a0)
Stack:
 ffff8803e664c800 0000000000000000 ffff8803e4e33d70 ffffffffa001f06e
<0> ffff8803e4e33d60 ffff88041c51ada0 ffff88041acb7200 ffff88041bc0aa00
<0> ffff8803e4e33d90 ffffffffa0032b6c 0000000000000014 ffff88041acb7200
Call Trace:
 [<ffffffffa001f06e>] sas_port_delete_phy+0x2e/0xa0 [scsi_transport_sas]
 [<ffffffffa0032b6c>] sas_unregister_devs_sas_addr+0xac/0xe0 [libsas]
 [<ffffffffa0034914>] sas_ex_revalidate_domain+0x204/0x330 [libsas]
 [<ffffffffa00307f0>] ? sas_revalidate_domain+0x0/0x90 [libsas]
 [<ffffffffa0030855>] sas_revalidate_domain+0x65/0x90 [libsas]
 [<ffffffff8108c7d0>] worker_thread+0x170/0x2a0
 [<ffffffff81091ea0>] ? autoremove_wake_function+0x0/0x40
 [<ffffffff8108c660>] ? worker_thread+0x0/0x2a0
 [<ffffffff81091b36>] kthread+0x96/0xa0
 [<ffffffff810141ca>] child_rip+0xa/0x20
 [<ffffffff81091aa0>] ? kthread+0x0/0xa0
 [<ffffffff810141c0>] ? child_rip+0x0/0x20
Code: ff ff 85 c0 75 ed eb d6 66 90 55 48 89 e5 48 83 ec 10 48 89 1c 24
4c 89 64 24 08 0f 1f 44 00 00 48 89 fb e8 92 f4 ff ff 48 89 df <f0> ff
0f 79 05 e8 25 00 00 00 65 48 8b 04 25 08 cc 00 00 48 2d
RIP  [<ffffffff814ca9b1>] mutex_lock+0x21/0x50
 RSP <ffff8803e4e33d30>
CR2: 0000000000000238

The following patch is admittedly a band-aid, and does not solve the
root cause, but it still is a good candidate for hardening as a pointer
check before reference.

Signed-off-by: Mark Salyzyn <mark_salyzyn@us.xyratex.com>
Tested-by: Jack Wang <jack_wang@usish.com>
Cc: stable@kernel.org
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
 		2011-10-02 13:28:55 -05:00
..
aacraid [SCSI] aacraid: reset should disable MSI interrupt 2011-09-22 11:17:32 +04:00
aic7xxx
…
aic7xxx_old
…
aic94xx
…
arcmsr
…
arm
…
be2iscsi Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending 2011-07-27 13:21:40 -07:00
bfa [SCSI] bfa: Update the driver version to 3.0.2.2 2011-07-27 14:59:02 +04:00
bnx2fc [SCSI] fcoe: remove unused ptype field in fcoe_rcv_info 2011-07-28 12:08:55 +04:00
bnx2i [SCSI] bnx2i: Fixed the endian on TTT for NOP out transmission 2011-08-28 19:42:06 -07:00
cxgbi [SCSI] cxgb3i: convert cdev->l2opt to use rcu to prevent NULL dereference 2011-09-26 09:28:01 -05:00
device_handler [SCSI] dh_rdac: Associate HBA and storage in rdac_controller to support partitions in storage 2011-07-28 11:38:47 +04:00
dpt atomic: use <linux/atomic.h> 2011-07-26 16:49:47 -07:00
fcoe [SCSI] fcoe: Fix deadlock between fip's recv_work and rtnl 2011-08-28 19:38:43 -07:00
fnic
…
ibmvscsi
…
isci [SCSI] isci: add version number 2011-08-23 20:06:14 -07:00
libfc [SCSI] libfc: fix referencing to fc_fcp_pkt from the frame pointer via fr_fsp() 2011-08-28 19:40:30 -07:00
libsas [SCSI] libsas: fix panic when single phy is disabled on a wide port 2011-10-02 13:28:55 -05:00
lpfc [SCSI] lpfc 8.3.25: Change driver version to 8.3.25 2011-07-27 15:17:10 +04:00
megaraid [SCSI] megaraid_sas Version to 5.40-rc1 and Changelog update 2011-07-27 15:45:22 +04:00
mpt2sas [SCSI] mpt2sas: WarpDrive Infinite command retries due to wrong scsi command entry in MPI message 2011-07-26 13:56:27 +04:00
mvsas [SCSI] mvsas: Add support for interrupt tasklet 2011-07-26 12:59:55 +04:00
osd
…
pcmcia
…
pm8001 atomic: use <linux/atomic.h> 2011-07-26 16:49:47 -07:00
qla2xxx [SCSI] qla2xxx: Fix crash in qla2x00_abort_all_cmds() on unload 2011-10-02 11:58:30 -05:00
qla4xxx scsi: qla4xxx driver depends on NET 2011-09-10 17:31:31 -07:00
sym53c8xx_2
…
.gitignore
…
3w-9xxx.c [SCSI] 3w-9xxx: fix iommu_iova leak 2011-09-26 09:28:58 -05:00
3w-9xxx.h
…
3w-sas.c
…
3w-sas.h
…
3w-xxxx.c
…
3w-xxxx.h
…
53c700.c
…
53c700.h
…
53c700.scr
…
53c700_d.h_shipped
…
BusLogic.c
…
BusLogic.h
…
FlashPoint.c
…
Kconfig scsi: SCSI_ISCI needs to select SCSI_SAS_HOST_SMP, fixes build error 2011-09-23 16:02:33 -07:00
Makefile [SCSI] scsi: qla4xxx needs libiscsi.o 2011-09-22 11:25:48 +04:00
NCR53c406a.c
…
NCR5380.c
…
NCR5380.h
…
NCR_D700.c
…
NCR_D700.h
…
NCR_Q720.c
…
NCR_Q720.h
…
a100u2w.c
…
a100u2w.h
…
a2091.c
…
a2091.h
…
a3000.c
…
a3000.h
…
a4000t.c
…
advansys.c
…
aha152x.c
…
aha152x.h
…
aha1542.c
…
aha1542.h
…
aha1740.c
…
aha1740.h
…
aic7xxx_old.c
…
atari_NCR5380.c
…
atari_scsi.c
…
atari_scsi.h
…
atp870u.c
…
atp870u.h
…
bvme6000_scsi.c
…
ch.c
…
constants.c
…
dc395x.c
…
dc395x.h
…
dmx3191d.c
…
dpt_i2o.c
…
dpti.h
…
dtc.c
…
dtc.h
…
eata.c
…
eata_generic.h
…
eata_pio.c
…
eata_pio.h
…
esp_scsi.c
…
esp_scsi.h
…
fd_mcs.c
…
fdomain.c
…
fdomain.h
…
g_NCR5380.c
…
g_NCR5380.h
…
g_NCR5380_mmio.c
…
gdth.c
…
gdth.h
…
gdth_ioctl.h
…
gdth_proc.c
…
gdth_proc.h
…
gvp11.c
…
gvp11.h
…
hosts.c
…
hpsa.c [SCSI] hpsa: fix physical device lun and target numbering problem 2011-08-26 12:52:39 -07:00
hpsa.h [SCSI] hpsa: do not attempt to read from a write-only register 2011-07-27 15:18:26 +04:00
hpsa_cmd.h
…
hptiop.c
…
hptiop.h
…
ibmmca.c
…
imm.c
…
imm.h
…
in2000.c
…
in2000.h
…
initio.c
…
initio.h
…
ipr.c [SCSI] ipr: reorder error handling code to include iounmap 2011-07-27 17:45:08 +04:00
ipr.h
…
ips.c
…
ips.h
…
iscsi_boot_sysfs.c
…
iscsi_tcp.c
…
iscsi_tcp.h
…
jazz_esp.c
…
lasi700.c
…
libiscsi.c iscsi: Add Serial Number Arithmetic LT and GT into iscsi_proto.h 2011-07-25 07:48:08 +00:00
libiscsi_tcp.c
…
libsrp.c
…
mac53c94.c
…
mac53c94.h
…
mac_esp.c
…
mac_scsi.c
…
mac_scsi.h
…
megaraid.c
…
megaraid.h
…
mesh.c
…
mesh.h
…
mvme16x_scsi.c
…
mvme147.c
…
mvme147.h
…
ncr53c8xx.c
…
ncr53c8xx.h
…
nsp32.c
…
nsp32.h
…
nsp32_debug.c
…
nsp32_io.h
…
osst.c
…
osst.h
…
osst_detect.h
…
osst_options.h
…
pas16.c
…
pas16.h
…
pmcraid.c [SCSI] pmcraid: reject negative request size 2011-07-27 17:26:21 +04:00
pmcraid.h
…
ppa.c
…
ppa.h
…
ps3rom.c
…
qla1280.c
…
qla1280.h
…
qlogicfas.c
…
qlogicfas408.c
…
qlogicfas408.h
…
qlogicpti.c
…
qlogicpti.h
…
raid_class.c
…
script_asm.pl
…
scsi.c
…
scsi.h
…
scsi_debug.c
…
scsi_devinfo.c
…
scsi_error.c
…
scsi_ioctl.c
…
scsi_lib.c [SCSI] scsi_lib: pause between error retries 2011-07-27 14:06:01 +04:00
scsi_lib_dma.c
…
scsi_logging.h
…
scsi_module.c
…
scsi_netlink.c
…
scsi_pm.c
…
scsi_priv.h
…
scsi_proc.c
…
scsi_sas_internal.h
…
scsi_scan.c
…
scsi_sysctl.c
…
scsi_sysfs.c
…
scsi_tgt_if.c
…
scsi_tgt_lib.c
…
scsi_tgt_priv.h
…
scsi_trace.c
…
scsi_transport_api.h
…
scsi_transport_fc.c
…
scsi_transport_fc_internal.h
…
scsi_transport_iscsi.c
…
scsi_transport_sas.c
…
scsi_transport_spi.c [SCSI] scsi_transport_spi: Export host width and HBA id 2011-07-26 13:53:50 +04:00
scsi_transport_srp.c
…
scsi_transport_srp_internal.h
…
scsi_typedefs.h
…
scsi_wait_scan.c
…
scsicam.c
…
sd.c
…
sd.h
…
sd_dif.c
…
ses.c
…
sg.c
…
sgiwd93.c
…
sim710.c
…
sni_53c710.c
…
sr.c
…
sr.h
…
sr_ioctl.c
…
sr_vendor.c
…
st.c
…
st.h
…
st_options.h
…
stex.c
…
sun3_NCR5380.c
…
sun3_scsi.c
…
sun3_scsi.h
…
sun3_scsi_vme.c
…
sun3x_esp.c
…
sun_esp.c
…
sym53c416.c
…
sym53c416.h
…
t128.c
…
t128.h
…
tmscsim.c
…
tmscsim.h
…
u14-34f.c
…
ultrastor.c
…
ultrastor.h
…
vmw_pvscsi.c
…
vmw_pvscsi.h
…
wd33c93.c
…
wd33c93.h
…
wd7000.c
…
zalon.c
…
zorro7xx.c
…