q3k
/
linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
linux/fs/btrfs
History
Miao Xie 671415b7db Btrfs: fix deadlock caused by the nested chunk allocation 
Steps to reproduce:
 # mkfs.btrfs -m raid1 <disk1> <disk2>
 # btrfstune -S 1 <disk1>
 # mount <disk1> <mnt>
 # btrfs device add <disk3> <disk4> <mnt>
 # mount -o remount,rw <mnt>
 # dd if=/dev/zero of=<mnt>/tmpfile bs=1M count=1
 Deadlock happened.

It is because of the nested chunk allocation. When we wrote the data
into the filesystem, we would allocate the data chunk because there was
no data chunk in the filesystem. At the end of the data chunk allocation,
we should insert the metadata of the data chunk into the extent tree, but
there was no raid1 chunk, so we tried to lock the chunk allocation mutex to
allocate the new chunk, but we had held the mutex, the deadlock happened.

By rights, we would allocate the raid1 chunk when we added the second device
because the profile of the seed filesystem is raid1 and we had two devices.
But we didn't do that in fact. It is because the last step of the first device
insertion didn't commit the transaction. So when we added the second device,
we didn't cow the tree, and just inserted the relative metadata into the leaves
which were generated by the first device insertion, and its profile was dup.

So, I fix this problem by commiting the transaction at the end of the first
device insertion.

Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
 		2012-10-25 15:47:00 -04:00
..
Kconfig Btrfs: add config option to enable btrfs integrity check 2011-12-21 19:14:16 +01:00
Makefile Merge branch 'send-v2' of git://github.com/ablock84/linux-btrfs into for-linus 2012-07-25 19:19:10 -04:00
acl.c Btrfs: cache no acl on new inodes 2012-05-30 10:23:27 -04:00
async-thread.c Btrfs: call the ordered free operation without any locks held 2012-07-25 16:15:07 -04:00
async-thread.h btrfs: return void in functions without error conditions 2012-03-22 01:45:34 +01:00
backref.c Btrfs: extended inode refs support for send mechanism 2012-10-25 15:45:16 -04:00
backref.h Btrfs: extended inode refs support for send mechanism 2012-10-25 15:45:16 -04:00
btrfs_inode.h Btrfs: fix a bug in checking whether a inode is already in log 2012-10-01 15:19:06 -04:00
check-integrity.c Btrfs: detect corrupted filesystem after write I/O errors 2012-10-09 09:20:10 -04:00
check-integrity.h Btrfs: add optional integrity check code 2011-12-21 19:14:09 +01:00
compat.h
…
compression.c Btrfs: cleanup pages properly when ENOMEM in compression 2012-10-09 09:20:25 -04:00
compression.h btrfs: return void in functions without error conditions 2012-03-22 01:45:34 +01:00
ctree.c btrfs: remove unused function btrfs_insert_some_items() 2012-10-09 09:15:43 -04:00
ctree.h Btrfs: make filesystem read-only when submitting barrier fails 2012-10-09 09:20:19 -04:00
delayed-inode.c btrfs: polish names of kmem caches 2012-10-01 15:19:16 -04:00
delayed-inode.h Btrfs: flush delayed inodes if we're short on space 2012-07-23 15:41:40 -04:00
delayed-ref.c Btrfs: allow delayed refs to be merged 2012-08-28 16:53:38 -04:00
delayed-ref.h Btrfs: allow delayed refs to be merged 2012-08-28 16:53:38 -04:00
dir-item.c btrfs: replace many BUG_ONs with proper error handling 2012-03-22 11:52:54 +01:00
disk-io.c Btrfs: remove repeated eb->pages check in, disk-io.c/csum_dirty_buffer 2012-10-09 09:37:30 -04:00
disk-io.h Btrfs: make filesystem read-only when submitting barrier fails 2012-10-09 09:20:19 -04:00
export.c ->encode_fh() API change 2012-05-29 23:28:33 -04:00
export.h
…
extent-tree.c Btrfs: don't commit instead of overcommitting 2012-10-09 09:15:42 -04:00
extent_io.c Btrfs: Fix wrong error handling code 2012-10-25 15:40:03 -04:00
extent_io.h btrfs: move inline function code to header file 2012-10-09 09:15:43 -04:00
extent_map.c Btrfs: do not hold the write_lock on the extent tree while logging 2012-10-04 09:39:58 -04:00
extent_map.h Btrfs: do not hold the write_lock on the extent tree while logging 2012-10-04 09:39:58 -04:00
file-item.c btrfs: fix min csum item size warnings in 32bit 2012-10-09 09:15:39 -04:00
file.c Btrfs: fix punch hole when no extent exists 2012-10-04 09:40:00 -04:00
free-space-cache.c Btrfs: cache extent state when writing out dirty metadata pages 2012-10-09 09:15:41 -04:00
free-space-cache.h btrfs: remove all unused functions 2011-05-06 12:34:03 +02:00
hash.h btrfs: extended inode refs 2012-10-09 09:14:45 -04:00
inode-item.c btrfs: extended inode refs 2012-10-09 09:14:45 -04:00
inode-map.c Btrfs: show useful info in space reservation tracepoint 2012-03-29 09:57:44 -04:00
inode-map.h Btrfs: Support reading/writing on disk free ino cache 2011-04-25 16:46:11 +08:00
inode.c Btrfs: confirmation of value is added before trace_btrfs_get_extent() is called 2012-10-09 09:15:42 -04:00
ioctl.c btrfs: Return EINVAL when length to trim is less than FSB 2012-10-25 15:46:22 -04:00
ioctl.h Merge branch 'send-v2' of git://github.com/ablock84/linux-btrfs into for-linus 2012-07-25 19:19:10 -04:00
locking.c Btrfs: fix a misplaced address operator in a condition 2012-08-28 16:53:23 -04:00
locking.h btrfs: return void in functions without error conditions 2012-03-22 01:45:34 +01:00
lzo.c btrfs: remove the second argument of k[un]map_atomic() 2012-03-20 21:48:21 +08:00
ordered-data.c Btrfs: kill obsolete arguments in btrfs_wait_ordered_extents 2012-10-04 09:39:57 -04:00
ordered-data.h Btrfs: kill obsolete arguments in btrfs_wait_ordered_extents 2012-10-04 09:39:57 -04:00
orphan.c btrfs: replace many BUG_ONs with proper error handling 2012-03-22 11:52:54 +01:00
print-tree.c Btrfs: read device stats on mount, write modified ones during commit 2012-05-30 10:23:41 -04:00
print-tree.h
…
qgroup.c Btrfs: fix memory leak in btrfs_quota_enable() 2012-10-25 15:45:43 -04:00
rcu-string.h Btrfs: use rcu to protect device->name 2012-06-14 21:29:16 -04:00
reada.c Btrfs: set ioprio of scrub readahead to idle 2012-05-30 10:23:43 -04:00
relocation.c Btrfs: cache extent state when writing out dirty metadata pages 2012-10-09 09:15:41 -04:00
root-tree.c btrfs: move transaction aborts to the point of failure 2012-10-08 20:09:02 -04:00
scrub.c btrfs: Kill some bi_idx references 2012-10-01 15:19:21 -04:00
send.c Btrfs: send correct rdev and mode in btrfs-send 2012-10-25 15:45:25 -04:00
send.h Btrfs: write_buf is now callable outside send.c 2012-10-04 09:39:55 -04:00
struct-funcs.c Btrfs: rewrite BTRFS_SETGET_FUNCS 2012-07-23 16:28:06 -04:00
super.c Btrfs: make compress and nodatacow mount options mutually exclusive 2012-10-09 09:20:03 -04:00
sysfs.c btrfs: Remove unused sysfs code 2011-06-17 14:54:18 -04:00
transaction.c Btrfs: cache extent state when writing out dirty metadata pages 2012-10-09 09:15:41 -04:00
transaction.h Btrfs: fix orphan transaction on the freezed filesystem 2012-10-09 09:15:39 -04:00
tree-defrag.c btrfs: drop unused parameter from btrfs_release_path 2011-05-02 13:57:22 +02:00
tree-log.c btrfs: init ref_index to zero in add_inode_ref 2012-10-09 11:17:20 -04:00
tree-log.h btrfs: return void in functions without error conditions 2012-03-22 01:45:34 +01:00
ulist.c Btrfs: make aux field of ulist 64 bit 2012-10-01 15:18:53 -04:00
ulist.h Btrfs: make aux field of ulist 64 bit 2012-10-01 15:18:53 -04:00
version.h
…
volumes.c Btrfs: fix deadlock caused by the nested chunk allocation 2012-10-25 15:47:00 -04:00
volumes.h Btrfs: revert checksum error statistic which can cause a BUG() 2012-08-28 16:53:39 -04:00
xattr.c Btrfs: use i_version instead of our own sequence 2012-05-30 10:23:27 -04:00
xattr.h
…
zlib.c btrfs: fix message printing 2012-10-09 09:19:57 -04:00