eeff66ef6e
Without this we can cause reclaim allocation in writepage. [ 3433.448430] ================================= [ 3433.449117] [ INFO: inconsistent lock state ] [ 3433.449117] 2.6.38-rc5+ #84 [ 3433.449117] --------------------------------- [ 3433.449117] inconsistent {RECLAIM_FS-ON-W} -> {IN-RECLAIM_FS-R} usage. [ 3433.449117] kswapd0/505 [HC0[0]:SC0[0]:HE1:SE1] takes: [ 3433.449117] (iprune_sem){+++++-}, at: [<ffffffff810ebbab>] shrink_icache_memory+0x45/0x2b1 [ 3433.449117] {RECLAIM_FS-ON-W} state was registered at: [ 3433.449117] [<ffffffff8107fe5f>] mark_held_locks+0x52/0x70 [ 3433.449117] [<ffffffff8107ff02>] lockdep_trace_alloc+0x85/0x9f [ 3433.449117] [<ffffffff810d353d>] slab_pre_alloc_hook+0x18/0x3c [ 3433.449117] [<ffffffff810d3fd5>] kmem_cache_alloc+0x23/0xa2 [ 3433.449117] [<ffffffff8127be77>] idr_pre_get+0x2d/0x6f [ 3433.449117] [<ffffffff815434eb>] p9_idpool_get+0x30/0xae [ 3433.449117] [<ffffffff81540123>] p9_client_rpc+0xd7/0x9b0 [ 3433.449117] [<ffffffff815427b0>] p9_client_clunk+0x88/0xdb [ 3433.449117] [<ffffffff811d56e5>] v9fs_evict_inode+0x3c/0x48 [ 3433.449117] [<ffffffff810eb511>] evict+0x1f/0x87 [ 3433.449117] [<ffffffff810eb5c0>] dispose_list+0x47/0xe3 [ 3433.449117] [<ffffffff810eb8da>] evict_inodes+0x138/0x14f [ 3433.449117] [<ffffffff810d90e2>] generic_shutdown_super+0x57/0xe8 [ 3433.449117] [<ffffffff810d91e8>] kill_anon_super+0x11/0x50 [ 3433.449117] [<ffffffff811d4951>] v9fs_kill_super+0x49/0xab [ 3433.449117] [<ffffffff810d926e>] deactivate_locked_super+0x21/0x46 [ 3433.449117] [<ffffffff810d9e84>] deactivate_super+0x40/0x44 [ 3433.449117] [<ffffffff810ef848>] mntput_no_expire+0x100/0x109 [ 3433.449117] [<ffffffff810f0aeb>] sys_umount+0x2f1/0x31c [ 3433.449117] [<ffffffff8102c87b>] system_call_fastpath+0x16/0x1b [ 3433.449117] irq event stamp: 192941 [ 3433.449117] hardirqs last enabled at (192941): [<ffffffff81568dcf>] _raw_spin_unlock_irq+0x2b/0x30 [ 3433.449117] hardirqs last disabled at (192940): [<ffffffff810b5f97>] shrink_inactive_list+0x290/0x2f5 [ 3433.449117] softirqs last enabled at (188470): [<ffffffff8105fd65>] __do_softirq+0x133/0x152 [ 3433.449117] softirqs last disabled at (188455): [<ffffffff8102d7cc>] call_softirq+0x1c/0x28 [ 3433.449117] [ 3433.449117] other info that might help us debug this: [ 3433.449117] 1 lock held by kswapd0/505: [ 3433.449117] #0: (shrinker_rwsem){++++..}, at: [<ffffffff810b52e2>] shrink_slab+0x38/0x15f [ 3433.449117] [ 3433.449117] stack backtrace: [ 3433.449117] Pid: 505, comm: kswapd0 Not tainted 2.6.38-rc5+ #84 [ 3433.449117] Call Trace: [ 3433.449117] [<ffffffff8107fbce>] ? valid_state+0x17e/0x191 [ 3433.449117] [<ffffffff81036896>] ? save_stack_trace+0x28/0x45 [ 3433.449117] [<ffffffff81080426>] ? check_usage_forwards+0x0/0x87 [ 3433.449117] [<ffffffff8107fcf4>] ? mark_lock+0x113/0x22c [ 3433.449117] [<ffffffff8108105f>] ? __lock_acquire+0x37a/0xcf7 [ 3433.449117] [<ffffffff8107fc0e>] ? mark_lock+0x2d/0x22c [ 3433.449117] [<ffffffff81081077>] ? __lock_acquire+0x392/0xcf7 [ 3433.449117] [<ffffffff810b14d2>] ? determine_dirtyable_memory+0x15/0x28 [ 3433.449117] [<ffffffff81081a33>] ? lock_acquire+0x57/0x6d [ 3433.449117] [<ffffffff810ebbab>] ? shrink_icache_memory+0x45/0x2b1 [ 3433.449117] [<ffffffff81567d85>] ? down_read+0x47/0x5c [ 3433.449117] [<ffffffff810ebbab>] ? shrink_icache_memory+0x45/0x2b1 [ 3433.449117] [<ffffffff810ebbab>] ? shrink_icache_memory+0x45/0x2b1 [ 3433.449117] [<ffffffff810b5385>] ? shrink_slab+0xdb/0x15f [ 3433.449117] [<ffffffff810b69bc>] ? kswapd+0x574/0x96a [ 3433.449117] [<ffffffff810b6448>] ? kswapd+0x0/0x96a [ 3433.449117] [<ffffffff810714e2>] ? kthread+0x7d/0x85 [ 3433.449117] [<ffffffff8102d6d4>] ? kernel_thread_helper+0x4/0x10 [ 3433.449117] [<ffffffff81569200>] ? restore_args+0x0/0x30 [ 3433.449117] [<ffffffff81071465>] ? kthread+0x0/0x85 [ 3433.449117] [<ffffffff8102d6d0>] ? kernel_thread_helper+0x0/0x10 Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> Signed-off-by: Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com> Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>
146 lines
3.3 KiB
C
146 lines
3.3 KiB
C
/*
|
|
* net/9p/util.c
|
|
*
|
|
* This file contains some helper functions
|
|
*
|
|
* Copyright (C) 2007 by Latchesar Ionkov <lucho@ionkov.net>
|
|
* Copyright (C) 2004 by Eric Van Hensbergen <ericvh@gmail.com>
|
|
* Copyright (C) 2002 by Ron Minnich <rminnich@lanl.gov>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2
|
|
* as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to:
|
|
* Free Software Foundation
|
|
* 51 Franklin Street, Fifth Floor
|
|
* Boston, MA 02111-1301 USA
|
|
*
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/errno.h>
|
|
#include <linux/fs.h>
|
|
#include <linux/sched.h>
|
|
#include <linux/parser.h>
|
|
#include <linux/idr.h>
|
|
#include <linux/slab.h>
|
|
#include <net/9p/9p.h>
|
|
|
|
/**
|
|
* struct p9_idpool - per-connection accounting for tag idpool
|
|
* @lock: protects the pool
|
|
* @pool: idr to allocate tag id from
|
|
*
|
|
*/
|
|
|
|
struct p9_idpool {
|
|
spinlock_t lock;
|
|
struct idr pool;
|
|
};
|
|
|
|
/**
|
|
* p9_idpool_create - create a new per-connection id pool
|
|
*
|
|
*/
|
|
|
|
struct p9_idpool *p9_idpool_create(void)
|
|
{
|
|
struct p9_idpool *p;
|
|
|
|
p = kmalloc(sizeof(struct p9_idpool), GFP_KERNEL);
|
|
if (!p)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
spin_lock_init(&p->lock);
|
|
idr_init(&p->pool);
|
|
|
|
return p;
|
|
}
|
|
EXPORT_SYMBOL(p9_idpool_create);
|
|
|
|
/**
|
|
* p9_idpool_destroy - create a new per-connection id pool
|
|
* @p: idpool to destory
|
|
*/
|
|
|
|
void p9_idpool_destroy(struct p9_idpool *p)
|
|
{
|
|
idr_destroy(&p->pool);
|
|
kfree(p);
|
|
}
|
|
EXPORT_SYMBOL(p9_idpool_destroy);
|
|
|
|
/**
|
|
* p9_idpool_get - allocate numeric id from pool
|
|
* @p: pool to allocate from
|
|
*
|
|
* Bugs: This seems to be an awful generic function, should it be in idr.c with
|
|
* the lock included in struct idr?
|
|
*/
|
|
|
|
int p9_idpool_get(struct p9_idpool *p)
|
|
{
|
|
int i = 0;
|
|
int error;
|
|
unsigned long flags;
|
|
|
|
retry:
|
|
if (idr_pre_get(&p->pool, GFP_NOFS) == 0)
|
|
return 0;
|
|
|
|
spin_lock_irqsave(&p->lock, flags);
|
|
|
|
/* no need to store exactly p, we just need something non-null */
|
|
error = idr_get_new(&p->pool, p, &i);
|
|
spin_unlock_irqrestore(&p->lock, flags);
|
|
|
|
if (error == -EAGAIN)
|
|
goto retry;
|
|
else if (error)
|
|
return -1;
|
|
|
|
P9_DPRINTK(P9_DEBUG_MUX, " id %d pool %p\n", i, p);
|
|
return i;
|
|
}
|
|
EXPORT_SYMBOL(p9_idpool_get);
|
|
|
|
/**
|
|
* p9_idpool_put - release numeric id from pool
|
|
* @id: numeric id which is being released
|
|
* @p: pool to release id into
|
|
*
|
|
* Bugs: This seems to be an awful generic function, should it be in idr.c with
|
|
* the lock included in struct idr?
|
|
*/
|
|
|
|
void p9_idpool_put(int id, struct p9_idpool *p)
|
|
{
|
|
unsigned long flags;
|
|
|
|
P9_DPRINTK(P9_DEBUG_MUX, " id %d pool %p\n", id, p);
|
|
|
|
spin_lock_irqsave(&p->lock, flags);
|
|
idr_remove(&p->pool, id);
|
|
spin_unlock_irqrestore(&p->lock, flags);
|
|
}
|
|
EXPORT_SYMBOL(p9_idpool_put);
|
|
|
|
/**
|
|
* p9_idpool_check - check if the specified id is available
|
|
* @id: id to check
|
|
* @p: pool to check
|
|
*/
|
|
|
|
int p9_idpool_check(int id, struct p9_idpool *p)
|
|
{
|
|
return idr_find(&p->pool, id) != NULL;
|
|
}
|
|
EXPORT_SYMBOL(p9_idpool_check);
|
|
|