q3k
/
linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
linux/drivers
History
Arjan van de Ven 2886a8bdfa floppy: Add an extra bound check on ioctl arguments 
gcc is not convinced that the floppy.c ioctl has sufficient bound checks:

In function `copy_from_user',
    inlined from `fd_copyin' at drivers/block/floppy.c:3080,
    inlined from `fd_ioctl' at drivers/block/floppy.c:3503:
    arch/x86/include/asm/uaccess_32.h:211:
warning: call to `copy_from_user_overflow' declared with attribute
warning: copy_from_user buffer size is not provably correct

And frankly, as a human I have a hard time proving the same more or less
(the size comes from the ioctl argument.  humpf.  maybe.  the code isn't
very nice)

This patch adds an explicit check to make 100% sure it's safe, better than
finding out later that there indeed was a gap.

[akpm@linux-foundation.org: add WARN_ON()]
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Acked-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
 		2009-12-15 08:53:25 -08:00
..
accessibility
…
acpi Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/davej/cpufreq 2009-12-11 15:59:23 -08:00
amba
…
ata Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc 2009-12-12 14:27:24 -08:00
atm Merge branch 'master' of /home/davem/src/GIT/linux-2.6/ 2009-12-11 17:12:17 -08:00
auxdisplay
…
base mm: slab-allocate memory section nodemask for large systems 2009-12-15 08:53:20 -08:00
block floppy: Add an extra bound check on ioctl arguments 2009-12-15 08:53:25 -08:00
bluetooth USB: remove the auto_pm flag 2009-12-11 11:55:21 -08:00
cdrom
…
char const: constify remaining dev_pm_ops 2009-12-15 08:53:25 -08:00
clocksource
…
connector
…
cpufreq Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/percpu 2009-12-14 09:58:24 -08:00
cpuidle drivers/cpuidle: Move dereference after NULL test 2009-12-15 08:53:25 -08:00
crypto Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/percpu 2009-12-14 09:58:24 -08:00
dca
…
dio
…
dma const: constify remaining dev_pm_ops 2009-12-15 08:53:25 -08:00
edac x86, msr: Add support for non-contiguous cpumasks 2009-12-11 10:59:21 -08:00
eisa
…
firewire Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6 2009-12-11 15:22:27 -08:00
firmware firmware_class: make request_firmware_nowait more useful 2009-12-11 11:24:52 -08:00
gpio mfd: Rename all twl4030_i2c* 2009-12-13 21:23:33 +01:00
gpu Merge branch 'drm-nouveau-pony' of git://git.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6 2009-12-11 14:32:49 -08:00
hid USB: remove the auto_pm flag 2009-12-11 11:55:21 -08:00
hwmon const: constify remaining dev_pm_ops 2009-12-15 08:53:25 -08:00
i2c const: constify remaining dev_pm_ops 2009-12-15 08:53:25 -08:00
ide Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc 2009-12-12 14:27:24 -08:00
idle
…
ieee1394
…
ieee802154
…
infiniband Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/percpu 2009-12-14 09:58:24 -08:00
input const: constify remaining dev_pm_ops 2009-12-15 08:53:25 -08:00
isdn Merge git://git.kernel.org/pub/scm/linux/kernel/git/brodo/pcmcia-2.6 2009-12-14 12:33:02 -08:00
leds Merge branch 'ixp4xx' of git://git.kernel.org/pub/scm/linux/kernel/git/chris/linux-2.6 2009-12-12 15:22:22 -08:00
lguest Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/percpu 2009-12-14 09:58:24 -08:00
macintosh Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc 2009-12-12 14:27:24 -08:00
mca
…
md md: add 'recovery_start' per-device sysfs attribute 2009-12-14 12:58:57 +11:00
media const: constify remaining dev_pm_ops 2009-12-15 08:53:25 -08:00
memstick
…
message
…
mfd mfd: Add twl6030 regulator subdevices 2009-12-14 00:26:26 +01:00
misc i2c: Drop I2C_CLIENT_INSMOD_1 2009-12-14 21:17:26 +01:00
mmc const: constify remaining dev_pm_ops 2009-12-15 08:53:25 -08:00
mtd const: constify remaining dev_pm_ops 2009-12-15 08:53:25 -08:00
net const: constify remaining dev_pm_ops 2009-12-15 08:53:25 -08:00
nubus
…
of
…
oprofile Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/percpu 2009-12-14 09:58:24 -08:00
parisc
…
parport
…
pci const: constify remaining dev_pm_ops 2009-12-15 08:53:25 -08:00
pcmcia const: constify remaining dev_pm_ops 2009-12-15 08:53:25 -08:00
platform const: constify remaining dev_pm_ops 2009-12-15 08:53:25 -08:00
pnp Merge branch 'linux-next' of git://git.kernel.org/pub/scm/linux/kernel/git/jbarnes/pci-2.6 2009-12-11 12:18:16 -08:00
power const: constify remaining dev_pm_ops 2009-12-15 08:53:25 -08:00
pps
…
ps3
…
rapidio
…
regulator regulator: Add support for twl6030 regulators 2009-12-14 00:26:20 +01:00
rtc const: constify remaining dev_pm_ops 2009-12-15 08:53:25 -08:00
s390 const: constify remaining dev_pm_ops 2009-12-15 08:53:25 -08:00
sbus
…
scsi
…
serial const: constify remaining dev_pm_ops 2009-12-15 08:53:25 -08:00
sfi
…
sh
…
sn
…
spi const: constify remaining dev_pm_ops 2009-12-15 08:53:25 -08:00
ssb
…
staging Staging: batman: fix debug Kconfig option 2009-12-11 15:49:27 -08:00
tc
…
telephony
…
thermal
…
uio const: constify remaining dev_pm_ops 2009-12-15 08:53:25 -08:00
usb const: constify remaining dev_pm_ops 2009-12-15 08:53:25 -08:00
uwb
…
video const: constify remaining dev_pm_ops 2009-12-15 08:53:25 -08:00
virtio
…
vlynq
…
w1
…
watchdog const: constify remaining dev_pm_ops 2009-12-15 08:53:25 -08:00
xen Merge branch 'linux-next' of git://git.kernel.org/pub/scm/linux/kernel/git/jbarnes/pci-2.6 2009-12-11 12:18:16 -08:00
zorro
…
Kconfig
…
Makefile
…