linux/drivers/net/ehea
Julia Lawall 662f44af63 drivers/net/ehea: Remove redundant test
In each case, vpage is checked not to be NULL just after it is initialized
at the beginning of each loop iteration.

A simplified version of the semantic patch that makes this change is as
follows: (http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
expression E;
position p1,p2;
@@

if (x@p1 == NULL || ...) { ... when forall
   return ...; }
... when != \(x=E\|x--\|x++\|--x\|++x\|x-=E\|x+=E\|x|=E\|x&=E\|&x\)
(
x@p2 == NULL
|
x@p2 != NULL
)

// another path to the test that is not through p1?
@s exists@
local idexpression r.x;
position r.p1,r.p2;
@@

... when != x@p1
(
x@p2 == NULL
|
x@p2 != NULL
)

@fix depends on !s@
position r.p1,r.p2;
expression x,E;
statement S1,S2;
@@

(
- if ((x@p2 != NULL) || ...)
  S1
|
- if ((x@p2 == NULL) && ...) S1
|
- BUG_ON(x@p2 == NULL);
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-12-25 18:03:09 -08:00
..
ehea.h ehea: Fix some whitespace issues 2008-11-06 00:50:56 -05:00
ehea_ethtool.c ehea: fix ethtool checkpatch complaints 2008-02-03 04:25:56 -08:00
ehea_hcall.h
ehea_hw.h ehea: fix ehea.h checkpatch complaints 2008-02-03 04:25:55 -08:00
ehea_main.c net: Remove unused netdev arg from some NAPI interfaces. 2008-12-22 20:43:12 -08:00
ehea_phyp.c ehea: fix phyp debugging typo 2008-09-24 18:48:53 -04:00
ehea_phyp.h ehea: fix phyp checkpatch complaints 2008-02-03 04:25:57 -08:00
ehea_qmr.c drivers/net/ehea: Remove redundant test 2008-12-25 18:03:09 -08:00
ehea_qmr.h ehea: Detect 16GB hugepages for firmware restriction 2008-10-27 14:49:55 -04:00
Makefile