1f7aac6eb5
Add a call to of_node_put in the error handling code following a call to of_find_node_by_path. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r exists@ local idexpression x; expression E,E1; statement S; @@ *x = (of_find_node_by_path |of_find_node_by_name |of_find_node_by_phandle |of_get_parent |of_get_next_parent |of_get_next_child |of_find_compatible_node |of_match_node )(...); ... if (x == NULL) S <... when != x = E *if (...) { ... when != of_node_put(x) when != if (...) { ... of_node_put(x); ... } ( return <+...x...+>; | * return ...; ) } ...> of_node_put(x); // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
117 lines
3.1 KiB
C
117 lines
3.1 KiB
C
/*
|
|
* via-pmu LED class device
|
|
*
|
|
* Copyright 2006 Johannes Berg <johannes@sipsolutions.net>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
|
|
* NON INFRINGEMENT. See the GNU General Public License for more
|
|
* details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*
|
|
*/
|
|
#include <linux/types.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/device.h>
|
|
#include <linux/leds.h>
|
|
#include <linux/adb.h>
|
|
#include <linux/pmu.h>
|
|
#include <asm/prom.h>
|
|
|
|
static spinlock_t pmu_blink_lock;
|
|
static struct adb_request pmu_blink_req;
|
|
/* -1: no change, 0: request off, 1: request on */
|
|
static int requested_change;
|
|
|
|
static void pmu_req_done(struct adb_request * req)
|
|
{
|
|
unsigned long flags;
|
|
|
|
spin_lock_irqsave(&pmu_blink_lock, flags);
|
|
/* if someone requested a change in the meantime
|
|
* (we only see the last one which is fine)
|
|
* then apply it now */
|
|
if (requested_change != -1 && !pmu_sys_suspended)
|
|
pmu_request(&pmu_blink_req, NULL, 4, 0xee, 4, 0, requested_change);
|
|
/* reset requested change */
|
|
requested_change = -1;
|
|
spin_unlock_irqrestore(&pmu_blink_lock, flags);
|
|
}
|
|
|
|
static void pmu_led_set(struct led_classdev *led_cdev,
|
|
enum led_brightness brightness)
|
|
{
|
|
unsigned long flags;
|
|
|
|
spin_lock_irqsave(&pmu_blink_lock, flags);
|
|
switch (brightness) {
|
|
case LED_OFF:
|
|
requested_change = 0;
|
|
break;
|
|
case LED_FULL:
|
|
requested_change = 1;
|
|
break;
|
|
default:
|
|
goto out;
|
|
break;
|
|
}
|
|
/* if request isn't done, then don't do anything */
|
|
if (pmu_blink_req.complete && !pmu_sys_suspended)
|
|
pmu_request(&pmu_blink_req, NULL, 4, 0xee, 4, 0, requested_change);
|
|
out:
|
|
spin_unlock_irqrestore(&pmu_blink_lock, flags);
|
|
}
|
|
|
|
static struct led_classdev pmu_led = {
|
|
.name = "pmu-led::front",
|
|
#ifdef CONFIG_ADB_PMU_LED_IDE
|
|
.default_trigger = "ide-disk",
|
|
#endif
|
|
.brightness_set = pmu_led_set,
|
|
};
|
|
|
|
static int __init via_pmu_led_init(void)
|
|
{
|
|
struct device_node *dt;
|
|
const char *model;
|
|
|
|
/* only do this on keylargo based models */
|
|
if (pmu_get_model() != PMU_KEYLARGO_BASED)
|
|
return -ENODEV;
|
|
|
|
dt = of_find_node_by_path("/");
|
|
if (dt == NULL)
|
|
return -ENODEV;
|
|
model = of_get_property(dt, "model", NULL);
|
|
if (model == NULL) {
|
|
of_node_put(dt);
|
|
return -ENODEV;
|
|
}
|
|
if (strncmp(model, "PowerBook", strlen("PowerBook")) != 0 &&
|
|
strncmp(model, "iBook", strlen("iBook")) != 0 &&
|
|
strcmp(model, "PowerMac7,2") != 0 &&
|
|
strcmp(model, "PowerMac7,3") != 0) {
|
|
of_node_put(dt);
|
|
/* ignore */
|
|
return -ENODEV;
|
|
}
|
|
of_node_put(dt);
|
|
|
|
spin_lock_init(&pmu_blink_lock);
|
|
/* no outstanding req */
|
|
pmu_blink_req.complete = 1;
|
|
pmu_blink_req.done = pmu_req_done;
|
|
|
|
return led_classdev_register(NULL, &pmu_led);
|
|
}
|
|
|
|
late_initcall(via_pmu_led_init);
|