linux/fs/smbfs
Andi Kleen 9465efc9e9 Remove BKL from remote_llseek v2
- Replace remote_llseek with generic_file_llseek_unlocked (to force compilation
failures in all users)
- Change all users to either use generic_file_llseek_unlocked directly or
take the BKL around. I changed the file systems who don't use the BKL
for anything (CIFS, GFS) to call it directly. NCPFS and SMBFS and NFS
take the BKL, but explicitely in their own source now.

I moved them all over in a single patch to avoid unbisectable sections.

Open problem: 32bit kernels can corrupt fpos because its modification
is not atomic, but they can do that anyways because there's other paths who
modify it without BKL.

Do we need a special lock for the pos/f_version = 0 checks?

Trond says the NFS BKL is likely not needed, but keep it for now
until his full audit.

v2: Use generic_file_llseek_unlocked instead of remote_llseek_unlocked
    and factor duplicated code (suggested by hch)

Cc: Trond.Myklebust@netapp.com
Cc: swhiteho@redhat.com
Cc: sfrench@samba.org
Cc: vandrove@vc.cvut.cz

Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2008-07-02 15:06:27 -06:00
..
Makefile FS: Remove dead code 2008-01-28 23:14:37 +01:00
cache.c [PATCH] struct path: convert smbfs 2006-12-08 08:28:49 -08:00
dir.c Detach sched.h from mm.h 2007-05-21 09:18:19 -07:00
file.c Remove BKL from remote_llseek v2 2008-07-02 15:06:27 -06:00
getopt.c
getopt.h
inode.c fs/smbfs/inode.c: fix warning message deprecating smbfs 2008-02-13 16:21:19 -08:00
ioctl.c
proc.c smbfs: fix debug builds 2007-11-14 18:45:43 -08:00
proto.h [PATCH] mark struct inode_operations const 3 2007-02-12 09:48:46 -08:00
request.c Remove commented-out code copied from NFS 2007-12-06 17:40:31 -05:00
request.h
smb_debug.h fs: replace remaining __FUNCTION__ occurrences 2008-04-30 08:29:54 -07:00
smbiod.c NULL noise: fs/*, mm/*, kernel/* 2008-03-30 14:18:41 -07:00
sock.c smbfs: fix calculation of kernel_recvmsg size parameter in smb_receive() 2008-02-06 10:41:02 -08:00
symlink.c header cleaning: don't include smp_lock.h when not used 2007-05-08 11:15:07 -07:00