linux/arch/arm/plat-omap
Russell King 4da3782151 [ARM] omap: clk_set_parent: deny changing parent if clock is enabled
Richard Woodruff writes:
| The historic usage of this has been against single use leaf clocks
| (1st instance of gptimer).  When it was used it did:
|       clk_get()
|       clk_set_parent()
|       clk_enable()
|
| This usage was ok for that. Use on a disabled clock is needed.
|
| If there are multiple users on the clock or it is enabled there are
| problems.
|
| The call can still be unfriendly if 2 different drivers are using the
| clock with their own clock get/enable. It might be the function should
| return an error if usecount != 0 to stop surprises.  It is all around
| better if the parenting is done when the clock is off.

This is a good reason to ensure that the clock is not enabled when
clk_set_parent() is called.

Acked-by: Richard Woodruff <r-woodruff2@ti.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2009-03-03 13:08:18 +00:00
..
include/mach [ARM] OMAP3: update ES level flags to discriminate between post-ES2 revisions 2009-02-23 14:52:51 +00:00
clock.c [ARM] omap: clk_set_parent: deny changing parent if clock is enabled 2009-03-03 13:08:18 +00:00
common.c [ARM] OMAP2 SDRC: separate common OMAP2/3 code from OMAP2xxx code 2009-02-08 17:50:39 +00:00
cpu-omap.c [ARM] OMAP2: Implement CPUfreq frequency table based on PRCM table 2009-02-08 17:50:28 +00:00
debug-devices.c ARM: OMAP: Switch to gpio_request/free calls 2008-12-10 17:35:30 -08:00
debug-leds.c ARM: OMAP: switch to standard gpio get/set calls 2008-12-10 17:35:25 -08:00
devices.c ARM: OMAP: Fix hsmmc init, v2 2009-01-29 08:57:16 -08:00
dma.c ARM: OMAP: DMA: Fix uninitialized channel flags 2009-01-29 08:57:12 -08:00
dmtimer.c ARM: OMAP2: skip unnecessary TLDR write during non-autoreload for gptimer 2008-12-10 17:36:34 -08:00
fb.c [ARM] Convert asm/io.h to linux/io.h 2008-09-06 12:10:45 +01:00
gpio.c ARM: OMAP: Fix gpio.c compile on 15xx with CONFIG_DEBUGFS 2009-01-15 13:09:53 +02:00
i2c.c [ARM] fix AT91, davinci, h720x, ks8695, msm, mx2, mx3, netx, omap1, omap2, pxa, s3c 2009-01-08 16:29:42 +00:00
io.c ARM: OMAP3: Add minimal omap3430 support 2008-10-09 17:51:41 +03:00
Kconfig [ARM] omap: convert OMAP3 to use clkdev 2009-02-08 17:50:15 +00:00
mailbox.c [ARM] Convert asm/io.h to linux/io.h 2008-09-06 12:10:45 +01:00
mailbox.h ARM: OMAP: Add mailbox support for IVA 2007-05-09 10:37:10 +01:00
Makefile [ARM] omap: allow ioremap() to use our fixed IO mappings 2008-09-05 17:02:29 +01:00
mcbsp.c [ARM] omap: mcbsp: convert to use fck/ick clocks directly 2009-02-08 17:50:19 +00:00
mux.c [ARM] Convert asm/io.h to linux/io.h 2008-09-06 12:10:45 +01:00
ocpi.c [ARM] Convert asm/io.h to linux/io.h 2008-09-06 12:10:45 +01:00
sram.c ARM: OMAP2: Use omap_rev() instead of system_rev 2008-12-10 17:36:31 -08:00
usb.c [ARM] omap: usb: thou shalt not provide empty release functions 2009-01-24 17:00:45 +00:00