linux/sound
Andrea Righi 27ac792ca0 PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures
On 32-bit architectures PAGE_ALIGN() truncates 64-bit values to the 32-bit
boundary. For example:

	u64 val = PAGE_ALIGN(size);

always returns a value < 4GB even if size is greater than 4GB.

The problem resides in PAGE_MASK definition (from include/asm-x86/page.h for
example):

#define PAGE_SHIFT      12
#define PAGE_SIZE       (_AC(1,UL) << PAGE_SHIFT)
#define PAGE_MASK       (~(PAGE_SIZE-1))
...
#define PAGE_ALIGN(addr)       (((addr)+PAGE_SIZE-1)&PAGE_MASK)

The "~" is performed on a 32-bit value, so everything in "and" with
PAGE_MASK greater than 4GB will be truncated to the 32-bit boundary.
Using the ALIGN() macro seems to be the right way, because it uses
typeof(addr) for the mask.

Also move the PAGE_ALIGN() definitions out of include/asm-*/page.h in
include/linux/mm.h.

See also lkml discussion: http://lkml.org/lkml/2008/6/11/237

[akpm@linux-foundation.org: fix drivers/media/video/uvc/uvc_queue.c]
[akpm@linux-foundation.org: fix v850]
[akpm@linux-foundation.org: fix powerpc]
[akpm@linux-foundation.org: fix arm]
[akpm@linux-foundation.org: fix mips]
[akpm@linux-foundation.org: fix drivers/media/video/pvrusb2/pvrusb2-dvb.c]
[akpm@linux-foundation.org: fix drivers/mtd/maps/uclinux.c]
[akpm@linux-foundation.org: fix powerpc]
Signed-off-by: Andrea Righi <righi.andrea@gmail.com>
Cc: <linux-arch@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-24 10:47:21 -07:00
..
aoa sound: Convert to menuconfig 2008-05-27 15:56:20 +02:00
arm sound: Convert to menuconfig 2008-05-27 15:56:20 +02:00
core PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures 2008-07-24 10:47:21 -07:00
drivers Merge git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git 2008-07-14 15:51:11 -07:00
i2c [ALSA] remove CVS keywords 2008-05-27 15:56:20 +02:00
isa Merge git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git 2008-07-14 15:51:11 -07:00
mips ALSA: ALSA driver for SGI O2 audio board 2008-07-14 09:01:02 +02:00
oss device create: sound: convert device_create to device_create_drvdata 2008-07-21 21:54:44 -07:00
parisc sound: Convert to menuconfig 2008-05-27 15:56:20 +02:00
pci Merge git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git 2008-07-14 15:51:11 -07:00
pcmcia ALSA: Fix a const to non-const assignment in the Digigram VXpocket sound driver 2008-07-10 09:32:57 +02:00
ppc ALSA: remove CONFIG_KMOD from sound 2008-07-10 09:32:58 +02:00
sh sound: Convert to menuconfig 2008-05-27 15:56:20 +02:00
soc Merge branch 'devel' of master.kernel.org:/home/rmk/linux-2.6-arm 2008-07-23 18:24:08 -07:00
sparc ALSA: make sparc/dbri.c:snd_dbri_proc() static 2008-06-06 11:55:05 +02:00
spi sound: Convert to menuconfig 2008-05-27 15:56:20 +02:00
synth [ALSA] emux midi synthesizer doesn't honor SOFT_PEDAL-release event 2008-05-13 14:47:43 +02:00
usb ALSA: usb-audio: add some Yamaha USB MIDI quirks 2008-07-10 11:05:42 +02:00
ac97_bus.c
Kconfig sound: Convert to menuconfig 2008-05-27 15:56:20 +02:00
last.c [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
Makefile [ALSA] Add SPI devices to ALSA Kconfig and Makefile 2007-10-16 15:57:47 +02:00
sound_core.c device create: sound: convert device_create to device_create_drvdata 2008-07-21 21:54:44 -07:00
sound_firmware.c