13e165baf6
One of our users reported that when a user-level program SIGSEGVs under
UML kernel, the resulting core dump is not very usable.
I have reproduced that with the latest kernel:
make ARCH=um defconfig; make ARCH=um
Run the resulting kernel, then "inside" run this program:
#include <pthread.h>
void *fn(void *p)
{
abort();
}
int main()
{
pthread_t tid;
pthread_create(&tid, 0, fn, 0);
pthread_join(tid, 0);
return 0;
}
Analyze the coredump with GDB. Here is what you'll see:
sudo gdb -q -ex 'set solib-absolute-prefix ../root_fs' -ex 'file ../root_fs/var/tmp/mt-abort' -ex 'core ../root_fs/var/tmp/core.762'
Reading symbols from /usr/local/google/root_fs/var/tmp/mt-abort...done.
[New Thread 763]
[New Thread 762]
Core was generated by `./mt-abort'.
Program terminated with signal 6, Aborted.
#0 0x0000000040255250 in raise () from ../root_fs/lib64/libc.so.6
(gdb) info thread
2 Thread 762 0x0000000000000000 in ?? ()
* 1 Thread 763 0x0000000040255250 in raise () from ../root_fs/lib64/libc.so.6
Note that thread#2 looks funny.
(gdb) thread 2
[Switching to thread 2 (Thread 762)]#0 0x0000000000000000 in ?? ()
(gdb) info reg
rax 0x0 0
rbx 0x0 0
rcx 0x0 0
rdx 0x0 0
rsi 0x0 0
rdi 0x0 0
rbp 0x0 0x0
rsp 0x0 0x0
r8 0x0 0
r9 0x0 0
r10 0x0 0
r11 0x0 0
r12 0x0 0
r13 0x0 0
r14 0x0 0
r15 0x0 0
rip 0x0 0
eflags 0x0 [ ]
cs 0x0 0
ss 0x0 0
ds 0x0 0
es 0x0 0
fs 0x0 0
gs 0x0 0
Examining the core shows that NT_PRSTATUS notes for all threads other than
the one that crashed are zeroed out.
I believe this is happening because neither ELF_CORE_COPY_TASK_REGS nor
task_pt_regs are defined under ARCH=um, and so elf_core_copy_task_regs()
becomes a no-op.
Attached patch fixes this for SUBARCH={x86_64,i386}.
Signed-off-by: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: Jeff Dike <jdike@addtoit.com>
Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
123 lines
3.1 KiB
C
123 lines
3.1 KiB
C
/*
|
|
* Copyright (C) 2000 - 2007 Jeff Dike (jdike@{addtoit,linux.intel}.com)
|
|
* Licensed under the GPL
|
|
*/
|
|
#ifndef __UM_ELF_I386_H
|
|
#define __UM_ELF_I386_H
|
|
|
|
#include <asm/user.h>
|
|
#include "skas.h"
|
|
|
|
#define R_386_NONE 0
|
|
#define R_386_32 1
|
|
#define R_386_PC32 2
|
|
#define R_386_GOT32 3
|
|
#define R_386_PLT32 4
|
|
#define R_386_COPY 5
|
|
#define R_386_GLOB_DAT 6
|
|
#define R_386_JMP_SLOT 7
|
|
#define R_386_RELATIVE 8
|
|
#define R_386_GOTOFF 9
|
|
#define R_386_GOTPC 10
|
|
#define R_386_NUM 11
|
|
|
|
typedef unsigned long elf_greg_t;
|
|
|
|
#define ELF_NGREG (sizeof (struct user_regs_struct) / sizeof(elf_greg_t))
|
|
typedef elf_greg_t elf_gregset_t[ELF_NGREG];
|
|
|
|
typedef struct user_i387_struct elf_fpregset_t;
|
|
|
|
/*
|
|
* This is used to ensure we don't load something for the wrong architecture.
|
|
*/
|
|
#define elf_check_arch(x) \
|
|
(((x)->e_machine == EM_386) || ((x)->e_machine == EM_486))
|
|
|
|
#define ELF_CLASS ELFCLASS32
|
|
#define ELF_DATA ELFDATA2LSB
|
|
#define ELF_ARCH EM_386
|
|
|
|
#define ELF_PLAT_INIT(regs, load_addr) do { \
|
|
PT_REGS_EBX(regs) = 0; \
|
|
PT_REGS_ECX(regs) = 0; \
|
|
PT_REGS_EDX(regs) = 0; \
|
|
PT_REGS_ESI(regs) = 0; \
|
|
PT_REGS_EDI(regs) = 0; \
|
|
PT_REGS_EBP(regs) = 0; \
|
|
PT_REGS_EAX(regs) = 0; \
|
|
} while (0)
|
|
|
|
#define ELF_EXEC_PAGESIZE 4096
|
|
|
|
#define ELF_ET_DYN_BASE (2 * TASK_SIZE / 3)
|
|
|
|
/* Shamelessly stolen from include/asm-i386/elf.h */
|
|
|
|
#define ELF_CORE_COPY_REGS(pr_reg, regs) do { \
|
|
pr_reg[0] = PT_REGS_EBX(regs); \
|
|
pr_reg[1] = PT_REGS_ECX(regs); \
|
|
pr_reg[2] = PT_REGS_EDX(regs); \
|
|
pr_reg[3] = PT_REGS_ESI(regs); \
|
|
pr_reg[4] = PT_REGS_EDI(regs); \
|
|
pr_reg[5] = PT_REGS_EBP(regs); \
|
|
pr_reg[6] = PT_REGS_EAX(regs); \
|
|
pr_reg[7] = PT_REGS_DS(regs); \
|
|
pr_reg[8] = PT_REGS_ES(regs); \
|
|
/* fake once used fs and gs selectors? */ \
|
|
pr_reg[9] = PT_REGS_DS(regs); \
|
|
pr_reg[10] = PT_REGS_DS(regs); \
|
|
pr_reg[11] = PT_REGS_SYSCALL_NR(regs); \
|
|
pr_reg[12] = PT_REGS_IP(regs); \
|
|
pr_reg[13] = PT_REGS_CS(regs); \
|
|
pr_reg[14] = PT_REGS_EFLAGS(regs); \
|
|
pr_reg[15] = PT_REGS_SP(regs); \
|
|
pr_reg[16] = PT_REGS_SS(regs); \
|
|
} while (0);
|
|
|
|
#define task_pt_regs(t) (&(t)->thread.regs)
|
|
|
|
struct task_struct;
|
|
|
|
extern int elf_core_copy_fpregs(struct task_struct *t, elf_fpregset_t *fpu);
|
|
|
|
#define ELF_CORE_COPY_FPREGS(t, fpu) elf_core_copy_fpregs(t, fpu)
|
|
|
|
extern long elf_aux_hwcap;
|
|
#define ELF_HWCAP (elf_aux_hwcap)
|
|
|
|
extern char * elf_aux_platform;
|
|
#define ELF_PLATFORM (elf_aux_platform)
|
|
|
|
#define SET_PERSONALITY(ex) do { } while (0)
|
|
|
|
extern unsigned long vsyscall_ehdr;
|
|
extern unsigned long vsyscall_end;
|
|
extern unsigned long __kernel_vsyscall;
|
|
|
|
#define VSYSCALL_BASE vsyscall_ehdr
|
|
#define VSYSCALL_END vsyscall_end
|
|
|
|
/*
|
|
* This is the range that is readable by user mode, and things
|
|
* acting like user mode such as get_user_pages.
|
|
*/
|
|
#define FIXADDR_USER_START VSYSCALL_BASE
|
|
#define FIXADDR_USER_END VSYSCALL_END
|
|
|
|
/*
|
|
* Architecture-neutral AT_ values in 0-17, leave some room
|
|
* for more of them, start the x86-specific ones at 32.
|
|
*/
|
|
#define AT_SYSINFO 32
|
|
#define AT_SYSINFO_EHDR 33
|
|
|
|
#define ARCH_DLINFO \
|
|
do { \
|
|
if ( vsyscall_ehdr ) { \
|
|
NEW_AUX_ENT(AT_SYSINFO, __kernel_vsyscall); \
|
|
NEW_AUX_ENT(AT_SYSINFO_EHDR, vsyscall_ehdr); \
|
|
} \
|
|
} while (0)
|
|
|
|
#endif
|