linux/drivers/isdn
Alexey Dobriyan 99b7623380 proc 2/2: remove struct proc_dir_entry::owner
Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy
as correctly noted at bug #12454. Someone can lookup entry with NULL
->owner, thus not pinning enything, and release it later resulting
in module refcount underflow.

We can keep ->owner and supply it at registration time like ->proc_fops
and ->data.

But this leaves ->owner as easy-manipulative field (just one C assignment)
and somebody will forget to unpin previous/pin current module when
switching ->owner. ->proc_fops is declared as "const" which should give
some thoughts.

->read_proc/->write_proc were just fixed to not require ->owner for
protection.

rmmod'ed directories will be empty and return "." and ".." -- no harm.
And directories with tricky enough readdir and lookup shouldn't be modular.
We definitely don't want such modular code.

Removing ->owner will also make PDE smaller.

So, let's nuke it.

Kudos to Jeff Layton for reminding about this, let's say, oversight.

http://bugzilla.kernel.org/show_bug.cgi?id=12454

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
2009-03-31 01:14:44 +04:00
..
act2000 drivers/isdn/act2000: fix sparse warning: symbol shadows an earlier one 2009-02-27 01:00:41 -08:00
capi drivers/isdn/capi: fix sparse warning: context imbalance 2009-02-27 01:00:41 -08:00
divert isdn: use non-racy method for proc entries creation 2008-04-29 08:06:22 -07:00
gigaset Merge branch 'master' of /home/davem/src/GIT/linux-2.6/ 2009-03-26 15:23:24 -07:00
hardware proc 2/2: remove struct proc_dir_entry::owner 2009-03-31 01:14:44 +04:00
hisax drivers/isdn/hisax: fix sparse warning: Should it be static? 2009-02-27 01:00:42 -08:00
hysdn hysdn: convert to net_device_ops and other updates 2009-01-07 18:03:43 -08:00
i4l isdn: Fix missing ifdef in isdn_ppp 2009-01-26 12:24:38 -08:00
icn fix ! versus & precedence in various places 2008-02-06 10:40:59 -08:00
isdnloop drivers/isdn: correct use of ! and & 2008-03-04 16:35:16 -08:00
mISDN MISDN: list usage cleanup 2009-02-26 22:38:15 -08:00
pcbit isdn: remove some pointless conditionals before kfree_skb() 2009-02-26 23:07:29 -08:00
sc ISDN: fix sc/shmem printk format warning 2009-02-20 00:54:44 -08:00
Kconfig Add mISDN driver 2008-07-27 01:46:33 +02:00
Makefile mISDN fix main ISDN Makefile 2008-08-02 16:28:20 +02:00