Dan Williams f2b20d4365 block: fix blk_queue_end_tag() ... Commit 5e081591 "block: warn if tag is greater than real_max_depth" cleaned up blk_queue_end_tag() to warn when the tag is truly invalid (greater than real_max_depth). However, it changed behavior in the tag < max_depth case to not end the request. Leading to triggering of BUG_ON(blk_queued_rq(rq)) in the request completion path: http://marc.info/?l=linux-kernel&m=132204370518629&w=2 In order to allow blk_queue_resize_tags() to shrink the tag space blk_queue_end_tag() must always complete tags with a value less than real_max_depth regardless of the current max_depth. The comment about "handling the shrink case" seems to be what prompted changes in this space, so remove it and BUG on all invalid tags (made even simpler by Matthew's suggestion to use an unsigned compare). Signed-off-by: Dan Williams <dan.j.williams@intel.com> Cc: Tao Ma <boyu.mt@taobao.com> Cc: Matthew Wilcox <matthew@wil.cx> Reported-by: Meelis Roos <mroos@ut.ee> Reported-by: Ed Nadolski <edmund.nadolski@intel.com> Cc: Tejun Heo <tj@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Jens Axboe <axboe@kernel.dk>		2011-12-29 09:16:28 +01:00
..
Kconfig	…
Kconfig.iosched	…
Makefile	…
blk-cgroup.c	blk-throttle: Take blkcg->lock while traversing blkcg->policy_list	2011-10-25 15:48:12 +02:00
blk-cgroup.h	block: fix a typo in the blk-cgroup.h file	2011-10-24 16:08:38 +02:00
blk-core.c	block: don't kick empty queue in blk_drain_queue()	2011-12-15 20:03:04 +01:00
blk-exec.c	…
blk-flush.c	blk-flush: move the queue kick into	2011-10-24 16:24:31 +02:00
blk-integrity.c	block: add export.h to files using EXPORT_SYMBOL/THIS_MODULE macros	2011-10-31 19:31:12 -04:00
blk-ioc.c	…
blk-iopoll.c	…
blk-lib.c	…
blk-map.c	block: re-use existing 'reading' variable instead of checking direction again	2011-12-21 15:27:24 +01:00
blk-merge.c	…
blk-settings.c	…
blk-softirq.c	…
blk-sysfs.c	block: fix request_queue lifetime handling by making blk_queue_cleanup() properly shutdown	2011-10-19 14:42:16 +02:00
blk-tag.c	block: fix blk_queue_end_tag()	2011-12-29 09:16:28 +01:00
blk-throttle.c	blk-throttle: use queue_is_locked() instead of lockdep_is_held()	2011-10-25 15:51:48 +02:00
blk-timeout.c	…
blk.h	block: fix request_queue lifetime handling by making blk_queue_cleanup() properly shutdown	2011-10-19 14:42:16 +02:00
bsg-lib.c	block: Change module.h -> export.h in bsg-lib.c	2011-10-31 19:31:13 -04:00
bsg.c	…
cfq-iosched.c	block, cfq: fix empty queue crash caused by request merge	2011-12-16 14:04:23 +01:00
cfq.h	…
compat_ioctl.c	…
deadline-iosched.c	…
elevator.c	block: fix request_queue lifetime handling by making blk_queue_cleanup() properly shutdown	2011-10-19 14:42:16 +02:00
genhd.c	block: Revert "[SCSI] genhd: add a new attribute "alias" in gendisk"	2011-11-10 09:03:55 +01:00
ioctl.c	Merge branch 'modsplit-Oct31_2011' of git://git.kernel.org/pub/scm/linux/kernel/git/paulg/linux	2011-11-06 19:44:47 -08:00
noop-iosched.c	…
scsi_ioctl.c	…