156229b352
Since commit f44f7f9
(RTC: Initialize kernel state from RTC)
rtc_device_register reads the programmed alarm. As reading the alarm
needs to take the mc13xxx lock, release it before calling
rtc_device_register.
This fixes a deadlock during boot:
INFO: task swapper:1 blocked for more than 120 seconds.
"echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
swapper D c02b175c 0 1 0 0x00000000
[<c02b175c>] (schedule+0x304/0x4f4) from [<c02b25a8>] (__mutex_lock_slowpath+0x7c/0x110)
[<c02b25a8>] (__mutex_lock_slowpath+0x7c/0x110) from [<c020b4cc>] (mc13xxx_rtc_read_time+0x1c/0x118)
[<c020b4cc>] (mc13xxx_rtc_read_time+0x1c/0x118) from [<c0208f04>] (__rtc_read_time+0x58/0x5c)
[<c0208f04>] (__rtc_read_time+0x58/0x5c) from [<c0209508>] (rtc_read_time+0x30/0x48)
[<c0209508>] (rtc_read_time+0x30/0x48) from [<c0209dd4>] (__rtc_read_alarm+0x1c/0x290)
[<c0209dd4>] (__rtc_read_alarm+0x1c/0x290) from [<c0208d58>] (rtc_device_register+0x150/0x27c)
[<c0208d58>] (rtc_device_register+0x150/0x27c) from [<c02b0b74>] (mc13xxx_rtc_probe+0x128/0x17c)
[<c02b0b74>] (mc13xxx_rtc_probe+0x128/0x17c) from [<c01d5280>] (platform_drv_probe+0x1c/0x24)
[<c01d5280>] (platform_drv_probe+0x1c/0x24) from [<c01d3e58>] (driver_probe_device+0x80/0x1a8)
[<c01d3e58>] (driver_probe_device+0x80/0x1a8) from [<c01d400c>] (__driver_attach+0x8c/0x90)
[<c01d400c>] (__driver_attach+0x8c/0x90) from [<c01d3654>] (bus_for_each_dev+0x60/0x8c)
[<c01d3654>] (bus_for_each_dev+0x60/0x8c) from [<c01d2f6c>] (bus_add_driver+0x180/0x248)
[<c01d2f6c>] (bus_add_driver+0x180/0x248) from [<c01d4664>] (driver_register+0x70/0x15c)
[<c01d4664>] (driver_register+0x70/0x15c) from [<c01d5700>] (platform_driver_probe+0x18/0x98)
[<c01d5700>] (platform_driver_probe+0x18/0x98) from [<c00273a8>] (do_one_initcall+0x2c/0x168)
[<c00273a8>] (do_one_initcall+0x2c/0x168) from [<c00083ac>] (kernel_init+0xa0/0x150)
[<c00083ac>] (kernel_init+0xa0/0x150) from [<c0033ff8>] (kernel_thread_exit+0x0/0x8)
Reported-by: Vagrant Cascadian <vagrant@debian.org>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Closes: http://bugs.debian.org/625804
[Tweaked commit log -jstultz]
Signed-off-by: John Stultz <john.stultz@linaro.org>
435 lines
9.3 KiB
C
435 lines
9.3 KiB
C
/*
|
|
* Real Time Clock driver for Freescale MC13XXX PMIC
|
|
*
|
|
* (C) 2009 Sascha Hauer, Pengutronix
|
|
* (C) 2009 Uwe Kleine-Koenig, Pengutronix
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*/
|
|
|
|
#include <linux/mfd/mc13xxx.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/rtc.h>
|
|
|
|
#define DRIVER_NAME "mc13xxx-rtc"
|
|
|
|
#define MC13XXX_RTCTOD 20
|
|
#define MC13XXX_RTCTODA 21
|
|
#define MC13XXX_RTCDAY 22
|
|
#define MC13XXX_RTCDAYA 23
|
|
|
|
struct mc13xxx_rtc {
|
|
struct rtc_device *rtc;
|
|
struct mc13xxx *mc13xxx;
|
|
int valid;
|
|
};
|
|
|
|
static int mc13xxx_rtc_irq_enable_unlocked(struct device *dev,
|
|
unsigned int enabled, int irq)
|
|
{
|
|
struct mc13xxx_rtc *priv = dev_get_drvdata(dev);
|
|
int (*func)(struct mc13xxx *mc13xxx, int irq);
|
|
|
|
if (!priv->valid)
|
|
return -ENODATA;
|
|
|
|
func = enabled ? mc13xxx_irq_unmask : mc13xxx_irq_mask;
|
|
return func(priv->mc13xxx, irq);
|
|
}
|
|
|
|
static int mc13xxx_rtc_irq_enable(struct device *dev,
|
|
unsigned int enabled, int irq)
|
|
{
|
|
struct mc13xxx_rtc *priv = dev_get_drvdata(dev);
|
|
int ret;
|
|
|
|
mc13xxx_lock(priv->mc13xxx);
|
|
|
|
ret = mc13xxx_rtc_irq_enable_unlocked(dev, enabled, irq);
|
|
|
|
mc13xxx_unlock(priv->mc13xxx);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int mc13xxx_rtc_read_time(struct device *dev, struct rtc_time *tm)
|
|
{
|
|
struct mc13xxx_rtc *priv = dev_get_drvdata(dev);
|
|
unsigned int seconds, days1, days2;
|
|
unsigned long s1970;
|
|
int ret;
|
|
|
|
mc13xxx_lock(priv->mc13xxx);
|
|
|
|
if (!priv->valid) {
|
|
ret = -ENODATA;
|
|
goto out;
|
|
}
|
|
|
|
ret = mc13xxx_reg_read(priv->mc13xxx, MC13XXX_RTCDAY, &days1);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
|
|
ret = mc13xxx_reg_read(priv->mc13xxx, MC13XXX_RTCTOD, &seconds);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
|
|
ret = mc13xxx_reg_read(priv->mc13xxx, MC13XXX_RTCDAY, &days2);
|
|
out:
|
|
mc13xxx_unlock(priv->mc13xxx);
|
|
|
|
if (ret)
|
|
return ret;
|
|
|
|
if (days2 == days1 + 1) {
|
|
if (seconds >= 86400 / 2)
|
|
days2 = days1;
|
|
else
|
|
days1 = days2;
|
|
}
|
|
|
|
if (days1 != days2)
|
|
return -EIO;
|
|
|
|
s1970 = days1 * 86400 + seconds;
|
|
|
|
rtc_time_to_tm(s1970, tm);
|
|
|
|
return rtc_valid_tm(tm);
|
|
}
|
|
|
|
static int mc13xxx_rtc_set_mmss(struct device *dev, unsigned long secs)
|
|
{
|
|
struct mc13xxx_rtc *priv = dev_get_drvdata(dev);
|
|
unsigned int seconds, days;
|
|
unsigned int alarmseconds;
|
|
int ret;
|
|
|
|
seconds = secs % 86400;
|
|
days = secs / 86400;
|
|
|
|
mc13xxx_lock(priv->mc13xxx);
|
|
|
|
/*
|
|
* temporarily invalidate alarm to prevent triggering it when the day is
|
|
* already updated while the time isn't yet.
|
|
*/
|
|
ret = mc13xxx_reg_read(priv->mc13xxx, MC13XXX_RTCTODA, &alarmseconds);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
|
|
if (alarmseconds < 86400) {
|
|
ret = mc13xxx_reg_write(priv->mc13xxx,
|
|
MC13XXX_RTCTODA, 0x1ffff);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
}
|
|
|
|
/*
|
|
* write seconds=0 to prevent a day switch between writing days
|
|
* and seconds below
|
|
*/
|
|
ret = mc13xxx_reg_write(priv->mc13xxx, MC13XXX_RTCTOD, 0);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
|
|
ret = mc13xxx_reg_write(priv->mc13xxx, MC13XXX_RTCDAY, days);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
|
|
ret = mc13xxx_reg_write(priv->mc13xxx, MC13XXX_RTCTOD, seconds);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
|
|
/* restore alarm */
|
|
if (alarmseconds < 86400) {
|
|
ret = mc13xxx_reg_write(priv->mc13xxx,
|
|
MC13XXX_RTCTODA, alarmseconds);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
}
|
|
|
|
ret = mc13xxx_irq_ack(priv->mc13xxx, MC13XXX_IRQ_RTCRST);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
|
|
ret = mc13xxx_irq_unmask(priv->mc13xxx, MC13XXX_IRQ_RTCRST);
|
|
out:
|
|
priv->valid = !ret;
|
|
|
|
mc13xxx_unlock(priv->mc13xxx);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int mc13xxx_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alarm)
|
|
{
|
|
struct mc13xxx_rtc *priv = dev_get_drvdata(dev);
|
|
unsigned seconds, days;
|
|
unsigned long s1970;
|
|
int enabled, pending;
|
|
int ret;
|
|
|
|
mc13xxx_lock(priv->mc13xxx);
|
|
|
|
ret = mc13xxx_reg_read(priv->mc13xxx, MC13XXX_RTCTODA, &seconds);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
if (seconds >= 86400) {
|
|
ret = -ENODATA;
|
|
goto out;
|
|
}
|
|
|
|
ret = mc13xxx_reg_read(priv->mc13xxx, MC13XXX_RTCDAY, &days);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
|
|
ret = mc13xxx_irq_status(priv->mc13xxx, MC13XXX_IRQ_TODA,
|
|
&enabled, &pending);
|
|
|
|
out:
|
|
mc13xxx_unlock(priv->mc13xxx);
|
|
|
|
if (ret)
|
|
return ret;
|
|
|
|
alarm->enabled = enabled;
|
|
alarm->pending = pending;
|
|
|
|
s1970 = days * 86400 + seconds;
|
|
|
|
rtc_time_to_tm(s1970, &alarm->time);
|
|
dev_dbg(dev, "%s: %lu\n", __func__, s1970);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int mc13xxx_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alarm)
|
|
{
|
|
struct mc13xxx_rtc *priv = dev_get_drvdata(dev);
|
|
unsigned long s1970;
|
|
unsigned seconds, days;
|
|
int ret;
|
|
|
|
mc13xxx_lock(priv->mc13xxx);
|
|
|
|
/* disable alarm to prevent false triggering */
|
|
ret = mc13xxx_reg_write(priv->mc13xxx, MC13XXX_RTCTODA, 0x1ffff);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
|
|
ret = mc13xxx_irq_ack(priv->mc13xxx, MC13XXX_IRQ_TODA);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
|
|
ret = rtc_tm_to_time(&alarm->time, &s1970);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
|
|
dev_dbg(dev, "%s: o%2.s %lu\n", __func__, alarm->enabled ? "n" : "ff",
|
|
s1970);
|
|
|
|
ret = mc13xxx_rtc_irq_enable_unlocked(dev, alarm->enabled,
|
|
MC13XXX_IRQ_TODA);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
|
|
seconds = s1970 % 86400;
|
|
days = s1970 / 86400;
|
|
|
|
ret = mc13xxx_reg_write(priv->mc13xxx, MC13XXX_RTCDAYA, days);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
|
|
ret = mc13xxx_reg_write(priv->mc13xxx, MC13XXX_RTCTODA, seconds);
|
|
|
|
out:
|
|
mc13xxx_unlock(priv->mc13xxx);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static irqreturn_t mc13xxx_rtc_alarm_handler(int irq, void *dev)
|
|
{
|
|
struct mc13xxx_rtc *priv = dev;
|
|
struct mc13xxx *mc13xxx = priv->mc13xxx;
|
|
|
|
dev_dbg(&priv->rtc->dev, "Alarm\n");
|
|
|
|
rtc_update_irq(priv->rtc, 1, RTC_IRQF | RTC_AF);
|
|
|
|
mc13xxx_irq_ack(mc13xxx, irq);
|
|
|
|
return IRQ_HANDLED;
|
|
}
|
|
|
|
static irqreturn_t mc13xxx_rtc_update_handler(int irq, void *dev)
|
|
{
|
|
struct mc13xxx_rtc *priv = dev;
|
|
struct mc13xxx *mc13xxx = priv->mc13xxx;
|
|
|
|
dev_dbg(&priv->rtc->dev, "1HZ\n");
|
|
|
|
rtc_update_irq(priv->rtc, 1, RTC_IRQF | RTC_UF);
|
|
|
|
mc13xxx_irq_ack(mc13xxx, irq);
|
|
|
|
return IRQ_HANDLED;
|
|
}
|
|
|
|
static int mc13xxx_rtc_alarm_irq_enable(struct device *dev,
|
|
unsigned int enabled)
|
|
{
|
|
return mc13xxx_rtc_irq_enable(dev, enabled, MC13XXX_IRQ_TODA);
|
|
}
|
|
|
|
static const struct rtc_class_ops mc13xxx_rtc_ops = {
|
|
.read_time = mc13xxx_rtc_read_time,
|
|
.set_mmss = mc13xxx_rtc_set_mmss,
|
|
.read_alarm = mc13xxx_rtc_read_alarm,
|
|
.set_alarm = mc13xxx_rtc_set_alarm,
|
|
.alarm_irq_enable = mc13xxx_rtc_alarm_irq_enable,
|
|
};
|
|
|
|
static irqreturn_t mc13xxx_rtc_reset_handler(int irq, void *dev)
|
|
{
|
|
struct mc13xxx_rtc *priv = dev;
|
|
struct mc13xxx *mc13xxx = priv->mc13xxx;
|
|
|
|
dev_dbg(&priv->rtc->dev, "RTCRST\n");
|
|
priv->valid = 0;
|
|
|
|
mc13xxx_irq_mask(mc13xxx, irq);
|
|
|
|
return IRQ_HANDLED;
|
|
}
|
|
|
|
static int __devinit mc13xxx_rtc_probe(struct platform_device *pdev)
|
|
{
|
|
int ret;
|
|
struct mc13xxx_rtc *priv;
|
|
struct mc13xxx *mc13xxx;
|
|
int rtcrst_pending;
|
|
|
|
priv = kzalloc(sizeof(*priv), GFP_KERNEL);
|
|
if (!priv)
|
|
return -ENOMEM;
|
|
|
|
mc13xxx = dev_get_drvdata(pdev->dev.parent);
|
|
priv->mc13xxx = mc13xxx;
|
|
|
|
platform_set_drvdata(pdev, priv);
|
|
|
|
mc13xxx_lock(mc13xxx);
|
|
|
|
ret = mc13xxx_irq_request(mc13xxx, MC13XXX_IRQ_RTCRST,
|
|
mc13xxx_rtc_reset_handler, DRIVER_NAME, priv);
|
|
if (ret)
|
|
goto err_reset_irq_request;
|
|
|
|
ret = mc13xxx_irq_status(mc13xxx, MC13XXX_IRQ_RTCRST,
|
|
NULL, &rtcrst_pending);
|
|
if (ret)
|
|
goto err_reset_irq_status;
|
|
|
|
priv->valid = !rtcrst_pending;
|
|
|
|
ret = mc13xxx_irq_request_nounmask(mc13xxx, MC13XXX_IRQ_1HZ,
|
|
mc13xxx_rtc_update_handler, DRIVER_NAME, priv);
|
|
if (ret)
|
|
goto err_update_irq_request;
|
|
|
|
ret = mc13xxx_irq_request_nounmask(mc13xxx, MC13XXX_IRQ_TODA,
|
|
mc13xxx_rtc_alarm_handler, DRIVER_NAME, priv);
|
|
if (ret)
|
|
goto err_alarm_irq_request;
|
|
|
|
mc13xxx_unlock(mc13xxx);
|
|
|
|
priv->rtc = rtc_device_register(pdev->name,
|
|
&pdev->dev, &mc13xxx_rtc_ops, THIS_MODULE);
|
|
if (IS_ERR(priv->rtc)) {
|
|
ret = PTR_ERR(priv->rtc);
|
|
|
|
mc13xxx_lock(mc13xxx);
|
|
|
|
mc13xxx_irq_free(mc13xxx, MC13XXX_IRQ_TODA, priv);
|
|
err_alarm_irq_request:
|
|
|
|
mc13xxx_irq_free(mc13xxx, MC13XXX_IRQ_1HZ, priv);
|
|
err_update_irq_request:
|
|
|
|
err_reset_irq_status:
|
|
|
|
mc13xxx_irq_free(mc13xxx, MC13XXX_IRQ_RTCRST, priv);
|
|
err_reset_irq_request:
|
|
|
|
mc13xxx_unlock(mc13xxx);
|
|
|
|
platform_set_drvdata(pdev, NULL);
|
|
kfree(priv);
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int __devexit mc13xxx_rtc_remove(struct platform_device *pdev)
|
|
{
|
|
struct mc13xxx_rtc *priv = platform_get_drvdata(pdev);
|
|
|
|
mc13xxx_lock(priv->mc13xxx);
|
|
|
|
rtc_device_unregister(priv->rtc);
|
|
|
|
mc13xxx_irq_free(priv->mc13xxx, MC13XXX_IRQ_TODA, priv);
|
|
mc13xxx_irq_free(priv->mc13xxx, MC13XXX_IRQ_1HZ, priv);
|
|
mc13xxx_irq_free(priv->mc13xxx, MC13XXX_IRQ_RTCRST, priv);
|
|
|
|
mc13xxx_unlock(priv->mc13xxx);
|
|
|
|
platform_set_drvdata(pdev, NULL);
|
|
|
|
kfree(priv);
|
|
|
|
return 0;
|
|
}
|
|
|
|
const struct platform_device_id mc13xxx_rtc_idtable[] = {
|
|
{
|
|
.name = "mc13783-rtc",
|
|
}, {
|
|
.name = "mc13892-rtc",
|
|
},
|
|
{ }
|
|
};
|
|
|
|
static struct platform_driver mc13xxx_rtc_driver = {
|
|
.id_table = mc13xxx_rtc_idtable,
|
|
.remove = __devexit_p(mc13xxx_rtc_remove),
|
|
.driver = {
|
|
.name = DRIVER_NAME,
|
|
.owner = THIS_MODULE,
|
|
},
|
|
};
|
|
|
|
static int __init mc13xxx_rtc_init(void)
|
|
{
|
|
return platform_driver_probe(&mc13xxx_rtc_driver, &mc13xxx_rtc_probe);
|
|
}
|
|
module_init(mc13xxx_rtc_init);
|
|
|
|
static void __exit mc13xxx_rtc_exit(void)
|
|
{
|
|
platform_driver_unregister(&mc13xxx_rtc_driver);
|
|
}
|
|
module_exit(mc13xxx_rtc_exit);
|
|
|
|
MODULE_AUTHOR("Sascha Hauer <s.hauer@pengutronix.de>");
|
|
MODULE_DESCRIPTION("RTC driver for Freescale MC13XXX PMIC");
|
|
MODULE_LICENSE("GPL v2");
|
|
MODULE_ALIAS("platform:" DRIVER_NAME);
|