q3k
/
linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
linux/drivers/char/ipmi
History
Ingo Molnar 27d0567ab6 ACPI: fix ACPI=n allmodconfig build 
Today's -tip failed to build because commit
9e368fa011 ("ipmi: add PNP discovery (ACPI
namespace via PNPACPI)") from today's upstream kernel causes the following
build failure on x86, for CONFIG_ACPI=n && CONFIG_IPMI_SI=y:

 drivers/char/ipmi/ipmi_si_intf.c:3208: error: 'ipmi_pnp_driver' undeclared (first use in this function)
 drivers/char/ipmi/ipmi_si_intf.c:3208: error: (Each undeclared identifier is reported only once
 drivers/char/ipmi/ipmi_si_intf.c:3208: error: for each function it appears in.)
 drivers/char/ipmi/ipmi_si_intf.c:3334: error: 'ipmi_pnp_driver' undeclared (first use in this function)

The reason is that the ipmi_pnp_driver depends on ACPI facilities and is only
made available under ACPI - while the registration and unregistration is made
dependent on CONFIG_PNP:

 #ifdef CONFIG_PNP
 	pnp_register_driver(&ipmi_pnp_driver);
 #endif

The solution is to only register this driver under ACPI. (Also, the CONFIG_PNP
dependency is not needed because pnp_register_driver() is stubbed out in the
!CONFIG_PNP case.)

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Acked-by: Myron Stowe <myron.stowe@hp.com>
Signed-off-by: Len Brown <len.brown@intel.com>
 		2009-12-30 01:24:25 -05:00
..
Kconfig Use menuconfig objects II - IPMI 2007-07-16 09:05:40 -07:00
Makefile ipmi: remove unused target and action in Makefile 2008-04-29 08:06:15 -07:00
ipmi_bt_sm.c IPMI: Style fixes in the system interface code 2008-04-29 08:06:15 -07:00
ipmi_devintf.c headers: remove sched.h from poll.h 2009-10-04 15:05:10 -07:00
ipmi_kcs_sm.c drivers/char/ipmi: Use KCS_IDLE_STATE 2009-12-16 07:20:10 -08:00
ipmi_msghandler.c headers: remove sched.h from poll.h 2009-10-04 15:05:10 -07:00
ipmi_poweroff.c sysctl: Drop & in front of every proc_handler. 2009-11-18 08:37:40 -08:00
ipmi_si_intf.c ACPI: fix ACPI=n allmodconfig build 2009-12-30 01:24:25 -05:00
ipmi_si_sm.h IPMI: Style fixes in the system interface code 2008-04-29 08:06:15 -07:00
ipmi_smic_sm.c IPMI: Style fixes in the system interface code 2008-04-29 08:06:15 -07:00
ipmi_watchdog.c saner FASYNC handling on file close 2008-11-01 09:49:46 -07:00