linux/drivers/video/via
Alexey Dobriyan 99b7623380 proc 2/2: remove struct proc_dir_entry::owner
Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy
as correctly noted at bug #12454. Someone can lookup entry with NULL
->owner, thus not pinning enything, and release it later resulting
in module refcount underflow.

We can keep ->owner and supply it at registration time like ->proc_fops
and ->data.

But this leaves ->owner as easy-manipulative field (just one C assignment)
and somebody will forget to unpin previous/pin current module when
switching ->owner. ->proc_fops is declared as "const" which should give
some thoughts.

->read_proc/->write_proc were just fixed to not require ->owner for
protection.

rmmod'ed directories will be empty and return "." and ".." -- no harm.
And directories with tricky enough readdir and lookup shouldn't be modular.
We definitely don't want such modular code.

Removing ->owner will also make PDE smaller.

So, let's nuke it.

Kudos to Jeff Layton for reminding about this, let's say, oversight.

http://bugzilla.kernel.org/show_bug.cgi?id=12454

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
2009-03-31 01:14:44 +04:00
..
accel.c
accel.h
chip.h
debug.h
dvi.c viafb: dvi.c, dvi.h, global.c and global.h 2008-10-16 11:21:41 -07:00
dvi.h viafb: dvi.c, dvi.h, global.c and global.h 2008-10-16 11:21:41 -07:00
global.c viafb: dvi.c, dvi.h, global.c and global.h 2008-10-16 11:21:41 -07:00
global.h viafb: removed duplicated #include's 2008-10-30 11:38:45 -07:00
hw.c viafb: hw.c, hw.h 2008-10-16 11:21:41 -07:00
hw.h viafb: hw.c, hw.h 2008-10-16 11:21:41 -07:00
iface.c viafb: iface.c, iface.h, ioctl.c, ioctl.h 2008-10-16 11:21:41 -07:00
iface.h viafb: iface.c, iface.h, ioctl.c, ioctl.h 2008-10-16 11:21:41 -07:00
ioctl.c viafb: iface.c, iface.h, ioctl.c, ioctl.h 2008-10-16 11:21:41 -07:00
ioctl.h viafb: iface.c, iface.h, ioctl.c, ioctl.h 2008-10-16 11:21:41 -07:00
lcd.c viafb: lcd.c, lcd.h, lcdtbl.h 2008-10-16 11:21:41 -07:00
lcd.h viafb: lcd.c, lcd.h, lcdtbl.h 2008-10-16 11:21:41 -07:00
lcdtbl.h viafb: lcd.c, lcd.h, lcdtbl.h 2008-10-16 11:21:41 -07:00
Makefile viafb: Makefile, share.h 2008-10-16 11:21:41 -07:00
share.h viafb: Makefile, share.h 2008-10-16 11:21:41 -07:00
tbl1636.c viafb: tbl1636.c, tbl1636.h, tblDPASetting.c, tblDPASetting.h 2008-10-16 11:21:41 -07:00
tbl1636.h viafb: tbl1636.c, tbl1636.h, tblDPASetting.c, tblDPASetting.h 2008-10-16 11:21:41 -07:00
tblDPASetting.c viafb: tbl1636.c, tbl1636.h, tblDPASetting.c, tblDPASetting.h 2008-10-16 11:21:41 -07:00
tblDPASetting.h viafb: tbl1636.c, tbl1636.h, tblDPASetting.c, tblDPASetting.h 2008-10-16 11:21:41 -07:00
via_i2c.c viafb: via_i2c.c, via_i2c.h, viamode.c, viamode.h 2008-10-16 11:21:42 -07:00
via_i2c.h viafb: via_i2c.c, via_i2c.h, viamode.c, viamode.h 2008-10-16 11:21:42 -07:00
via_utility.c viafb: via_utility.c, via_utility.h, vt1636.c, vt1636.h 2008-10-16 11:21:42 -07:00
via_utility.h viafb: via_utility.c, via_utility.h, vt1636.c, vt1636.h 2008-10-16 11:21:42 -07:00
viafbdev.c proc 2/2: remove struct proc_dir_entry::owner 2009-03-31 01:14:44 +04:00
viafbdev.h viafb: viafbdev.c, viafbdev.h 2008-10-16 11:21:41 -07:00
viamode.c viafb: via_i2c.c, via_i2c.h, viamode.c, viamode.h 2008-10-16 11:21:42 -07:00
viamode.h viafb: via_i2c.c, via_i2c.h, viamode.c, viamode.h 2008-10-16 11:21:42 -07:00
vt1636.c viafb: via_utility.c, via_utility.h, vt1636.c, vt1636.h 2008-10-16 11:21:42 -07:00
vt1636.h viafb: via_utility.c, via_utility.h, vt1636.c, vt1636.h 2008-10-16 11:21:42 -07:00