2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* linux/fs/nfs/write.c
|
|
|
|
*
|
2006-12-13 20:23:48 +00:00
|
|
|
* Write file data over NFS.
|
2005-04-16 22:20:36 +00:00
|
|
|
*
|
|
|
|
* Copyright (C) 1996, 1997, Olaf Kirch <okir@monad.swb.de>
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/types.h>
|
|
|
|
#include <linux/slab.h>
|
|
|
|
#include <linux/mm.h>
|
|
|
|
#include <linux/pagemap.h>
|
|
|
|
#include <linux/file.h>
|
|
|
|
#include <linux/writeback.h>
|
2007-03-16 21:38:26 +00:00
|
|
|
#include <linux/swap.h>
|
2009-08-10 12:54:13 +00:00
|
|
|
#include <linux/migrate.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
#include <linux/sunrpc/clnt.h>
|
|
|
|
#include <linux/nfs_fs.h>
|
|
|
|
#include <linux/nfs_mount.h>
|
|
|
|
#include <linux/nfs_page.h>
|
2006-10-20 06:28:16 +00:00
|
|
|
#include <linux/backing-dev.h>
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
#include <asm/uaccess.h>
|
|
|
|
|
|
|
|
#include "delegation.h"
|
2006-12-05 05:35:38 +00:00
|
|
|
#include "internal.h"
|
2006-03-20 18:44:14 +00:00
|
|
|
#include "iostat.h"
|
2009-04-01 13:22:26 +00:00
|
|
|
#include "nfs4_fs.h"
|
2009-08-10 12:54:13 +00:00
|
|
|
#include "fscache.h"
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
#define NFSDBG_FACILITY NFSDBG_PAGECACHE
|
|
|
|
|
|
|
|
#define MIN_POOL_WRITE (32)
|
|
|
|
#define MIN_POOL_COMMIT (4)
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Local function declarations
|
|
|
|
*/
|
2007-04-02 23:29:52 +00:00
|
|
|
static void nfs_pageio_init_write(struct nfs_pageio_descriptor *desc,
|
|
|
|
struct inode *inode, int ioflags);
|
nfs: don't ignore return value from nfs_pageio_add_request
Ignoring the return value from nfs_pageio_add_request can cause deadlocks.
In read path:
call nfs_pageio_add_request from readpage_async_filler
assume at this point that there are requests already in desc, that
can't be merged with the current request.
so nfs_pageio_doio is fired up to clear out desc.
assume something goes wrong in setting up the io, so desc->pg_error is set.
This causes nfs_pageio_add_request to return 0, *WITHOUT* adding the original
request.
BUT, since return code is ignored, readpage_async_filler assumes it has
been added, and does nothing further, leaving page locked.
do_generic_mapping_read will eventually call lock_page, resulting in deadlock
In write path:
page is marked dirty by generic_perform_write
nfs_writepages is called
call nfs_pageio_add_request from nfs_page_async_flush
assume at this point that there are requests already in desc, that
can't be merged with the current request.
so nfs_pageio_doio is fired up to clear out desc.
assume something goes wrong in setting up the io, so desc->pg_error is set.
This causes nfs_page_async_flush to return 0, *WITHOUT* adding the original
request, yet marking the request as locked (PG_BUSY) and in writeback,
clearing dirty marks.
The next time a write is done to the page, deadlock will result as
nfs_write_end calls nfs_update_request
Signed-off-by: Fred Isaman <iisaman@citi.umich.edu>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
2008-03-19 15:24:39 +00:00
|
|
|
static void nfs_redirty_request(struct nfs_page *req);
|
2006-03-20 18:44:27 +00:00
|
|
|
static const struct rpc_call_ops nfs_write_partial_ops;
|
|
|
|
static const struct rpc_call_ops nfs_write_full_ops;
|
|
|
|
static const struct rpc_call_ops nfs_commit_ops;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2006-12-07 04:33:20 +00:00
|
|
|
static struct kmem_cache *nfs_wdata_cachep;
|
2006-03-20 18:44:37 +00:00
|
|
|
static mempool_t *nfs_wdata_mempool;
|
2005-04-16 22:20:36 +00:00
|
|
|
static mempool_t *nfs_commit_mempool;
|
|
|
|
|
2008-04-15 20:56:39 +00:00
|
|
|
struct nfs_write_data *nfs_commitdata_alloc(void)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2006-12-07 04:33:14 +00:00
|
|
|
struct nfs_write_data *p = mempool_alloc(nfs_commit_mempool, GFP_NOFS);
|
2005-11-30 23:09:02 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
if (p) {
|
|
|
|
memset(p, 0, sizeof(*p));
|
|
|
|
INIT_LIST_HEAD(&p->pages);
|
|
|
|
}
|
|
|
|
return p;
|
|
|
|
}
|
|
|
|
|
2008-02-26 05:53:49 +00:00
|
|
|
void nfs_commit_free(struct nfs_write_data *p)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2005-11-30 23:09:02 +00:00
|
|
|
if (p && (p->pagevec != &p->page_array[0]))
|
|
|
|
kfree(p->pagevec);
|
2005-04-16 22:20:36 +00:00
|
|
|
mempool_free(p, nfs_commit_mempool);
|
|
|
|
}
|
|
|
|
|
2007-04-10 13:26:35 +00:00
|
|
|
struct nfs_write_data *nfs_writedata_alloc(unsigned int pagecount)
|
2006-03-20 18:44:37 +00:00
|
|
|
{
|
2006-12-07 04:33:14 +00:00
|
|
|
struct nfs_write_data *p = mempool_alloc(nfs_wdata_mempool, GFP_NOFS);
|
2006-03-20 18:44:37 +00:00
|
|
|
|
|
|
|
if (p) {
|
|
|
|
memset(p, 0, sizeof(*p));
|
|
|
|
INIT_LIST_HEAD(&p->pages);
|
2006-09-08 16:48:54 +00:00
|
|
|
p->npages = pagecount;
|
2006-05-25 05:40:53 +00:00
|
|
|
if (pagecount <= ARRAY_SIZE(p->page_array))
|
|
|
|
p->pagevec = p->page_array;
|
2006-03-20 18:44:37 +00:00
|
|
|
else {
|
2006-05-25 05:40:53 +00:00
|
|
|
p->pagevec = kcalloc(pagecount, sizeof(struct page *), GFP_NOFS);
|
|
|
|
if (!p->pagevec) {
|
2006-03-20 18:44:37 +00:00
|
|
|
mempool_free(p, nfs_wdata_mempool);
|
|
|
|
p = NULL;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return p;
|
|
|
|
}
|
|
|
|
|
2009-08-12 13:12:30 +00:00
|
|
|
void nfs_writedata_free(struct nfs_write_data *p)
|
2006-03-20 18:44:37 +00:00
|
|
|
{
|
|
|
|
if (p && (p->pagevec != &p->page_array[0]))
|
|
|
|
kfree(p->pagevec);
|
|
|
|
mempool_free(p, nfs_wdata_mempool);
|
|
|
|
}
|
|
|
|
|
2009-08-12 13:12:30 +00:00
|
|
|
static void nfs_writedata_release(struct nfs_write_data *wdata)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2008-02-20 01:04:20 +00:00
|
|
|
put_nfs_open_context(wdata->args.context);
|
2005-04-16 22:20:36 +00:00
|
|
|
nfs_writedata_free(wdata);
|
|
|
|
}
|
|
|
|
|
2007-07-25 18:09:54 +00:00
|
|
|
static void nfs_context_set_write_error(struct nfs_open_context *ctx, int error)
|
|
|
|
{
|
|
|
|
ctx->error = error;
|
|
|
|
smp_wmb();
|
|
|
|
set_bit(NFS_CONTEXT_ERROR_WRITE, &ctx->flags);
|
|
|
|
}
|
|
|
|
|
2006-12-05 05:35:35 +00:00
|
|
|
static struct nfs_page *nfs_page_find_request_locked(struct page *page)
|
|
|
|
{
|
|
|
|
struct nfs_page *req = NULL;
|
|
|
|
|
|
|
|
if (PagePrivate(page)) {
|
|
|
|
req = (struct nfs_page *)page_private(page);
|
|
|
|
if (req != NULL)
|
2007-06-17 17:26:38 +00:00
|
|
|
kref_get(&req->wb_kref);
|
2006-12-05 05:35:35 +00:00
|
|
|
}
|
|
|
|
return req;
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct nfs_page *nfs_page_find_request(struct page *page)
|
|
|
|
{
|
2007-07-02 13:57:54 +00:00
|
|
|
struct inode *inode = page->mapping->host;
|
2006-12-05 05:35:35 +00:00
|
|
|
struct nfs_page *req = NULL;
|
|
|
|
|
2007-07-02 13:57:54 +00:00
|
|
|
spin_lock(&inode->i_lock);
|
2006-12-05 05:35:35 +00:00
|
|
|
req = nfs_page_find_request_locked(page);
|
2007-07-02 13:57:54 +00:00
|
|
|
spin_unlock(&inode->i_lock);
|
2006-12-05 05:35:35 +00:00
|
|
|
return req;
|
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/* Adjust the file length if we're writing beyond the end */
|
|
|
|
static void nfs_grow_file(struct page *page, unsigned int offset, unsigned int count)
|
|
|
|
{
|
|
|
|
struct inode *inode = page->mapping->host;
|
2008-06-11 16:21:19 +00:00
|
|
|
loff_t end, i_size;
|
|
|
|
pgoff_t end_index;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-06-11 16:21:19 +00:00
|
|
|
spin_lock(&inode->i_lock);
|
|
|
|
i_size = i_size_read(inode);
|
|
|
|
end_index = (i_size - 1) >> PAGE_CACHE_SHIFT;
|
2005-04-16 22:20:36 +00:00
|
|
|
if (i_size > 0 && page->index < end_index)
|
2008-06-11 16:21:19 +00:00
|
|
|
goto out;
|
2005-04-16 22:20:36 +00:00
|
|
|
end = ((loff_t)page->index << PAGE_CACHE_SHIFT) + ((loff_t)offset+count);
|
|
|
|
if (i_size >= end)
|
2008-06-11 16:21:19 +00:00
|
|
|
goto out;
|
2005-04-16 22:20:36 +00:00
|
|
|
i_size_write(inode, end);
|
2008-06-11 16:21:19 +00:00
|
|
|
nfs_inc_stats(inode, NFSIOS_EXTENDWRITE);
|
|
|
|
out:
|
|
|
|
spin_unlock(&inode->i_lock);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2007-02-06 19:07:15 +00:00
|
|
|
/* A writeback failed: mark the page as bad, and invalidate the page cache */
|
|
|
|
static void nfs_set_pageerror(struct page *page)
|
|
|
|
{
|
|
|
|
SetPageError(page);
|
|
|
|
nfs_zap_mapping(page->mapping->host, page->mapping);
|
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/* We can set the PG_uptodate flag if we see that a write request
|
|
|
|
* covers the full page.
|
|
|
|
*/
|
|
|
|
static void nfs_mark_uptodate(struct page *page, unsigned int base, unsigned int count)
|
|
|
|
{
|
|
|
|
if (PageUptodate(page))
|
|
|
|
return;
|
|
|
|
if (base != 0)
|
|
|
|
return;
|
2006-12-05 05:35:38 +00:00
|
|
|
if (count != nfs_page_length(page))
|
2005-04-16 22:20:36 +00:00
|
|
|
return;
|
2006-12-05 05:35:38 +00:00
|
|
|
SetPageUptodate(page);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static int wb_priority(struct writeback_control *wbc)
|
|
|
|
{
|
|
|
|
if (wbc->for_reclaim)
|
2007-04-02 23:29:52 +00:00
|
|
|
return FLUSH_HIGHPRI | FLUSH_STABLE;
|
2009-12-03 12:54:25 +00:00
|
|
|
if (wbc->for_kupdate || wbc->for_background)
|
2005-04-16 22:20:36 +00:00
|
|
|
return FLUSH_LOWPRI;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2007-03-16 21:38:26 +00:00
|
|
|
/*
|
|
|
|
* NFS congestion control
|
|
|
|
*/
|
|
|
|
|
|
|
|
int nfs_congestion_kb;
|
|
|
|
|
|
|
|
#define NFS_CONGESTION_ON_THRESH (nfs_congestion_kb >> (PAGE_SHIFT-10))
|
|
|
|
#define NFS_CONGESTION_OFF_THRESH \
|
|
|
|
(NFS_CONGESTION_ON_THRESH - (NFS_CONGESTION_ON_THRESH >> 2))
|
|
|
|
|
2007-04-14 23:10:12 +00:00
|
|
|
static int nfs_set_page_writeback(struct page *page)
|
2007-03-16 21:38:26 +00:00
|
|
|
{
|
2007-04-14 23:10:12 +00:00
|
|
|
int ret = test_set_page_writeback(page);
|
|
|
|
|
|
|
|
if (!ret) {
|
2007-03-16 21:38:26 +00:00
|
|
|
struct inode *inode = page->mapping->host;
|
|
|
|
struct nfs_server *nfss = NFS_SERVER(inode);
|
|
|
|
|
2010-04-09 23:07:08 +00:00
|
|
|
page_cache_get(page);
|
2007-05-08 07:35:12 +00:00
|
|
|
if (atomic_long_inc_return(&nfss->writeback) >
|
2009-07-09 12:52:32 +00:00
|
|
|
NFS_CONGESTION_ON_THRESH) {
|
|
|
|
set_bdi_congested(&nfss->backing_dev_info,
|
|
|
|
BLK_RW_ASYNC);
|
|
|
|
}
|
2007-03-16 21:38:26 +00:00
|
|
|
}
|
2007-04-14 23:10:12 +00:00
|
|
|
return ret;
|
2007-03-16 21:38:26 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void nfs_end_page_writeback(struct page *page)
|
|
|
|
{
|
|
|
|
struct inode *inode = page->mapping->host;
|
|
|
|
struct nfs_server *nfss = NFS_SERVER(inode);
|
|
|
|
|
|
|
|
end_page_writeback(page);
|
2010-04-09 23:07:08 +00:00
|
|
|
page_cache_release(page);
|
2007-10-17 06:25:41 +00:00
|
|
|
if (atomic_long_dec_return(&nfss->writeback) < NFS_CONGESTION_OFF_THRESH)
|
2009-07-09 12:52:32 +00:00
|
|
|
clear_bdi_congested(&nfss->backing_dev_info, BLK_RW_ASYNC);
|
2007-03-16 21:38:26 +00:00
|
|
|
}
|
|
|
|
|
2010-07-30 19:31:57 +00:00
|
|
|
static struct nfs_page *nfs_find_and_lock_request(struct page *page, bool nonblock)
|
2006-12-05 05:35:41 +00:00
|
|
|
{
|
2007-07-02 13:57:54 +00:00
|
|
|
struct inode *inode = page->mapping->host;
|
2006-12-05 05:35:41 +00:00
|
|
|
struct nfs_page *req;
|
|
|
|
int ret;
|
|
|
|
|
2007-07-02 13:57:54 +00:00
|
|
|
spin_lock(&inode->i_lock);
|
2009-08-10 12:54:13 +00:00
|
|
|
for (;;) {
|
2006-12-05 05:35:41 +00:00
|
|
|
req = nfs_page_find_request_locked(page);
|
2009-08-10 12:54:13 +00:00
|
|
|
if (req == NULL)
|
|
|
|
break;
|
2008-01-22 22:13:07 +00:00
|
|
|
if (nfs_set_page_tag_locked(req))
|
2006-12-05 05:35:41 +00:00
|
|
|
break;
|
|
|
|
/* Note: If we hold the page lock, as is the case in nfs_writepage,
|
2008-01-22 22:13:07 +00:00
|
|
|
* then the call to nfs_set_page_tag_locked() will always
|
2006-12-05 05:35:41 +00:00
|
|
|
* succeed provided that someone hasn't already marked the
|
|
|
|
* request as dirty (in which case we don't care).
|
|
|
|
*/
|
2007-07-02 13:57:54 +00:00
|
|
|
spin_unlock(&inode->i_lock);
|
2010-07-30 19:31:57 +00:00
|
|
|
if (!nonblock)
|
|
|
|
ret = nfs_wait_on_request(req);
|
|
|
|
else
|
|
|
|
ret = -EAGAIN;
|
2006-12-05 05:35:41 +00:00
|
|
|
nfs_release_request(req);
|
|
|
|
if (ret != 0)
|
2009-08-10 12:54:13 +00:00
|
|
|
return ERR_PTR(ret);
|
2007-07-02 13:57:54 +00:00
|
|
|
spin_lock(&inode->i_lock);
|
2006-12-05 05:35:41 +00:00
|
|
|
}
|
2007-07-02 13:57:54 +00:00
|
|
|
spin_unlock(&inode->i_lock);
|
2009-08-10 12:54:13 +00:00
|
|
|
return req;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Find an associated nfs write request, and prepare to flush it out
|
|
|
|
* May return an error if the user signalled nfs_wait_on_request().
|
|
|
|
*/
|
|
|
|
static int nfs_page_async_flush(struct nfs_pageio_descriptor *pgio,
|
2010-07-30 19:31:57 +00:00
|
|
|
struct page *page, bool nonblock)
|
2009-08-10 12:54:13 +00:00
|
|
|
{
|
|
|
|
struct nfs_page *req;
|
|
|
|
int ret = 0;
|
|
|
|
|
2010-07-30 19:31:57 +00:00
|
|
|
req = nfs_find_and_lock_request(page, nonblock);
|
2009-08-10 12:54:13 +00:00
|
|
|
if (!req)
|
|
|
|
goto out;
|
|
|
|
ret = PTR_ERR(req);
|
|
|
|
if (IS_ERR(req))
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
ret = nfs_set_page_writeback(page);
|
|
|
|
BUG_ON(ret != 0);
|
|
|
|
BUG_ON(test_bit(PG_CLEAN, &req->wb_flags));
|
|
|
|
|
nfs: don't ignore return value from nfs_pageio_add_request
Ignoring the return value from nfs_pageio_add_request can cause deadlocks.
In read path:
call nfs_pageio_add_request from readpage_async_filler
assume at this point that there are requests already in desc, that
can't be merged with the current request.
so nfs_pageio_doio is fired up to clear out desc.
assume something goes wrong in setting up the io, so desc->pg_error is set.
This causes nfs_pageio_add_request to return 0, *WITHOUT* adding the original
request.
BUT, since return code is ignored, readpage_async_filler assumes it has
been added, and does nothing further, leaving page locked.
do_generic_mapping_read will eventually call lock_page, resulting in deadlock
In write path:
page is marked dirty by generic_perform_write
nfs_writepages is called
call nfs_pageio_add_request from nfs_page_async_flush
assume at this point that there are requests already in desc, that
can't be merged with the current request.
so nfs_pageio_doio is fired up to clear out desc.
assume something goes wrong in setting up the io, so desc->pg_error is set.
This causes nfs_page_async_flush to return 0, *WITHOUT* adding the original
request, yet marking the request as locked (PG_BUSY) and in writeback,
clearing dirty marks.
The next time a write is done to the page, deadlock will result as
nfs_write_end calls nfs_update_request
Signed-off-by: Fred Isaman <iisaman@citi.umich.edu>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
2008-03-19 15:24:39 +00:00
|
|
|
if (!nfs_pageio_add_request(pgio, req)) {
|
|
|
|
nfs_redirty_request(req);
|
2009-08-10 12:54:13 +00:00
|
|
|
ret = pgio->pg_error;
|
nfs: don't ignore return value from nfs_pageio_add_request
Ignoring the return value from nfs_pageio_add_request can cause deadlocks.
In read path:
call nfs_pageio_add_request from readpage_async_filler
assume at this point that there are requests already in desc, that
can't be merged with the current request.
so nfs_pageio_doio is fired up to clear out desc.
assume something goes wrong in setting up the io, so desc->pg_error is set.
This causes nfs_pageio_add_request to return 0, *WITHOUT* adding the original
request.
BUT, since return code is ignored, readpage_async_filler assumes it has
been added, and does nothing further, leaving page locked.
do_generic_mapping_read will eventually call lock_page, resulting in deadlock
In write path:
page is marked dirty by generic_perform_write
nfs_writepages is called
call nfs_pageio_add_request from nfs_page_async_flush
assume at this point that there are requests already in desc, that
can't be merged with the current request.
so nfs_pageio_doio is fired up to clear out desc.
assume something goes wrong in setting up the io, so desc->pg_error is set.
This causes nfs_page_async_flush to return 0, *WITHOUT* adding the original
request, yet marking the request as locked (PG_BUSY) and in writeback,
clearing dirty marks.
The next time a write is done to the page, deadlock will result as
nfs_write_end calls nfs_update_request
Signed-off-by: Fred Isaman <iisaman@citi.umich.edu>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
2008-03-19 15:24:39 +00:00
|
|
|
}
|
2009-08-10 12:54:13 +00:00
|
|
|
out:
|
|
|
|
return ret;
|
2006-12-05 05:35:41 +00:00
|
|
|
}
|
|
|
|
|
2007-07-22 23:27:32 +00:00
|
|
|
static int nfs_do_writepage(struct page *page, struct writeback_control *wbc, struct nfs_pageio_descriptor *pgio)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct inode *inode = page->mapping->host;
|
2010-07-30 19:31:57 +00:00
|
|
|
int ret;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2006-03-20 18:44:14 +00:00
|
|
|
nfs_inc_stats(inode, NFSIOS_VFSWRITEPAGE);
|
|
|
|
nfs_add_stats(inode, NFSIOS_WRITEPAGES, 1);
|
|
|
|
|
2007-05-20 14:18:27 +00:00
|
|
|
nfs_pageio_cond_complete(pgio, page->index);
|
2010-10-26 21:21:26 +00:00
|
|
|
ret = nfs_page_async_flush(pgio, page, wbc->sync_mode == WB_SYNC_NONE);
|
2010-07-30 19:31:57 +00:00
|
|
|
if (ret == -EAGAIN) {
|
|
|
|
redirty_page_for_writepage(wbc, page);
|
|
|
|
ret = 0;
|
|
|
|
}
|
|
|
|
return ret;
|
2007-07-22 23:27:32 +00:00
|
|
|
}
|
2007-05-20 14:18:27 +00:00
|
|
|
|
2007-07-22 23:27:32 +00:00
|
|
|
/*
|
|
|
|
* Write an mmapped page to the server.
|
|
|
|
*/
|
|
|
|
static int nfs_writepage_locked(struct page *page, struct writeback_control *wbc)
|
|
|
|
{
|
|
|
|
struct nfs_pageio_descriptor pgio;
|
|
|
|
int err;
|
2006-12-05 05:35:38 +00:00
|
|
|
|
2007-07-22 23:27:32 +00:00
|
|
|
nfs_pageio_init_write(&pgio, page->mapping->host, wb_priority(wbc));
|
|
|
|
err = nfs_do_writepage(page, wbc, &pgio);
|
|
|
|
nfs_pageio_complete(&pgio);
|
|
|
|
if (err < 0)
|
|
|
|
return err;
|
|
|
|
if (pgio.pg_error < 0)
|
|
|
|
return pgio.pg_error;
|
|
|
|
return 0;
|
2006-12-05 05:35:41 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
int nfs_writepage(struct page *page, struct writeback_control *wbc)
|
|
|
|
{
|
2007-07-22 23:27:32 +00:00
|
|
|
int ret;
|
2006-12-05 05:35:41 +00:00
|
|
|
|
2007-07-22 23:27:32 +00:00
|
|
|
ret = nfs_writepage_locked(page, wbc);
|
2005-04-16 22:20:36 +00:00
|
|
|
unlock_page(page);
|
2007-07-22 23:27:32 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int nfs_writepages_callback(struct page *page, struct writeback_control *wbc, void *data)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = nfs_do_writepage(page, wbc, data);
|
|
|
|
unlock_page(page);
|
|
|
|
return ret;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
int nfs_writepages(struct address_space *mapping, struct writeback_control *wbc)
|
|
|
|
{
|
|
|
|
struct inode *inode = mapping->host;
|
2009-03-11 18:10:30 +00:00
|
|
|
unsigned long *bitlock = &NFS_I(inode)->flags;
|
2007-04-02 23:29:52 +00:00
|
|
|
struct nfs_pageio_descriptor pgio;
|
2005-04-16 22:20:36 +00:00
|
|
|
int err;
|
|
|
|
|
2009-03-11 18:10:30 +00:00
|
|
|
/* Stop dirtying of new pages while we sync */
|
|
|
|
err = wait_on_bit_lock(bitlock, NFS_INO_FLUSHING,
|
|
|
|
nfs_wait_bit_killable, TASK_KILLABLE);
|
|
|
|
if (err)
|
|
|
|
goto out_err;
|
|
|
|
|
2006-03-20 18:44:14 +00:00
|
|
|
nfs_inc_stats(inode, NFSIOS_VFSWRITEPAGES);
|
|
|
|
|
2007-04-02 23:29:52 +00:00
|
|
|
nfs_pageio_init_write(&pgio, inode, wb_priority(wbc));
|
2007-07-22 23:27:32 +00:00
|
|
|
err = write_cache_pages(mapping, wbc, nfs_writepages_callback, &pgio);
|
2007-04-02 23:29:52 +00:00
|
|
|
nfs_pageio_complete(&pgio);
|
2009-03-11 18:10:30 +00:00
|
|
|
|
|
|
|
clear_bit_unlock(NFS_INO_FLUSHING, bitlock);
|
|
|
|
smp_mb__after_clear_bit();
|
|
|
|
wake_up_bit(bitlock, NFS_INO_FLUSHING);
|
|
|
|
|
2007-07-22 23:27:32 +00:00
|
|
|
if (err < 0)
|
2009-03-11 18:10:30 +00:00
|
|
|
goto out_err;
|
|
|
|
err = pgio.pg_error;
|
|
|
|
if (err < 0)
|
|
|
|
goto out_err;
|
2007-04-02 23:29:52 +00:00
|
|
|
return 0;
|
2009-03-11 18:10:30 +00:00
|
|
|
out_err:
|
|
|
|
return err;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Insert a write request into an inode
|
|
|
|
*/
|
2008-06-13 16:12:32 +00:00
|
|
|
static int nfs_inode_add_request(struct inode *inode, struct nfs_page *req)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct nfs_inode *nfsi = NFS_I(inode);
|
|
|
|
int error;
|
|
|
|
|
2008-06-13 16:12:32 +00:00
|
|
|
error = radix_tree_preload(GFP_NOFS);
|
|
|
|
if (error != 0)
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
/* Lock the request! */
|
|
|
|
nfs_lock_request_dontget(req);
|
|
|
|
|
|
|
|
spin_lock(&inode->i_lock);
|
2005-04-16 22:20:36 +00:00
|
|
|
error = radix_tree_insert(&nfsi->nfs_page_tree, req->wb_index, req);
|
2008-02-05 07:48:37 +00:00
|
|
|
BUG_ON(error);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (!nfsi->npages) {
|
|
|
|
igrab(inode);
|
|
|
|
if (nfs_have_delegation(inode, FMODE_WRITE))
|
|
|
|
nfsi->change_attr++;
|
|
|
|
}
|
2010-12-08 03:39:17 +00:00
|
|
|
set_bit(PG_MAPPED, &req->wb_flags);
|
2006-03-20 18:44:50 +00:00
|
|
|
SetPagePrivate(req->wb_page);
|
2006-12-05 05:35:35 +00:00
|
|
|
set_page_private(req->wb_page, (unsigned long)req);
|
2005-04-16 22:20:36 +00:00
|
|
|
nfsi->npages++;
|
2007-06-17 17:26:38 +00:00
|
|
|
kref_get(&req->wb_kref);
|
2008-02-05 07:48:37 +00:00
|
|
|
radix_tree_tag_set(&nfsi->nfs_page_tree, req->wb_index,
|
|
|
|
NFS_PAGE_TAG_LOCKED);
|
2008-06-13 16:12:32 +00:00
|
|
|
spin_unlock(&inode->i_lock);
|
|
|
|
radix_tree_preload_end();
|
|
|
|
out:
|
|
|
|
return error;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2007-03-16 21:38:26 +00:00
|
|
|
* Remove a write request from an inode
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
|
|
|
static void nfs_inode_remove_request(struct nfs_page *req)
|
|
|
|
{
|
2007-06-05 14:42:27 +00:00
|
|
|
struct inode *inode = req->wb_context->path.dentry->d_inode;
|
2005-04-16 22:20:36 +00:00
|
|
|
struct nfs_inode *nfsi = NFS_I(inode);
|
|
|
|
|
|
|
|
BUG_ON (!NFS_WBACK_BUSY(req));
|
|
|
|
|
2007-07-02 13:57:54 +00:00
|
|
|
spin_lock(&inode->i_lock);
|
2006-12-05 05:35:35 +00:00
|
|
|
set_page_private(req->wb_page, 0);
|
2006-03-20 18:44:50 +00:00
|
|
|
ClearPagePrivate(req->wb_page);
|
2010-12-08 03:39:17 +00:00
|
|
|
clear_bit(PG_MAPPED, &req->wb_flags);
|
2005-04-16 22:20:36 +00:00
|
|
|
radix_tree_delete(&nfsi->nfs_page_tree, req->wb_index);
|
|
|
|
nfsi->npages--;
|
|
|
|
if (!nfsi->npages) {
|
2007-07-02 13:57:54 +00:00
|
|
|
spin_unlock(&inode->i_lock);
|
2005-04-16 22:20:36 +00:00
|
|
|
iput(inode);
|
|
|
|
} else
|
2007-07-02 13:57:54 +00:00
|
|
|
spin_unlock(&inode->i_lock);
|
2005-04-16 22:20:36 +00:00
|
|
|
nfs_release_request(req);
|
|
|
|
}
|
|
|
|
|
2006-12-05 05:35:42 +00:00
|
|
|
static void
|
2008-03-19 15:24:38 +00:00
|
|
|
nfs_mark_request_dirty(struct nfs_page *req)
|
2006-12-05 05:35:42 +00:00
|
|
|
{
|
|
|
|
__set_page_dirty_nobuffers(req->wb_page);
|
2010-04-09 23:07:07 +00:00
|
|
|
__mark_inode_dirty(req->wb_page->mapping->host, I_DIRTY_DATASYNC);
|
2006-12-05 05:35:42 +00:00
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
#if defined(CONFIG_NFS_V3) || defined(CONFIG_NFS_V4)
|
|
|
|
/*
|
|
|
|
* Add a request to the inode's commit list.
|
|
|
|
*/
|
|
|
|
static void
|
|
|
|
nfs_mark_request_commit(struct nfs_page *req)
|
|
|
|
{
|
2007-06-05 14:42:27 +00:00
|
|
|
struct inode *inode = req->wb_context->path.dentry->d_inode;
|
2005-04-16 22:20:36 +00:00
|
|
|
struct nfs_inode *nfsi = NFS_I(inode);
|
|
|
|
|
2007-07-02 13:57:54 +00:00
|
|
|
spin_lock(&inode->i_lock);
|
2008-06-13 17:25:22 +00:00
|
|
|
set_bit(PG_CLEAN, &(req)->wb_flags);
|
2007-06-17 19:27:42 +00:00
|
|
|
radix_tree_tag_set(&nfsi->nfs_page_tree,
|
|
|
|
req->wb_index,
|
|
|
|
NFS_PAGE_TAG_COMMIT);
|
2010-02-20 00:53:39 +00:00
|
|
|
nfsi->ncommit++;
|
2007-07-02 13:57:54 +00:00
|
|
|
spin_unlock(&inode->i_lock);
|
2006-06-30 08:55:40 +00:00
|
|
|
inc_zone_page_state(req->wb_page, NR_UNSTABLE_NFS);
|
2007-10-17 06:25:47 +00:00
|
|
|
inc_bdi_stat(req->wb_page->mapping->backing_dev_info, BDI_RECLAIMABLE);
|
2006-12-05 05:45:19 +00:00
|
|
|
__mark_inode_dirty(inode, I_DIRTY_DATASYNC);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2007-04-20 20:12:34 +00:00
|
|
|
|
2008-06-13 17:25:22 +00:00
|
|
|
static int
|
|
|
|
nfs_clear_request_commit(struct nfs_page *req)
|
|
|
|
{
|
|
|
|
struct page *page = req->wb_page;
|
|
|
|
|
|
|
|
if (test_and_clear_bit(PG_CLEAN, &(req)->wb_flags)) {
|
|
|
|
dec_zone_page_state(page, NR_UNSTABLE_NFS);
|
|
|
|
dec_bdi_stat(page->mapping->backing_dev_info, BDI_RECLAIMABLE);
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2007-04-20 20:12:34 +00:00
|
|
|
static inline
|
|
|
|
int nfs_write_need_commit(struct nfs_write_data *data)
|
|
|
|
{
|
|
|
|
return data->verf.committed != NFS_FILE_SYNC;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline
|
|
|
|
int nfs_reschedule_unstable_write(struct nfs_page *req)
|
|
|
|
{
|
2008-06-13 17:25:22 +00:00
|
|
|
if (test_and_clear_bit(PG_NEED_COMMIT, &req->wb_flags)) {
|
2007-04-20 20:12:34 +00:00
|
|
|
nfs_mark_request_commit(req);
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
if (test_and_clear_bit(PG_NEED_RESCHED, &req->wb_flags)) {
|
2008-03-19 15:24:38 +00:00
|
|
|
nfs_mark_request_dirty(req);
|
2007-04-20 20:12:34 +00:00
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
#else
|
|
|
|
static inline void
|
|
|
|
nfs_mark_request_commit(struct nfs_page *req)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
2008-06-13 17:25:22 +00:00
|
|
|
static inline int
|
|
|
|
nfs_clear_request_commit(struct nfs_page *req)
|
|
|
|
{
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2007-04-20 20:12:34 +00:00
|
|
|
static inline
|
|
|
|
int nfs_write_need_commit(struct nfs_write_data *data)
|
|
|
|
{
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline
|
|
|
|
int nfs_reschedule_unstable_write(struct nfs_page *req)
|
|
|
|
{
|
|
|
|
return 0;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
#endif
|
|
|
|
|
2009-03-16 12:13:41 +00:00
|
|
|
#if defined(CONFIG_NFS_V3) || defined(CONFIG_NFS_V4)
|
2009-03-11 18:10:29 +00:00
|
|
|
static int
|
|
|
|
nfs_need_commit(struct nfs_inode *nfsi)
|
|
|
|
{
|
|
|
|
return radix_tree_tagged(&nfsi->nfs_page_tree, NFS_PAGE_TAG_COMMIT);
|
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* nfs_scan_commit - Scan an inode for commit requests
|
|
|
|
* @inode: NFS inode to scan
|
|
|
|
* @dst: destination list
|
|
|
|
* @idx_start: lower bound of page->index to scan.
|
|
|
|
* @npages: idx_start + npages sets the upper bound to scan.
|
|
|
|
*
|
|
|
|
* Moves requests from the inode's 'commit' request list.
|
|
|
|
* The requests are *not* checked to ensure that they form a contiguous set.
|
|
|
|
*/
|
|
|
|
static int
|
2007-04-17 21:22:13 +00:00
|
|
|
nfs_scan_commit(struct inode *inode, struct list_head *dst, pgoff_t idx_start, unsigned int npages)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct nfs_inode *nfsi = NFS_I(inode);
|
2010-02-20 00:53:39 +00:00
|
|
|
int ret;
|
2005-06-22 17:16:31 +00:00
|
|
|
|
2009-03-11 18:10:29 +00:00
|
|
|
if (!nfs_need_commit(nfsi))
|
|
|
|
return 0;
|
|
|
|
|
2010-02-20 00:53:39 +00:00
|
|
|
ret = nfs_scan_list(nfsi, dst, idx_start, npages, NFS_PAGE_TAG_COMMIT);
|
|
|
|
if (ret > 0)
|
|
|
|
nfsi->ncommit -= ret;
|
2010-02-20 01:03:18 +00:00
|
|
|
if (nfs_need_commit(NFS_I(inode)))
|
|
|
|
__mark_inode_dirty(inode, I_DIRTY_DATASYNC);
|
2010-02-20 00:53:39 +00:00
|
|
|
return ret;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2006-03-20 18:44:51 +00:00
|
|
|
#else
|
2009-03-11 18:10:29 +00:00
|
|
|
static inline int nfs_need_commit(struct nfs_inode *nfsi)
|
|
|
|
{
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2007-04-17 21:22:13 +00:00
|
|
|
static inline int nfs_scan_commit(struct inode *inode, struct list_head *dst, pgoff_t idx_start, unsigned int npages)
|
2006-03-20 18:44:51 +00:00
|
|
|
{
|
|
|
|
return 0;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
#endif
|
|
|
|
|
|
|
|
/*
|
2008-06-13 16:12:32 +00:00
|
|
|
* Search for an existing write request, and attempt to update
|
|
|
|
* it to reflect a new dirty region on a given page.
|
2005-04-16 22:20:36 +00:00
|
|
|
*
|
2008-06-13 16:12:32 +00:00
|
|
|
* If the attempt fails, then the existing request is flushed out
|
|
|
|
* to disk.
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
2008-06-13 16:12:32 +00:00
|
|
|
static struct nfs_page *nfs_try_to_update_request(struct inode *inode,
|
|
|
|
struct page *page,
|
|
|
|
unsigned int offset,
|
|
|
|
unsigned int bytes)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2008-06-13 16:12:32 +00:00
|
|
|
struct nfs_page *req;
|
|
|
|
unsigned int rqend;
|
|
|
|
unsigned int end;
|
|
|
|
int error;
|
|
|
|
|
|
|
|
if (!PagePrivate(page))
|
|
|
|
return NULL;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
end = offset + bytes;
|
2008-06-13 16:12:32 +00:00
|
|
|
spin_lock(&inode->i_lock);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
for (;;) {
|
2006-12-05 05:35:35 +00:00
|
|
|
req = nfs_page_find_request_locked(page);
|
2008-06-13 16:12:32 +00:00
|
|
|
if (req == NULL)
|
|
|
|
goto out_unlock;
|
|
|
|
|
|
|
|
rqend = req->wb_offset + req->wb_bytes;
|
|
|
|
/*
|
|
|
|
* Tell the caller to flush out the request if
|
|
|
|
* the offsets are non-contiguous.
|
|
|
|
* Note: nfs_flush_incompatible() will already
|
|
|
|
* have flushed out requests having wrong owners.
|
|
|
|
*/
|
2008-06-13 17:25:22 +00:00
|
|
|
if (offset > rqend
|
2008-06-13 16:12:32 +00:00
|
|
|
|| end < req->wb_offset)
|
|
|
|
goto out_flushme;
|
|
|
|
|
|
|
|
if (nfs_set_page_tag_locked(req))
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
|
2008-06-13 16:12:32 +00:00
|
|
|
/* The request is locked, so wait and then retry */
|
2007-07-02 13:57:54 +00:00
|
|
|
spin_unlock(&inode->i_lock);
|
2008-06-13 16:12:32 +00:00
|
|
|
error = nfs_wait_on_request(req);
|
|
|
|
nfs_release_request(req);
|
|
|
|
if (error != 0)
|
|
|
|
goto out_err;
|
|
|
|
spin_lock(&inode->i_lock);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2010-02-20 00:53:39 +00:00
|
|
|
if (nfs_clear_request_commit(req) &&
|
|
|
|
radix_tree_tag_clear(&NFS_I(inode)->nfs_page_tree,
|
|
|
|
req->wb_index, NFS_PAGE_TAG_COMMIT) != NULL)
|
|
|
|
NFS_I(inode)->ncommit--;
|
2008-06-13 17:25:22 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/* Okay, the request matches. Update the region */
|
|
|
|
if (offset < req->wb_offset) {
|
|
|
|
req->wb_offset = offset;
|
|
|
|
req->wb_pgbase = offset;
|
|
|
|
}
|
|
|
|
if (end > rqend)
|
|
|
|
req->wb_bytes = end - req->wb_offset;
|
2008-06-13 16:12:32 +00:00
|
|
|
else
|
|
|
|
req->wb_bytes = rqend - req->wb_offset;
|
|
|
|
out_unlock:
|
|
|
|
spin_unlock(&inode->i_lock);
|
|
|
|
return req;
|
|
|
|
out_flushme:
|
|
|
|
spin_unlock(&inode->i_lock);
|
|
|
|
nfs_release_request(req);
|
|
|
|
error = nfs_wb_page(inode, page);
|
|
|
|
out_err:
|
|
|
|
return ERR_PTR(error);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Try to update an existing write request, or create one if there is none.
|
|
|
|
*
|
|
|
|
* Note: Should always be called with the Page Lock held to prevent races
|
|
|
|
* if we have to add a new request. Also assumes that the caller has
|
|
|
|
* already called nfs_flush_incompatible() if necessary.
|
|
|
|
*/
|
|
|
|
static struct nfs_page * nfs_setup_write_request(struct nfs_open_context* ctx,
|
|
|
|
struct page *page, unsigned int offset, unsigned int bytes)
|
|
|
|
{
|
|
|
|
struct inode *inode = page->mapping->host;
|
|
|
|
struct nfs_page *req;
|
|
|
|
int error;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-06-13 16:12:32 +00:00
|
|
|
req = nfs_try_to_update_request(inode, page, offset, bytes);
|
|
|
|
if (req != NULL)
|
|
|
|
goto out;
|
|
|
|
req = nfs_create_request(ctx, inode, page, offset, bytes);
|
|
|
|
if (IS_ERR(req))
|
|
|
|
goto out;
|
|
|
|
error = nfs_inode_add_request(inode, req);
|
|
|
|
if (error != 0) {
|
|
|
|
nfs_release_request(req);
|
|
|
|
req = ERR_PTR(error);
|
|
|
|
}
|
2008-06-10 22:31:00 +00:00
|
|
|
out:
|
2007-10-18 21:08:05 +00:00
|
|
|
return req;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2008-06-13 16:12:32 +00:00
|
|
|
static int nfs_writepage_setup(struct nfs_open_context *ctx, struct page *page,
|
|
|
|
unsigned int offset, unsigned int count)
|
|
|
|
{
|
|
|
|
struct nfs_page *req;
|
|
|
|
|
|
|
|
req = nfs_setup_write_request(ctx, page, offset, count);
|
|
|
|
if (IS_ERR(req))
|
|
|
|
return PTR_ERR(req);
|
2010-04-09 23:07:07 +00:00
|
|
|
nfs_mark_request_dirty(req);
|
2008-06-13 16:12:32 +00:00
|
|
|
/* Update file length */
|
|
|
|
nfs_grow_file(page, offset, count);
|
|
|
|
nfs_mark_uptodate(page, req->wb_pgbase, req->wb_bytes);
|
2010-04-09 23:07:08 +00:00
|
|
|
nfs_mark_request_dirty(req);
|
2008-06-13 16:12:32 +00:00
|
|
|
nfs_clear_page_tag_locked(req);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
int nfs_flush_incompatible(struct file *file, struct page *page)
|
|
|
|
{
|
2007-08-10 21:44:32 +00:00
|
|
|
struct nfs_open_context *ctx = nfs_file_open_context(file);
|
2005-04-16 22:20:36 +00:00
|
|
|
struct nfs_page *req;
|
2006-12-05 05:35:40 +00:00
|
|
|
int do_flush, status;
|
2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* Look for a request corresponding to this page. If there
|
|
|
|
* is one, and it belongs to another file, we flush it out
|
|
|
|
* before we try to copy anything into the page. Do this
|
|
|
|
* due to the lack of an ACCESS-type call in NFSv2.
|
|
|
|
* Also do the same if we find a request from an existing
|
|
|
|
* dropped page.
|
|
|
|
*/
|
2006-12-05 05:35:40 +00:00
|
|
|
do {
|
|
|
|
req = nfs_page_find_request(page);
|
|
|
|
if (req == NULL)
|
|
|
|
return 0;
|
2010-06-25 20:35:53 +00:00
|
|
|
do_flush = req->wb_page != page || req->wb_context != ctx ||
|
|
|
|
req->wb_lock_context->lockowner != current->files ||
|
|
|
|
req->wb_lock_context->pid != current->tgid;
|
2005-04-16 22:20:36 +00:00
|
|
|
nfs_release_request(req);
|
2006-12-05 05:35:40 +00:00
|
|
|
if (!do_flush)
|
|
|
|
return 0;
|
|
|
|
status = nfs_wb_page(page->mapping->host, page);
|
|
|
|
} while (status == 0);
|
|
|
|
return status;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
NFS: Fix a potential file corruption issue when writing
If the inode is flagged as having an invalid mapping, then we can't rely on
the PageUptodate() flag. Ensure that we don't use the "anti-fragmentation"
write optimisation in nfs_updatepage(), since that will cause NFS to write
out areas of the page that are no longer guaranteed to be up to date.
A potential corruption could occur in the following scenario:
client 1 client 2
=============== ===============
fd=open("f",O_CREAT|O_WRONLY,0644);
write(fd,"fubar\n",6); // cache last page
close(fd);
fd=open("f",O_WRONLY|O_APPEND);
write(fd,"foo\n",4);
close(fd);
fd=open("f",O_WRONLY|O_APPEND);
write(fd,"bar\n",4);
close(fd);
-----
The bug may lead to the file "f" reading 'fubar\n\0\0\0\nbar\n' because
client 2 does not update the cached page after re-opening the file for
write. Instead it keeps it marked as PageUptodate() until someone calls
invaldate_inode_pages2() (typically by calling read()).
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
2008-02-07 22:24:07 +00:00
|
|
|
/*
|
|
|
|
* If the page cache is marked as unsafe or invalid, then we can't rely on
|
|
|
|
* the PageUptodate() flag. In this case, we will need to turn off
|
|
|
|
* write optimisations that depend on the page contents being correct.
|
|
|
|
*/
|
|
|
|
static int nfs_write_pageuptodate(struct page *page, struct inode *inode)
|
|
|
|
{
|
|
|
|
return PageUptodate(page) &&
|
|
|
|
!(NFS_I(inode)->cache_validity & (NFS_INO_REVAL_PAGECACHE|NFS_INO_INVALID_DATA));
|
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* Update and possibly write a cached page of an NFS file.
|
|
|
|
*
|
|
|
|
* XXX: Keep an eye on generic_file_read to make sure it doesn't do bad
|
|
|
|
* things with a page scheduled for an RPC call (e.g. invalidate it).
|
|
|
|
*/
|
|
|
|
int nfs_updatepage(struct file *file, struct page *page,
|
|
|
|
unsigned int offset, unsigned int count)
|
|
|
|
{
|
2007-08-10 21:44:32 +00:00
|
|
|
struct nfs_open_context *ctx = nfs_file_open_context(file);
|
2005-04-16 22:20:36 +00:00
|
|
|
struct inode *inode = page->mapping->host;
|
|
|
|
int status = 0;
|
|
|
|
|
2006-03-20 18:44:14 +00:00
|
|
|
nfs_inc_stats(inode, NFSIOS_VFSUPDATEPAGE);
|
|
|
|
|
2008-06-11 21:56:05 +00:00
|
|
|
dprintk("NFS: nfs_updatepage(%s/%s %d@%lld)\n",
|
2006-12-08 10:36:40 +00:00
|
|
|
file->f_path.dentry->d_parent->d_name.name,
|
|
|
|
file->f_path.dentry->d_name.name, count,
|
2008-06-11 21:56:05 +00:00
|
|
|
(long long)(page_offset(page) + offset));
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/* If we're not using byte range locks, and we know the page
|
NFS: Fix a potential file corruption issue when writing
If the inode is flagged as having an invalid mapping, then we can't rely on
the PageUptodate() flag. Ensure that we don't use the "anti-fragmentation"
write optimisation in nfs_updatepage(), since that will cause NFS to write
out areas of the page that are no longer guaranteed to be up to date.
A potential corruption could occur in the following scenario:
client 1 client 2
=============== ===============
fd=open("f",O_CREAT|O_WRONLY,0644);
write(fd,"fubar\n",6); // cache last page
close(fd);
fd=open("f",O_WRONLY|O_APPEND);
write(fd,"foo\n",4);
close(fd);
fd=open("f",O_WRONLY|O_APPEND);
write(fd,"bar\n",4);
close(fd);
-----
The bug may lead to the file "f" reading 'fubar\n\0\0\0\nbar\n' because
client 2 does not update the cached page after re-opening the file for
write. Instead it keeps it marked as PageUptodate() until someone calls
invaldate_inode_pages2() (typically by calling read()).
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
2008-02-07 22:24:07 +00:00
|
|
|
* is up to date, it may be more efficient to extend the write
|
|
|
|
* to cover the entire page in order to avoid fragmentation
|
|
|
|
* inefficiencies.
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
NFS: Fix a potential file corruption issue when writing
If the inode is flagged as having an invalid mapping, then we can't rely on
the PageUptodate() flag. Ensure that we don't use the "anti-fragmentation"
write optimisation in nfs_updatepage(), since that will cause NFS to write
out areas of the page that are no longer guaranteed to be up to date.
A potential corruption could occur in the following scenario:
client 1 client 2
=============== ===============
fd=open("f",O_CREAT|O_WRONLY,0644);
write(fd,"fubar\n",6); // cache last page
close(fd);
fd=open("f",O_WRONLY|O_APPEND);
write(fd,"foo\n",4);
close(fd);
fd=open("f",O_WRONLY|O_APPEND);
write(fd,"bar\n",4);
close(fd);
-----
The bug may lead to the file "f" reading 'fubar\n\0\0\0\nbar\n' because
client 2 does not update the cached page after re-opening the file for
write. Instead it keeps it marked as PageUptodate() until someone calls
invaldate_inode_pages2() (typically by calling read()).
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
2008-02-07 22:24:07 +00:00
|
|
|
if (nfs_write_pageuptodate(page, inode) &&
|
|
|
|
inode->i_flock == NULL &&
|
2009-10-27 10:05:28 +00:00
|
|
|
!(file->f_flags & O_DSYNC)) {
|
2006-12-05 05:35:38 +00:00
|
|
|
count = max(count + offset, nfs_page_length(page));
|
2005-04-16 22:20:36 +00:00
|
|
|
offset = 0;
|
|
|
|
}
|
|
|
|
|
2006-12-05 05:35:39 +00:00
|
|
|
status = nfs_writepage_setup(ctx, page, offset, count);
|
2008-06-05 20:02:35 +00:00
|
|
|
if (status < 0)
|
|
|
|
nfs_set_pageerror(page);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-06-11 21:56:05 +00:00
|
|
|
dprintk("NFS: nfs_updatepage returns %d (isize %lld)\n",
|
2005-04-16 22:20:36 +00:00
|
|
|
status, (long long)i_size_read(inode));
|
|
|
|
return status;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void nfs_writepage_release(struct nfs_page *req)
|
|
|
|
{
|
2010-04-09 23:07:08 +00:00
|
|
|
struct page *page = req->wb_page;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-04-09 23:07:08 +00:00
|
|
|
if (PageError(req->wb_page) || !nfs_reschedule_unstable_write(req))
|
2007-04-20 20:12:34 +00:00
|
|
|
nfs_inode_remove_request(req);
|
2007-06-17 19:10:24 +00:00
|
|
|
nfs_clear_page_tag_locked(req);
|
2010-04-09 23:07:08 +00:00
|
|
|
nfs_end_page_writeback(page);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2007-07-14 19:40:00 +00:00
|
|
|
static int flush_task_priority(int how)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
switch (how & (FLUSH_HIGHPRI|FLUSH_LOWPRI)) {
|
|
|
|
case FLUSH_HIGHPRI:
|
|
|
|
return RPC_PRIORITY_HIGH;
|
|
|
|
case FLUSH_LOWPRI:
|
|
|
|
return RPC_PRIORITY_LOW;
|
|
|
|
}
|
|
|
|
return RPC_PRIORITY_NORMAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Set up the argument/result storage required for the RPC call.
|
|
|
|
*/
|
2008-04-14 18:54:53 +00:00
|
|
|
static int nfs_write_rpcsetup(struct nfs_page *req,
|
2005-04-16 22:20:36 +00:00
|
|
|
struct nfs_write_data *data,
|
2006-03-20 18:44:27 +00:00
|
|
|
const struct rpc_call_ops *call_ops,
|
2005-04-16 22:20:36 +00:00
|
|
|
unsigned int count, unsigned int offset,
|
|
|
|
int how)
|
|
|
|
{
|
2007-07-14 19:39:59 +00:00
|
|
|
struct inode *inode = req->wb_context->path.dentry->d_inode;
|
2007-07-14 19:40:00 +00:00
|
|
|
int priority = flush_task_priority(how);
|
2007-10-25 22:42:54 +00:00
|
|
|
struct rpc_task *task;
|
2007-07-14 19:40:00 +00:00
|
|
|
struct rpc_message msg = {
|
|
|
|
.rpc_argp = &data->args,
|
|
|
|
.rpc_resp = &data->res,
|
|
|
|
.rpc_cred = req->wb_context->cred,
|
|
|
|
};
|
2007-07-14 19:39:59 +00:00
|
|
|
struct rpc_task_setup task_setup_data = {
|
|
|
|
.rpc_client = NFS_CLIENT(inode),
|
2007-10-25 22:42:54 +00:00
|
|
|
.task = &data->task,
|
2007-07-14 19:40:00 +00:00
|
|
|
.rpc_message = &msg,
|
2007-07-14 19:39:59 +00:00
|
|
|
.callback_ops = call_ops,
|
|
|
|
.callback_data = data,
|
2008-02-20 01:04:23 +00:00
|
|
|
.workqueue = nfsiod_workqueue,
|
2010-04-09 23:54:50 +00:00
|
|
|
.flags = RPC_TASK_ASYNC,
|
2007-07-14 19:40:00 +00:00
|
|
|
.priority = priority,
|
2007-07-14 19:39:59 +00:00
|
|
|
};
|
2010-04-09 23:54:50 +00:00
|
|
|
int ret = 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/* Set up the RPC argument and reply structs
|
|
|
|
* NB: take care not to mess about with data->commit et al. */
|
|
|
|
|
|
|
|
data->req = req;
|
2007-06-05 14:42:27 +00:00
|
|
|
data->inode = inode = req->wb_context->path.dentry->d_inode;
|
2007-07-14 19:40:00 +00:00
|
|
|
data->cred = msg.rpc_cred;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
data->args.fh = NFS_FH(inode);
|
|
|
|
data->args.offset = req_offset(req) + offset;
|
|
|
|
data->args.pgbase = req->wb_pgbase + offset;
|
|
|
|
data->args.pages = data->pagevec;
|
|
|
|
data->args.count = count;
|
2008-02-20 01:04:20 +00:00
|
|
|
data->args.context = get_nfs_open_context(req->wb_context);
|
2010-06-25 20:35:53 +00:00
|
|
|
data->args.lock_context = req->wb_lock_context;
|
2007-07-14 19:40:00 +00:00
|
|
|
data->args.stable = NFS_UNSTABLE;
|
|
|
|
if (how & FLUSH_STABLE) {
|
|
|
|
data->args.stable = NFS_DATA_SYNC;
|
2009-03-11 18:10:29 +00:00
|
|
|
if (!nfs_need_commit(NFS_I(inode)))
|
2007-07-14 19:40:00 +00:00
|
|
|
data->args.stable = NFS_FILE_SYNC;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
data->res.fattr = &data->fattr;
|
|
|
|
data->res.count = count;
|
|
|
|
data->res.verf = &data->verf;
|
2005-10-28 02:12:38 +00:00
|
|
|
nfs_fattr_init(&data->fattr);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2006-03-20 18:44:27 +00:00
|
|
|
/* Set up the initial task struct. */
|
2007-07-14 19:40:00 +00:00
|
|
|
NFS_PROTO(inode)->write_setup(data, &msg);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2007-01-31 17:14:01 +00:00
|
|
|
dprintk("NFS: %5u initiated write call "
|
2008-06-11 21:56:05 +00:00
|
|
|
"(req %s/%lld, %u bytes @ offset %llu)\n",
|
2005-11-01 21:53:32 +00:00
|
|
|
data->task.tk_pid,
|
2005-04-16 22:20:36 +00:00
|
|
|
inode->i_sb->s_id,
|
|
|
|
(long long)NFS_FILEID(inode),
|
|
|
|
count,
|
|
|
|
(unsigned long long)data->args.offset);
|
|
|
|
|
2007-10-25 22:42:54 +00:00
|
|
|
task = rpc_run_task(&task_setup_data);
|
2010-04-09 23:54:50 +00:00
|
|
|
if (IS_ERR(task)) {
|
|
|
|
ret = PTR_ERR(task);
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
if (how & FLUSH_SYNC) {
|
|
|
|
ret = rpc_wait_for_completion_task(task);
|
|
|
|
if (ret == 0)
|
|
|
|
ret = task->tk_status;
|
|
|
|
}
|
2008-04-14 18:54:53 +00:00
|
|
|
rpc_put_task(task);
|
2010-04-09 23:54:50 +00:00
|
|
|
out:
|
|
|
|
return ret;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2008-03-19 15:24:38 +00:00
|
|
|
/* If a nfs_flush_* function fails, it should remove reqs from @head and
|
|
|
|
* call this on each, which will prepare them to be retried on next
|
|
|
|
* writeback using standard nfs.
|
|
|
|
*/
|
|
|
|
static void nfs_redirty_request(struct nfs_page *req)
|
|
|
|
{
|
2010-04-09 23:07:08 +00:00
|
|
|
struct page *page = req->wb_page;
|
|
|
|
|
2008-03-19 15:24:38 +00:00
|
|
|
nfs_mark_request_dirty(req);
|
|
|
|
nfs_clear_page_tag_locked(req);
|
2010-04-09 23:07:08 +00:00
|
|
|
nfs_end_page_writeback(page);
|
2008-03-19 15:24:38 +00:00
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* Generate multiple small requests to write out a single
|
|
|
|
* contiguous dirty area on one page.
|
|
|
|
*/
|
2007-04-10 13:26:35 +00:00
|
|
|
static int nfs_flush_multi(struct inode *inode, struct list_head *head, unsigned int npages, size_t count, int how)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct nfs_page *req = nfs_list_entry(head->next);
|
|
|
|
struct page *page = req->wb_page;
|
|
|
|
struct nfs_write_data *data;
|
2006-09-08 16:48:54 +00:00
|
|
|
size_t wsize = NFS_SERVER(inode)->wsize, nbytes;
|
|
|
|
unsigned int offset;
|
2005-04-16 22:20:36 +00:00
|
|
|
int requests = 0;
|
2008-04-14 18:54:53 +00:00
|
|
|
int ret = 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
LIST_HEAD(list);
|
|
|
|
|
|
|
|
nfs_list_remove_request(req);
|
|
|
|
|
2007-04-02 22:48:28 +00:00
|
|
|
nbytes = count;
|
2006-09-08 16:48:54 +00:00
|
|
|
do {
|
|
|
|
size_t len = min(nbytes, wsize);
|
|
|
|
|
2007-04-10 13:26:35 +00:00
|
|
|
data = nfs_writedata_alloc(1);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (!data)
|
|
|
|
goto out_bad;
|
|
|
|
list_add(&data->pages, &list);
|
|
|
|
requests++;
|
2006-09-08 16:48:54 +00:00
|
|
|
nbytes -= len;
|
|
|
|
} while (nbytes != 0);
|
2005-04-16 22:20:36 +00:00
|
|
|
atomic_set(&req->wb_complete, requests);
|
|
|
|
|
|
|
|
ClearPageError(page);
|
|
|
|
offset = 0;
|
2007-04-02 22:48:28 +00:00
|
|
|
nbytes = count;
|
2005-04-16 22:20:36 +00:00
|
|
|
do {
|
2008-04-14 18:54:53 +00:00
|
|
|
int ret2;
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
data = list_entry(list.next, struct nfs_write_data, pages);
|
|
|
|
list_del_init(&data->pages);
|
|
|
|
|
|
|
|
data->pagevec[0] = page;
|
|
|
|
|
2007-04-02 22:48:28 +00:00
|
|
|
if (nbytes < wsize)
|
|
|
|
wsize = nbytes;
|
2008-04-14 18:54:53 +00:00
|
|
|
ret2 = nfs_write_rpcsetup(req, data, &nfs_write_partial_ops,
|
2007-04-02 22:48:28 +00:00
|
|
|
wsize, offset, how);
|
2008-04-14 18:54:53 +00:00
|
|
|
if (ret == 0)
|
|
|
|
ret = ret2;
|
2007-04-02 22:48:28 +00:00
|
|
|
offset += wsize;
|
|
|
|
nbytes -= wsize;
|
2005-04-16 22:20:36 +00:00
|
|
|
} while (nbytes != 0);
|
|
|
|
|
2008-04-14 18:54:53 +00:00
|
|
|
return ret;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
out_bad:
|
|
|
|
while (!list_empty(&list)) {
|
|
|
|
data = list_entry(list.next, struct nfs_write_data, pages);
|
|
|
|
list_del(&data->pages);
|
2011-01-19 19:18:50 +00:00
|
|
|
nfs_writedata_free(data);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2006-12-05 05:35:42 +00:00
|
|
|
nfs_redirty_request(req);
|
2005-04-16 22:20:36 +00:00
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Create an RPC task for the given write request and kick it.
|
|
|
|
* The page must have been locked by the caller.
|
|
|
|
*
|
|
|
|
* It may happen that the page we're passed is not marked dirty.
|
|
|
|
* This is the case if nfs_updatepage detects a conflicting request
|
|
|
|
* that has been written but not committed.
|
|
|
|
*/
|
2007-04-10 13:26:35 +00:00
|
|
|
static int nfs_flush_one(struct inode *inode, struct list_head *head, unsigned int npages, size_t count, int how)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct nfs_page *req;
|
|
|
|
struct page **pages;
|
|
|
|
struct nfs_write_data *data;
|
|
|
|
|
2007-04-10 13:26:35 +00:00
|
|
|
data = nfs_writedata_alloc(npages);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (!data)
|
|
|
|
goto out_bad;
|
|
|
|
|
|
|
|
pages = data->pagevec;
|
|
|
|
while (!list_empty(head)) {
|
|
|
|
req = nfs_list_entry(head->next);
|
|
|
|
nfs_list_remove_request(req);
|
|
|
|
nfs_list_add_request(req, &data->pages);
|
|
|
|
ClearPageError(req->wb_page);
|
|
|
|
*pages++ = req->wb_page;
|
|
|
|
}
|
|
|
|
req = nfs_list_entry(data->pages.next);
|
|
|
|
|
|
|
|
/* Set up the argument struct */
|
2008-04-14 18:54:53 +00:00
|
|
|
return nfs_write_rpcsetup(req, data, &nfs_write_full_ops, count, 0, how);
|
2005-04-16 22:20:36 +00:00
|
|
|
out_bad:
|
|
|
|
while (!list_empty(head)) {
|
2007-05-14 21:16:04 +00:00
|
|
|
req = nfs_list_entry(head->next);
|
2005-04-16 22:20:36 +00:00
|
|
|
nfs_list_remove_request(req);
|
2006-12-05 05:35:42 +00:00
|
|
|
nfs_redirty_request(req);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
|
2007-04-02 23:29:52 +00:00
|
|
|
static void nfs_pageio_init_write(struct nfs_pageio_descriptor *pgio,
|
|
|
|
struct inode *inode, int ioflags)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2007-12-20 19:54:57 +00:00
|
|
|
size_t wsize = NFS_SERVER(inode)->wsize;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2007-04-02 22:48:28 +00:00
|
|
|
if (wsize < PAGE_CACHE_SIZE)
|
2007-04-02 23:29:52 +00:00
|
|
|
nfs_pageio_init(pgio, inode, nfs_flush_multi, wsize, ioflags);
|
2007-04-02 22:48:28 +00:00
|
|
|
else
|
2007-04-02 23:29:52 +00:00
|
|
|
nfs_pageio_init(pgio, inode, nfs_flush_one, wsize, ioflags);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Handle a write reply that flushed part of a page.
|
|
|
|
*/
|
2006-03-20 18:44:27 +00:00
|
|
|
static void nfs_writeback_done_partial(struct rpc_task *task, void *calldata)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2006-03-20 18:44:27 +00:00
|
|
|
struct nfs_write_data *data = calldata;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-06-11 21:56:05 +00:00
|
|
|
dprintk("NFS: %5u write(%s/%lld %d@%lld)",
|
|
|
|
task->tk_pid,
|
|
|
|
data->req->wb_context->path.dentry->d_inode->i_sb->s_id,
|
|
|
|
(long long)
|
|
|
|
NFS_FILEID(data->req->wb_context->path.dentry->d_inode),
|
|
|
|
data->req->wb_bytes, (long long)req_offset(data->req));
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-04-15 20:56:39 +00:00
|
|
|
nfs_writeback_done(task, data);
|
|
|
|
}
|
2006-03-20 18:44:27 +00:00
|
|
|
|
2008-04-15 20:56:39 +00:00
|
|
|
static void nfs_writeback_release_partial(void *calldata)
|
|
|
|
{
|
|
|
|
struct nfs_write_data *data = calldata;
|
|
|
|
struct nfs_page *req = data->req;
|
|
|
|
struct page *page = req->wb_page;
|
|
|
|
int status = data->task.tk_status;
|
|
|
|
|
|
|
|
if (status < 0) {
|
2007-02-06 19:07:15 +00:00
|
|
|
nfs_set_pageerror(page);
|
2008-04-15 20:56:39 +00:00
|
|
|
nfs_context_set_write_error(req->wb_context, status);
|
|
|
|
dprintk(", error = %d\n", status);
|
2007-04-20 20:12:34 +00:00
|
|
|
goto out;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2007-04-20 20:12:34 +00:00
|
|
|
if (nfs_write_need_commit(data)) {
|
2007-07-02 13:57:54 +00:00
|
|
|
struct inode *inode = page->mapping->host;
|
2007-04-20 20:12:34 +00:00
|
|
|
|
2007-07-02 13:57:54 +00:00
|
|
|
spin_lock(&inode->i_lock);
|
2007-04-20 20:12:34 +00:00
|
|
|
if (test_bit(PG_NEED_RESCHED, &req->wb_flags)) {
|
|
|
|
/* Do nothing we need to resend the writes */
|
|
|
|
} else if (!test_and_set_bit(PG_NEED_COMMIT, &req->wb_flags)) {
|
|
|
|
memcpy(&req->wb_verf, &data->verf, sizeof(req->wb_verf));
|
|
|
|
dprintk(" defer commit\n");
|
|
|
|
} else if (memcmp(&req->wb_verf, &data->verf, sizeof(req->wb_verf))) {
|
|
|
|
set_bit(PG_NEED_RESCHED, &req->wb_flags);
|
|
|
|
clear_bit(PG_NEED_COMMIT, &req->wb_flags);
|
|
|
|
dprintk(" server reboot detected\n");
|
|
|
|
}
|
2007-07-02 13:57:54 +00:00
|
|
|
spin_unlock(&inode->i_lock);
|
2007-04-20 20:12:34 +00:00
|
|
|
} else
|
|
|
|
dprintk(" OK\n");
|
|
|
|
|
|
|
|
out:
|
2005-04-16 22:20:36 +00:00
|
|
|
if (atomic_dec_and_test(&req->wb_complete))
|
|
|
|
nfs_writepage_release(req);
|
2008-04-15 20:56:39 +00:00
|
|
|
nfs_writedata_release(calldata);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2009-04-01 13:22:26 +00:00
|
|
|
#if defined(CONFIG_NFS_V4_1)
|
|
|
|
void nfs_write_prepare(struct rpc_task *task, void *calldata)
|
|
|
|
{
|
|
|
|
struct nfs_write_data *data = calldata;
|
|
|
|
|
2010-06-16 13:52:26 +00:00
|
|
|
if (nfs4_setup_sequence(NFS_SERVER(data->inode),
|
|
|
|
&data->args.seq_args,
|
2009-04-01 13:22:26 +00:00
|
|
|
&data->res.seq_res, 1, task))
|
|
|
|
return;
|
|
|
|
rpc_call_start(task);
|
|
|
|
}
|
|
|
|
#endif /* CONFIG_NFS_V4_1 */
|
|
|
|
|
2006-03-20 18:44:27 +00:00
|
|
|
static const struct rpc_call_ops nfs_write_partial_ops = {
|
2009-04-01 13:22:26 +00:00
|
|
|
#if defined(CONFIG_NFS_V4_1)
|
|
|
|
.rpc_call_prepare = nfs_write_prepare,
|
|
|
|
#endif /* CONFIG_NFS_V4_1 */
|
2006-03-20 18:44:27 +00:00
|
|
|
.rpc_call_done = nfs_writeback_done_partial,
|
2008-04-15 20:56:39 +00:00
|
|
|
.rpc_release = nfs_writeback_release_partial,
|
2006-03-20 18:44:27 +00:00
|
|
|
};
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* Handle a write reply that flushes a whole page.
|
|
|
|
*
|
|
|
|
* FIXME: There is an inherent race with invalidate_inode_pages and
|
|
|
|
* writebacks since the page->count is kept > 1 for as long
|
|
|
|
* as the page has a write request pending.
|
|
|
|
*/
|
2006-03-20 18:44:27 +00:00
|
|
|
static void nfs_writeback_done_full(struct rpc_task *task, void *calldata)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2006-03-20 18:44:27 +00:00
|
|
|
struct nfs_write_data *data = calldata;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-04-15 20:56:39 +00:00
|
|
|
nfs_writeback_done(task, data);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void nfs_writeback_release_full(void *calldata)
|
|
|
|
{
|
|
|
|
struct nfs_write_data *data = calldata;
|
|
|
|
int status = data->task.tk_status;
|
2006-03-20 18:44:27 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/* Update attributes as result of writeback. */
|
|
|
|
while (!list_empty(&data->pages)) {
|
2008-04-15 20:56:39 +00:00
|
|
|
struct nfs_page *req = nfs_list_entry(data->pages.next);
|
|
|
|
struct page *page = req->wb_page;
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
nfs_list_remove_request(req);
|
|
|
|
|
2008-06-11 21:56:05 +00:00
|
|
|
dprintk("NFS: %5u write (%s/%lld %d@%lld)",
|
|
|
|
data->task.tk_pid,
|
2007-06-05 14:42:27 +00:00
|
|
|
req->wb_context->path.dentry->d_inode->i_sb->s_id,
|
|
|
|
(long long)NFS_FILEID(req->wb_context->path.dentry->d_inode),
|
2005-04-16 22:20:36 +00:00
|
|
|
req->wb_bytes,
|
|
|
|
(long long)req_offset(req));
|
|
|
|
|
2008-04-15 20:56:39 +00:00
|
|
|
if (status < 0) {
|
2007-02-06 19:07:15 +00:00
|
|
|
nfs_set_pageerror(page);
|
2008-04-15 20:56:39 +00:00
|
|
|
nfs_context_set_write_error(req->wb_context, status);
|
|
|
|
dprintk(", error = %d\n", status);
|
2007-04-20 20:12:34 +00:00
|
|
|
goto remove_request;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2007-04-20 20:12:34 +00:00
|
|
|
if (nfs_write_need_commit(data)) {
|
|
|
|
memcpy(&req->wb_verf, &data->verf, sizeof(req->wb_verf));
|
|
|
|
nfs_mark_request_commit(req);
|
|
|
|
dprintk(" marked for commit\n");
|
2005-04-16 22:20:36 +00:00
|
|
|
goto next;
|
|
|
|
}
|
2007-04-20 20:12:34 +00:00
|
|
|
dprintk(" OK\n");
|
|
|
|
remove_request:
|
2005-04-16 22:20:36 +00:00
|
|
|
nfs_inode_remove_request(req);
|
|
|
|
next:
|
2007-06-17 19:10:24 +00:00
|
|
|
nfs_clear_page_tag_locked(req);
|
2010-04-09 23:07:08 +00:00
|
|
|
nfs_end_page_writeback(page);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2008-04-15 20:56:39 +00:00
|
|
|
nfs_writedata_release(calldata);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2006-03-20 18:44:27 +00:00
|
|
|
static const struct rpc_call_ops nfs_write_full_ops = {
|
2009-04-01 13:22:26 +00:00
|
|
|
#if defined(CONFIG_NFS_V4_1)
|
|
|
|
.rpc_call_prepare = nfs_write_prepare,
|
|
|
|
#endif /* CONFIG_NFS_V4_1 */
|
2006-03-20 18:44:27 +00:00
|
|
|
.rpc_call_done = nfs_writeback_done_full,
|
2008-04-15 20:56:39 +00:00
|
|
|
.rpc_release = nfs_writeback_release_full,
|
2006-03-20 18:44:27 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* This function is called when the WRITE call is complete.
|
|
|
|
*/
|
2011-02-11 15:42:38 +00:00
|
|
|
void nfs_writeback_done(struct rpc_task *task, struct nfs_write_data *data)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct nfs_writeargs *argp = &data->args;
|
|
|
|
struct nfs_writeres *resp = &data->res;
|
2009-04-01 13:22:41 +00:00
|
|
|
struct nfs_server *server = NFS_SERVER(data->inode);
|
2006-03-20 18:44:27 +00:00
|
|
|
int status;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2007-01-31 17:14:01 +00:00
|
|
|
dprintk("NFS: %5u nfs_writeback_done (status %d)\n",
|
2005-04-16 22:20:36 +00:00
|
|
|
task->tk_pid, task->tk_status);
|
|
|
|
|
2006-09-20 18:33:04 +00:00
|
|
|
/*
|
|
|
|
* ->write_done will attempt to use post-op attributes to detect
|
|
|
|
* conflicting writes by other clients. A strict interpretation
|
|
|
|
* of close-to-open would allow us to continue caching even if
|
|
|
|
* another writer had changed the file, but some applications
|
|
|
|
* depend on tighter cache coherency when writing.
|
|
|
|
*/
|
2006-03-20 18:44:27 +00:00
|
|
|
status = NFS_PROTO(data->inode)->write_done(task, data);
|
|
|
|
if (status != 0)
|
2011-02-11 15:42:38 +00:00
|
|
|
return;
|
2006-03-20 18:44:14 +00:00
|
|
|
nfs_add_stats(data->inode, NFSIOS_SERVERWRITTENBYTES, resp->count);
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
#if defined(CONFIG_NFS_V3) || defined(CONFIG_NFS_V4)
|
|
|
|
if (resp->verf->committed < argp->stable && task->tk_status >= 0) {
|
|
|
|
/* We tried a write call, but the server did not
|
|
|
|
* commit data to stable storage even though we
|
|
|
|
* requested it.
|
|
|
|
* Note: There is a known bug in Tru64 < 5.0 in which
|
|
|
|
* the server reports NFS_DATA_SYNC, but performs
|
|
|
|
* NFS_FILE_SYNC. We therefore implement this checking
|
|
|
|
* as a dprintk() in order to avoid filling syslog.
|
|
|
|
*/
|
|
|
|
static unsigned long complain;
|
|
|
|
|
|
|
|
if (time_before(complain, jiffies)) {
|
2008-06-11 21:56:05 +00:00
|
|
|
dprintk("NFS: faulty NFS server %s:"
|
2005-04-16 22:20:36 +00:00
|
|
|
" (committed = %d) != (stable = %d)\n",
|
2009-04-01 13:22:41 +00:00
|
|
|
server->nfs_client->cl_hostname,
|
2005-04-16 22:20:36 +00:00
|
|
|
resp->verf->committed, argp->stable);
|
|
|
|
complain = jiffies + 300 * HZ;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
/* Is this a short write? */
|
|
|
|
if (task->tk_status >= 0 && resp->count < argp->count) {
|
|
|
|
static unsigned long complain;
|
|
|
|
|
2006-03-20 18:44:14 +00:00
|
|
|
nfs_inc_stats(data->inode, NFSIOS_SHORTWRITE);
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/* Has the server at least made some progress? */
|
|
|
|
if (resp->count != 0) {
|
|
|
|
/* Was this an NFSv2 write or an NFSv3 stable write? */
|
|
|
|
if (resp->verf->committed != NFS_UNSTABLE) {
|
|
|
|
/* Resend from where the server left off */
|
|
|
|
argp->offset += resp->count;
|
|
|
|
argp->pgbase += resp->count;
|
|
|
|
argp->count -= resp->count;
|
|
|
|
} else {
|
|
|
|
/* Resend as a stable write in order to avoid
|
|
|
|
* headaches in the case of a server crash.
|
|
|
|
*/
|
|
|
|
argp->stable = NFS_FILE_SYNC;
|
|
|
|
}
|
2009-12-07 14:00:24 +00:00
|
|
|
nfs_restart_rpc(task, server->nfs_client);
|
2011-02-11 15:42:38 +00:00
|
|
|
return;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
if (time_before(complain, jiffies)) {
|
|
|
|
printk(KERN_WARNING
|
|
|
|
"NFS: Server wrote zero bytes, expected %u.\n",
|
|
|
|
argp->count);
|
|
|
|
complain = jiffies + 300 * HZ;
|
|
|
|
}
|
|
|
|
/* Can't do anything about it except throw an error. */
|
|
|
|
task->tk_status = -EIO;
|
|
|
|
}
|
2011-02-11 15:42:38 +00:00
|
|
|
return;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
#if defined(CONFIG_NFS_V3) || defined(CONFIG_NFS_V4)
|
2010-04-22 19:35:57 +00:00
|
|
|
static int nfs_commit_set_lock(struct nfs_inode *nfsi, int may_wait)
|
|
|
|
{
|
|
|
|
if (!test_and_set_bit(NFS_INO_COMMIT, &nfsi->flags))
|
|
|
|
return 1;
|
|
|
|
if (may_wait && !out_of_line_wait_on_bit_lock(&nfsi->flags,
|
|
|
|
NFS_INO_COMMIT, nfs_wait_bit_killable,
|
|
|
|
TASK_KILLABLE))
|
|
|
|
return 1;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void nfs_commit_clear_lock(struct nfs_inode *nfsi)
|
|
|
|
{
|
|
|
|
clear_bit(NFS_INO_COMMIT, &nfsi->flags);
|
|
|
|
smp_mb__after_clear_bit();
|
|
|
|
wake_up_bit(&nfsi->flags, NFS_INO_COMMIT);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2010-01-26 20:42:03 +00:00
|
|
|
static void nfs_commitdata_release(void *data)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2008-02-20 01:04:20 +00:00
|
|
|
struct nfs_write_data *wdata = data;
|
|
|
|
|
|
|
|
put_nfs_open_context(wdata->args.context);
|
2005-04-16 22:20:36 +00:00
|
|
|
nfs_commit_free(wdata);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Set up the argument/result storage required for the RPC call.
|
|
|
|
*/
|
2008-04-14 18:54:53 +00:00
|
|
|
static int nfs_commit_rpcsetup(struct list_head *head,
|
2006-03-20 18:44:27 +00:00
|
|
|
struct nfs_write_data *data,
|
|
|
|
int how)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2007-07-14 19:39:59 +00:00
|
|
|
struct nfs_page *first = nfs_list_entry(head->next);
|
|
|
|
struct inode *inode = first->wb_context->path.dentry->d_inode;
|
2007-07-14 19:40:00 +00:00
|
|
|
int priority = flush_task_priority(how);
|
2007-10-25 22:42:54 +00:00
|
|
|
struct rpc_task *task;
|
2007-07-14 19:40:00 +00:00
|
|
|
struct rpc_message msg = {
|
|
|
|
.rpc_argp = &data->args,
|
|
|
|
.rpc_resp = &data->res,
|
|
|
|
.rpc_cred = first->wb_context->cred,
|
|
|
|
};
|
2007-07-14 19:39:59 +00:00
|
|
|
struct rpc_task_setup task_setup_data = {
|
2007-10-25 22:42:54 +00:00
|
|
|
.task = &data->task,
|
2007-07-14 19:39:59 +00:00
|
|
|
.rpc_client = NFS_CLIENT(inode),
|
2007-07-14 19:40:00 +00:00
|
|
|
.rpc_message = &msg,
|
2007-07-14 19:39:59 +00:00
|
|
|
.callback_ops = &nfs_commit_ops,
|
|
|
|
.callback_data = data,
|
2008-02-20 01:04:23 +00:00
|
|
|
.workqueue = nfsiod_workqueue,
|
2010-04-09 23:54:50 +00:00
|
|
|
.flags = RPC_TASK_ASYNC,
|
2007-07-14 19:40:00 +00:00
|
|
|
.priority = priority,
|
2007-07-14 19:39:59 +00:00
|
|
|
};
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/* Set up the RPC argument and reply structs
|
|
|
|
* NB: take care not to mess about with data->commit et al. */
|
|
|
|
|
|
|
|
list_splice_init(head, &data->pages);
|
|
|
|
|
|
|
|
data->inode = inode;
|
2007-07-14 19:40:00 +00:00
|
|
|
data->cred = msg.rpc_cred;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
data->args.fh = NFS_FH(data->inode);
|
2005-06-22 17:16:31 +00:00
|
|
|
/* Note: we always request a commit of the entire inode */
|
|
|
|
data->args.offset = 0;
|
|
|
|
data->args.count = 0;
|
2008-02-20 01:04:20 +00:00
|
|
|
data->args.context = get_nfs_open_context(first->wb_context);
|
2005-06-22 17:16:31 +00:00
|
|
|
data->res.count = 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
data->res.fattr = &data->fattr;
|
|
|
|
data->res.verf = &data->verf;
|
2005-10-28 02:12:38 +00:00
|
|
|
nfs_fattr_init(&data->fattr);
|
2006-03-20 18:44:27 +00:00
|
|
|
|
|
|
|
/* Set up the initial task struct. */
|
2007-07-14 19:40:00 +00:00
|
|
|
NFS_PROTO(inode)->commit_setup(data, &msg);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2007-01-31 17:14:01 +00:00
|
|
|
dprintk("NFS: %5u initiated commit call\n", data->task.tk_pid);
|
2007-07-14 19:40:00 +00:00
|
|
|
|
2007-10-25 22:42:54 +00:00
|
|
|
task = rpc_run_task(&task_setup_data);
|
2008-04-14 18:54:53 +00:00
|
|
|
if (IS_ERR(task))
|
|
|
|
return PTR_ERR(task);
|
nfs: close NFSv4 COMMIT vs. CLOSE race
I've been adding in more artificial delays in the NFSv4 commit and close
codepaths to uncover races. The kernel I'm testing has the patch to
close the race in __rpc_wait_for_completion_task that's in Trond's
cthon2011 branch. The reproducer I've been using does this in a loop:
mkdir("DIR");
fd = open("DIR/FILE", O_WRONLY|O_CREAT|O_EXCL, 0644);
write(fd, "abcdefg", 7);
close(fd);
unlink("DIR/FILE");
rmdir("DIR");
The above reproducer shouldn't result in any silly-renaming. However,
when I add a "msleep(100)" just after the nfs_commit_clear_lock call in
nfs_commit_release, I can almost always force one to occur. If I can
force it to occur with that, then it can happen without that delay
given the right timing.
nfs_commit_inode waits for the NFS_INO_COMMIT bit to clear when called
with FLUSH_SYNC set. nfs_commit_rpcsetup on the other hand does not wait
for the task to complete before putting its reference to it, so the last
reference get put in rpc_release task and gets queued to a workqueue.
In this situation, the last open context reference may be put by the
COMMIT release instead of the close() syscall. The close() syscall
returns too quickly and the unlink runs while the d_count is still
high since the COMMIT release hasn't put its dentry reference yet.
Fix this by having rpc_commit_rpcsetup wait for the RPC call to complete
before putting the task reference when FLUSH_SYNC is set. With this, the
last reference is put by the process that's initiating the FLUSH_SYNC
commit and the race is closed.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
2011-03-06 17:14:13 +00:00
|
|
|
if (how & FLUSH_SYNC)
|
|
|
|
rpc_wait_for_completion_task(task);
|
2008-04-14 18:54:53 +00:00
|
|
|
rpc_put_task(task);
|
|
|
|
return 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Commit dirty pages
|
|
|
|
*/
|
|
|
|
static int
|
2005-11-30 23:09:02 +00:00
|
|
|
nfs_commit_list(struct inode *inode, struct list_head *head, int how)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct nfs_write_data *data;
|
|
|
|
struct nfs_page *req;
|
|
|
|
|
2008-04-15 20:56:39 +00:00
|
|
|
data = nfs_commitdata_alloc();
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
if (!data)
|
|
|
|
goto out_bad;
|
|
|
|
|
|
|
|
/* Set up the argument struct */
|
2008-04-14 18:54:53 +00:00
|
|
|
return nfs_commit_rpcsetup(head, data, how);
|
2005-04-16 22:20:36 +00:00
|
|
|
out_bad:
|
|
|
|
while (!list_empty(head)) {
|
|
|
|
req = nfs_list_entry(head->next);
|
|
|
|
nfs_list_remove_request(req);
|
|
|
|
nfs_mark_request_commit(req);
|
2006-07-05 17:17:12 +00:00
|
|
|
dec_zone_page_state(req->wb_page, NR_UNSTABLE_NFS);
|
2007-10-17 06:25:47 +00:00
|
|
|
dec_bdi_stat(req->wb_page->mapping->backing_dev_info,
|
|
|
|
BDI_RECLAIMABLE);
|
2007-06-17 19:10:24 +00:00
|
|
|
nfs_clear_page_tag_locked(req);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2010-04-22 19:35:57 +00:00
|
|
|
nfs_commit_clear_lock(NFS_I(inode));
|
2005-04-16 22:20:36 +00:00
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* COMMIT call returned
|
|
|
|
*/
|
2006-03-20 18:44:27 +00:00
|
|
|
static void nfs_commit_done(struct rpc_task *task, void *calldata)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2006-01-03 08:55:04 +00:00
|
|
|
struct nfs_write_data *data = calldata;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2007-01-31 17:14:01 +00:00
|
|
|
dprintk("NFS: %5u nfs_commit_done (status %d)\n",
|
2005-04-16 22:20:36 +00:00
|
|
|
task->tk_pid, task->tk_status);
|
|
|
|
|
2006-03-20 18:44:27 +00:00
|
|
|
/* Call the NFS version-specific code */
|
|
|
|
if (NFS_PROTO(data->inode)->commit_done(task, data) != 0)
|
|
|
|
return;
|
2008-04-15 20:56:39 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void nfs_commit_release(void *calldata)
|
|
|
|
{
|
|
|
|
struct nfs_write_data *data = calldata;
|
|
|
|
struct nfs_page *req;
|
|
|
|
int status = data->task.tk_status;
|
2006-03-20 18:44:27 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
while (!list_empty(&data->pages)) {
|
|
|
|
req = nfs_list_entry(data->pages.next);
|
|
|
|
nfs_list_remove_request(req);
|
2008-06-13 17:25:22 +00:00
|
|
|
nfs_clear_request_commit(req);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-06-11 21:56:05 +00:00
|
|
|
dprintk("NFS: commit (%s/%lld %d@%lld)",
|
2007-06-05 14:42:27 +00:00
|
|
|
req->wb_context->path.dentry->d_inode->i_sb->s_id,
|
|
|
|
(long long)NFS_FILEID(req->wb_context->path.dentry->d_inode),
|
2005-04-16 22:20:36 +00:00
|
|
|
req->wb_bytes,
|
|
|
|
(long long)req_offset(req));
|
2008-04-15 20:56:39 +00:00
|
|
|
if (status < 0) {
|
|
|
|
nfs_context_set_write_error(req->wb_context, status);
|
2005-04-16 22:20:36 +00:00
|
|
|
nfs_inode_remove_request(req);
|
2008-04-15 20:56:39 +00:00
|
|
|
dprintk(", error = %d\n", status);
|
2005-04-16 22:20:36 +00:00
|
|
|
goto next;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Okay, COMMIT succeeded, apparently. Check the verifier
|
|
|
|
* returned by the server against all stored verfs. */
|
|
|
|
if (!memcmp(req->wb_verf.verifier, data->verf.verifier, sizeof(data->verf.verifier))) {
|
|
|
|
/* We have a match */
|
|
|
|
nfs_inode_remove_request(req);
|
|
|
|
dprintk(" OK\n");
|
|
|
|
goto next;
|
|
|
|
}
|
|
|
|
/* We have a mismatch. Write the page again */
|
|
|
|
dprintk(" mismatch\n");
|
2008-03-19 15:24:38 +00:00
|
|
|
nfs_mark_request_dirty(req);
|
2005-04-16 22:20:36 +00:00
|
|
|
next:
|
2007-06-17 19:10:24 +00:00
|
|
|
nfs_clear_page_tag_locked(req);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2010-04-22 19:35:57 +00:00
|
|
|
nfs_commit_clear_lock(NFS_I(data->inode));
|
2008-04-15 20:56:39 +00:00
|
|
|
nfs_commitdata_release(calldata);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2006-03-20 18:44:27 +00:00
|
|
|
|
|
|
|
static const struct rpc_call_ops nfs_commit_ops = {
|
2009-04-01 13:22:27 +00:00
|
|
|
#if defined(CONFIG_NFS_V4_1)
|
|
|
|
.rpc_call_prepare = nfs_write_prepare,
|
|
|
|
#endif /* CONFIG_NFS_V4_1 */
|
2006-03-20 18:44:27 +00:00
|
|
|
.rpc_call_done = nfs_commit_done,
|
|
|
|
.rpc_release = nfs_commit_release,
|
|
|
|
};
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-07-30 19:31:54 +00:00
|
|
|
int nfs_commit_inode(struct inode *inode, int how)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
LIST_HEAD(head);
|
2010-04-22 19:35:57 +00:00
|
|
|
int may_wait = how & FLUSH_SYNC;
|
|
|
|
int res = 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-04-22 19:35:57 +00:00
|
|
|
if (!nfs_commit_set_lock(NFS_I(inode), may_wait))
|
2010-05-26 12:42:11 +00:00
|
|
|
goto out_mark_dirty;
|
2007-07-02 13:57:54 +00:00
|
|
|
spin_lock(&inode->i_lock);
|
2005-06-22 17:16:31 +00:00
|
|
|
res = nfs_scan_commit(inode, &head, 0, 0);
|
2007-07-02 13:57:54 +00:00
|
|
|
spin_unlock(&inode->i_lock);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (res) {
|
2006-03-20 18:44:50 +00:00
|
|
|
int error = nfs_commit_list(inode, &head, how);
|
2005-06-22 17:16:31 +00:00
|
|
|
if (error < 0)
|
|
|
|
return error;
|
2010-04-22 19:35:57 +00:00
|
|
|
if (may_wait)
|
|
|
|
wait_on_bit(&NFS_I(inode)->flags, NFS_INO_COMMIT,
|
|
|
|
nfs_wait_bit_killable,
|
|
|
|
TASK_KILLABLE);
|
2010-05-26 12:42:11 +00:00
|
|
|
else
|
|
|
|
goto out_mark_dirty;
|
2010-04-22 19:35:57 +00:00
|
|
|
} else
|
|
|
|
nfs_commit_clear_lock(NFS_I(inode));
|
2010-05-26 12:42:11 +00:00
|
|
|
return res;
|
|
|
|
/* Note: If we exit without ensuring that the commit is complete,
|
|
|
|
* we must mark the inode as dirty. Otherwise, future calls to
|
|
|
|
* sync_inode() with the WB_SYNC_ALL flag set will fail to ensure
|
|
|
|
* that the data is on the disk.
|
|
|
|
*/
|
|
|
|
out_mark_dirty:
|
|
|
|
__mark_inode_dirty(inode, I_DIRTY_DATASYNC);
|
2005-04-16 22:20:36 +00:00
|
|
|
return res;
|
|
|
|
}
|
2010-02-20 00:46:56 +00:00
|
|
|
|
|
|
|
static int nfs_commit_unstable_pages(struct inode *inode, struct writeback_control *wbc)
|
|
|
|
{
|
2010-02-20 01:00:02 +00:00
|
|
|
struct nfs_inode *nfsi = NFS_I(inode);
|
|
|
|
int flags = FLUSH_SYNC;
|
|
|
|
int ret = 0;
|
2010-02-20 00:46:56 +00:00
|
|
|
|
2010-09-28 13:14:01 +00:00
|
|
|
if (wbc->sync_mode == WB_SYNC_NONE) {
|
|
|
|
/* Don't commit yet if this is a non-blocking flush and there
|
|
|
|
* are a lot of outstanding writes for this mapping.
|
|
|
|
*/
|
|
|
|
if (nfsi->ncommit <= (nfsi->npages >> 1))
|
|
|
|
goto out_mark_dirty;
|
2010-02-20 01:00:02 +00:00
|
|
|
|
2010-09-28 13:14:01 +00:00
|
|
|
/* don't wait for the COMMIT response */
|
2010-02-20 01:00:02 +00:00
|
|
|
flags = 0;
|
2010-09-28 13:14:01 +00:00
|
|
|
}
|
|
|
|
|
2010-02-20 01:00:02 +00:00
|
|
|
ret = nfs_commit_inode(inode, flags);
|
|
|
|
if (ret >= 0) {
|
|
|
|
if (wbc->sync_mode == WB_SYNC_NONE) {
|
|
|
|
if (ret < wbc->nr_to_write)
|
|
|
|
wbc->nr_to_write -= ret;
|
|
|
|
else
|
|
|
|
wbc->nr_to_write = 0;
|
|
|
|
}
|
2010-02-20 00:46:56 +00:00
|
|
|
return 0;
|
2010-02-20 01:00:02 +00:00
|
|
|
}
|
|
|
|
out_mark_dirty:
|
2010-02-20 00:46:56 +00:00
|
|
|
__mark_inode_dirty(inode, I_DIRTY_DATASYNC);
|
|
|
|
return ret;
|
|
|
|
}
|
2007-04-02 23:29:52 +00:00
|
|
|
#else
|
2010-02-20 00:46:56 +00:00
|
|
|
static int nfs_commit_unstable_pages(struct inode *inode, struct writeback_control *wbc)
|
|
|
|
{
|
|
|
|
return 0;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
#endif
|
|
|
|
|
2010-02-20 00:46:56 +00:00
|
|
|
int nfs_write_inode(struct inode *inode, struct writeback_control *wbc)
|
|
|
|
{
|
|
|
|
return nfs_commit_unstable_pages(inode, wbc);
|
|
|
|
}
|
|
|
|
|
2010-02-20 01:03:26 +00:00
|
|
|
/*
|
|
|
|
* flush the inode to disk.
|
|
|
|
*/
|
|
|
|
int nfs_wb_all(struct inode *inode)
|
2007-07-25 18:09:54 +00:00
|
|
|
{
|
|
|
|
struct writeback_control wbc = {
|
2009-03-11 18:10:30 +00:00
|
|
|
.sync_mode = WB_SYNC_ALL,
|
2007-07-25 18:09:54 +00:00
|
|
|
.nr_to_write = LONG_MAX,
|
2008-10-07 00:08:56 +00:00
|
|
|
.range_start = 0,
|
|
|
|
.range_end = LLONG_MAX,
|
2007-07-25 18:09:54 +00:00
|
|
|
};
|
|
|
|
|
2010-02-20 01:03:26 +00:00
|
|
|
return sync_inode(inode, &wbc);
|
2006-10-09 20:18:38 +00:00
|
|
|
}
|
|
|
|
|
2007-08-28 14:29:36 +00:00
|
|
|
int nfs_wb_page_cancel(struct inode *inode, struct page *page)
|
|
|
|
{
|
|
|
|
struct nfs_page *req;
|
|
|
|
int ret = 0;
|
|
|
|
|
|
|
|
BUG_ON(!PageLocked(page));
|
|
|
|
for (;;) {
|
2010-04-27 22:33:54 +00:00
|
|
|
wait_on_page_writeback(page);
|
2007-08-28 14:29:36 +00:00
|
|
|
req = nfs_page_find_request(page);
|
|
|
|
if (req == NULL)
|
|
|
|
break;
|
|
|
|
if (nfs_lock_request_dontget(req)) {
|
|
|
|
nfs_inode_remove_request(req);
|
|
|
|
/*
|
|
|
|
* In case nfs_inode_remove_request has marked the
|
|
|
|
* page as being dirty
|
|
|
|
*/
|
|
|
|
cancel_dirty_page(page, PAGE_CACHE_SIZE);
|
|
|
|
nfs_unlock_request(req);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
ret = nfs_wait_on_request(req);
|
2010-01-26 20:41:34 +00:00
|
|
|
nfs_release_request(req);
|
2007-08-28 14:29:36 +00:00
|
|
|
if (ret < 0)
|
2010-02-20 01:03:21 +00:00
|
|
|
break;
|
2007-08-28 14:29:36 +00:00
|
|
|
}
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2010-02-20 01:03:28 +00:00
|
|
|
/*
|
|
|
|
* Write back all requests on one page - we do this before reading it.
|
|
|
|
*/
|
|
|
|
int nfs_wb_page(struct inode *inode, struct page *page)
|
2006-10-09 20:18:38 +00:00
|
|
|
{
|
|
|
|
loff_t range_start = page_offset(page);
|
|
|
|
loff_t range_end = range_start + (loff_t)(PAGE_CACHE_SIZE - 1);
|
2006-12-05 05:35:41 +00:00
|
|
|
struct writeback_control wbc = {
|
|
|
|
.sync_mode = WB_SYNC_ALL,
|
2010-02-20 01:03:28 +00:00
|
|
|
.nr_to_write = 0,
|
2006-12-05 05:35:41 +00:00
|
|
|
.range_start = range_start,
|
|
|
|
.range_end = range_end,
|
|
|
|
};
|
|
|
|
int ret;
|
2006-10-09 20:18:38 +00:00
|
|
|
|
2010-05-26 12:42:24 +00:00
|
|
|
for (;;) {
|
2010-04-27 22:33:54 +00:00
|
|
|
wait_on_page_writeback(page);
|
2008-04-11 20:03:54 +00:00
|
|
|
if (clear_page_dirty_for_io(page)) {
|
|
|
|
ret = nfs_writepage_locked(page, &wbc);
|
|
|
|
if (ret < 0)
|
|
|
|
goto out_error;
|
2010-05-26 12:42:24 +00:00
|
|
|
continue;
|
2010-02-20 01:03:28 +00:00
|
|
|
}
|
2010-05-26 12:42:24 +00:00
|
|
|
if (!PagePrivate(page))
|
|
|
|
break;
|
|
|
|
ret = nfs_commit_inode(inode, FLUSH_SYNC);
|
2010-04-27 22:33:54 +00:00
|
|
|
if (ret < 0)
|
2008-04-11 20:03:54 +00:00
|
|
|
goto out_error;
|
2010-02-20 01:03:28 +00:00
|
|
|
}
|
2008-04-11 20:03:54 +00:00
|
|
|
return 0;
|
|
|
|
out_error:
|
2006-12-05 05:35:41 +00:00
|
|
|
return ret;
|
2006-10-09 20:18:38 +00:00
|
|
|
}
|
|
|
|
|
2009-08-10 12:54:13 +00:00
|
|
|
#ifdef CONFIG_MIGRATION
|
|
|
|
int nfs_migrate_page(struct address_space *mapping, struct page *newpage,
|
|
|
|
struct page *page)
|
|
|
|
{
|
|
|
|
struct nfs_page *req;
|
|
|
|
int ret;
|
|
|
|
|
2010-02-08 14:32:34 +00:00
|
|
|
nfs_fscache_release_page(page, GFP_KERNEL);
|
2009-08-10 12:54:13 +00:00
|
|
|
|
2010-07-30 19:31:57 +00:00
|
|
|
req = nfs_find_and_lock_request(page, false);
|
2009-08-10 12:54:13 +00:00
|
|
|
ret = PTR_ERR(req);
|
|
|
|
if (IS_ERR(req))
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
ret = migrate_page(mapping, newpage, page);
|
|
|
|
if (!req)
|
|
|
|
goto out;
|
|
|
|
if (ret)
|
|
|
|
goto out_unlock;
|
|
|
|
page_cache_get(newpage);
|
2009-12-10 14:05:55 +00:00
|
|
|
spin_lock(&mapping->host->i_lock);
|
2009-08-10 12:54:13 +00:00
|
|
|
req->wb_page = newpage;
|
|
|
|
SetPagePrivate(newpage);
|
2009-12-10 14:05:55 +00:00
|
|
|
set_page_private(newpage, (unsigned long)req);
|
2009-08-10 12:54:13 +00:00
|
|
|
ClearPagePrivate(page);
|
|
|
|
set_page_private(page, 0);
|
2009-12-10 14:05:55 +00:00
|
|
|
spin_unlock(&mapping->host->i_lock);
|
2009-08-10 12:54:13 +00:00
|
|
|
page_cache_release(page);
|
|
|
|
out_unlock:
|
|
|
|
nfs_clear_page_tag_locked(req);
|
|
|
|
out:
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
NFS: Split fs/nfs/inode.c
As fs/nfs/inode.c is rather large, heterogenous and unwieldy, the attached
patch splits it up into a number of files:
(*) fs/nfs/inode.c
Strictly inode specific functions.
(*) fs/nfs/super.c
Superblock management functions for NFS and NFS4, normal access, clones
and referrals. The NFS4 superblock functions _could_ move out into a
separate conditionally compiled file, but it's probably not worth it as
there're so many common bits.
(*) fs/nfs/namespace.c
Some namespace-specific functions have been moved here.
(*) fs/nfs/nfs4namespace.c
NFS4-specific namespace functions (this could be merged into the previous
file). This file is conditionally compiled.
(*) fs/nfs/internal.h
Inter-file declarations, plus a few simple utility functions moved from
fs/nfs/inode.c.
Additionally, all the in-.c-file externs have been moved here, and those
files they were moved from now includes this file.
For the most part, the functions have not been changed, only some multiplexor
functions have changed significantly.
I've also:
(*) Added some extra banner comments above some functions.
(*) Rearranged the function order within the files to be more logical and
better grouped (IMO), though someone may prefer a different order.
(*) Reduced the number of #ifdefs in .c files.
(*) Added missing __init and __exit directives.
Signed-Off-By: David Howells <dhowells@redhat.com>
2006-06-09 13:34:33 +00:00
|
|
|
int __init nfs_init_writepagecache(void)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
nfs_wdata_cachep = kmem_cache_create("nfs_write_data",
|
|
|
|
sizeof(struct nfs_write_data),
|
|
|
|
0, SLAB_HWCACHE_ALIGN,
|
2007-07-20 01:11:58 +00:00
|
|
|
NULL);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (nfs_wdata_cachep == NULL)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
2006-03-26 09:37:50 +00:00
|
|
|
nfs_wdata_mempool = mempool_create_slab_pool(MIN_POOL_WRITE,
|
|
|
|
nfs_wdata_cachep);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (nfs_wdata_mempool == NULL)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
2006-03-26 09:37:50 +00:00
|
|
|
nfs_commit_mempool = mempool_create_slab_pool(MIN_POOL_COMMIT,
|
|
|
|
nfs_wdata_cachep);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (nfs_commit_mempool == NULL)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
2007-03-16 21:38:26 +00:00
|
|
|
/*
|
|
|
|
* NFS congestion size, scale with available memory.
|
|
|
|
*
|
|
|
|
* 64MB: 8192k
|
|
|
|
* 128MB: 11585k
|
|
|
|
* 256MB: 16384k
|
|
|
|
* 512MB: 23170k
|
|
|
|
* 1GB: 32768k
|
|
|
|
* 2GB: 46340k
|
|
|
|
* 4GB: 65536k
|
|
|
|
* 8GB: 92681k
|
|
|
|
* 16GB: 131072k
|
|
|
|
*
|
|
|
|
* This allows larger machines to have larger/more transfers.
|
|
|
|
* Limit the default to 256M
|
|
|
|
*/
|
|
|
|
nfs_congestion_kb = (16*int_sqrt(totalram_pages)) << (PAGE_SHIFT-10);
|
|
|
|
if (nfs_congestion_kb > 256*1024)
|
|
|
|
nfs_congestion_kb = 256*1024;
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2006-06-27 19:59:15 +00:00
|
|
|
void nfs_destroy_writepagecache(void)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
mempool_destroy(nfs_commit_mempool);
|
|
|
|
mempool_destroy(nfs_wdata_mempool);
|
2006-09-27 08:49:40 +00:00
|
|
|
kmem_cache_destroy(nfs_wdata_cachep);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|