ar
/
gorepost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't use bytes.Buffer when not needed.

configurable-file-paths
Robert Gerus 2015-11-20 10:27:09 +01:00
parent 970883081b
commit 9bec013fe7
2 changed files with 2 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
bot/nickserv.go
View File

@ -5,7 +5,6 @@
package bot
import (
"bytes"
"fmt"
"log"
"regexp"
@ -25,10 +24,7 @@ func nickserv(output chan irc.Message, msg irc.Message) {
regexStr = "^This nickname is registered"
}
buffer := new(bytes.Buffer)
buffer.WriteString(msg.Trailing)
b, err := regexp.Match(regexStr, buffer.Bytes())
b, err := regexp.Match(regexStr, []byte(msg.Trailing))
if err != nil {
log.Println("Context:", msg.Context, "NickServ regex error:", err)
return
@ -57,10 +53,7 @@ func joinsecuredchannels(output chan irc.Message, msg irc.Message) {
regexStr = "^You are now identified"
}
buffer := new(bytes.Buffer)
buffer.WriteString(msg.Trailing)
b, err := regexp.Match(regexStr, buffer.Bytes())
b, err := regexp.Match(regexStr, []byte(msg.Trailing))
if err != nil {
log.Println("Context:", msg.Context, "NickServ regex error:", err)
return

7
irc/message.go
View File

@ -94,13 +94,6 @@ func (p *Prefix) Len() (length int) {
return
}
// Bytes returns a []byte representation of this prefix.
func (p *Prefix) Bytes() []byte {
buffer := new(bytes.Buffer)
p.writeTo(buffer)
return buffer.Bytes()
}
// String returns a string representation of this prefix.
func (p *Prefix) String() (s string) {
// Benchmarks revealed that in this case simple string concatenation